Skip to content

Support default from sequence #4826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 27, 2024
Merged

Support default from sequence #4826

merged 8 commits into from
May 27, 2024

Conversation

@shnikd
Copy link
Contributor

@shnikd shnikd commented May 24, 2024

No description provided.

@shnikd shnikd requested a review from a team as a code owner May 24, 2024 11:13
vitstn
vitstn previously approved these changes May 24, 2024
View reviewed changes
@shnikd shnikd force-pushed the default-from-sequence branch from 6ff7a8e to 3483a51 Compare May 24, 2024 11:24
@github-actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 11:25:22 UTC Pre-commit check for 2e8ecff has started.
⚪ 2024-05-24 11:27:52 UTC Build linux-x86_64-release-asan is running...
🔴 2024-05-24 11:31:07 UTC Build failed. see the build logs.
🔴 2024-05-24 11:31:08 UTC Tests run skipped.

@github-actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 11:28:05 UTC Pre-commit check for 2e8ecff has started.
⚪ 2024-05-24 11:30:40 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-05-24 11:33:56 UTC Build failed. see the build logs.

@github-actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 11:29:09 UTC Pre-commit check for 2e8ecff has started.
⚪ 2024-05-24 11:31:44 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-05-24 11:35:16 UTC Build failed. see the build logs.
🔴 2024-05-24 11:35:18 UTC Tests run skipped.

@github-actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 11:38:33 UTC Pre-commit check for c354503 has started.
⚪ 2024-05-24 11:41:05 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-05-24 11:55:34 UTC Build failed. see the build logs.
🔴 2024-05-24 11:55:35 UTC Tests run skipped.

@github-actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 11:38:39 UTC Pre-commit check for c354503 has started.
⚪ 2024-05-24 11:41:18 UTC Build linux-x86_64-release-asan is running...
🔴 2024-05-24 11:58:27 UTC Build failed. see the build logs.
🔴 2024-05-24 11:58:28 UTC Tests run skipped.

@github-actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 11:39:01 UTC Pre-commit check for c354503 has started.
⚪ 2024-05-24 11:41:39 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-05-24 11:58:23 UTC Build failed. see the build logs.

@github-actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 12:12:48 UTC Pre-commit check for f031fa4 has started.
⚪ 2024-05-24 12:15:14 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-24 12:16:58 UTC Build successful.

@github-actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 12:19:39 UTC Pre-commit check for f031fa4 has started.
⚪ 2024-05-24 12:22:06 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-24 12:23:51 UTC Build successful.
⚪ 2024-05-24 12:24:03 UTC Tests are running...
🔴 2024-05-24 13:01:10 UTC Test run completed, no test results found for commit ec460b7. Please check build logs.
⚫ 2024-05-24 13:01:17 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 12:27:35 UTC Pre-commit check for f031fa4 has started.
⚪ 2024-05-24 12:30:07 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-24 12:31:53 UTC Build successful.
⚪ 2024-05-24 12:32:05 UTC Tests are running...
🔴 2024-05-24 13:01:09 UTC Test run completed, no test results found for commit ec460b7. Please check build logs.
⚫ 2024-05-24 13:01:16 UTC Check cancelled

vitstn
vitstn previously approved these changes May 24, 2024
View reviewed changes
@github-actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 14:11:42 UTC Pre-commit check for 837cdec has started.
⚪ 2024-05-24 14:14:06 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-24 14:17:35 UTC Build successful.
⚪ 2024-05-24 14:17:46 UTC Tests are running...
🔴 2024-05-24 16:09:51 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
69354 56637 0 6 12702 9

@github-actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 14:12:43 UTC Pre-commit check for 837cdec has started.
⚪ 2024-05-24 14:15:44 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-24 14:19:26 UTC Build successful.
⚪ 2024-05-24 14:19:35 UTC Tests are running...
🔴 2024-05-24 16:22:21 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10274 10157 0 41 59 17

@github-actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 14:20:22 UTC Pre-commit check for 837cdec has started.
⚪ 2024-05-24 14:22:55 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-24 14:27:10 UTC Build successful.

ijon
ijon previously approved these changes May 24, 2024
View reviewed changes
@shnikd shnikd dismissed stale reviews from ijon and vitstn via f21553c May 24, 2024 19:26
@github-actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 19:29:32 UTC Pre-commit check for 693af68 has started.
⚪ 2024-05-24 19:32:10 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-24 19:36:16 UTC Build successful.

@github-actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-26 20:26:28 UTC Pre-commit check for 693af68 has started.
⚪ 2024-05-26 20:29:00 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-26 20:30:08 UTC Build successful.
⚪ 2024-05-26 20:30:19 UTC Tests are running...
🔴 2024-05-26 22:28:37 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13385 13284 0 32 54 15

@github-actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-26 20:26:18 UTC Pre-commit check for 693af68 has started.
⚪ 2024-05-26 20:28:51 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-26 20:29:59 UTC Build successful.
⚪ 2024-05-26 20:30:13 UTC Tests are running...
🔴 2024-05-26 22:24:43 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
72468 59757 0 1 12702 8

gridnevvvit
gridnevvvit approved these changes May 27, 2024
View reviewed changes
ydb/core/kqp/provider/yql_kikimr_exec.cpp Outdated
for (auto family : families) {
alter_columns->set_family(TString(family.Value()));
auto alterColumnList = columnTuple.Item(1).Cast<TExprList>();
if (TString(alterColumnList.Item(0).Cast<TCoAtom>()) = "setDefault") {
Copy link
Member

@gridnevvvit gridnevvvit May 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like if family will be named as "setDefault" in this case code will think that we are altering default value.

@shnikd shnikd merged commit cb83f09 into ydb-platform:main May 27, 2024
@niksaveliev niksaveliev mentioned this pull request May 27, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request May 28, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request May 29, 2024
Merged
This was referenced May 29, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request May 30, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request May 31, 2024
Merged
This was referenced Jun 6, 2024
Closed
Closed
Merged
Merged
@serbel324 serbel324 mentioned this pull request Jun 7, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 10, 2024
Merged
This was referenced Jun 11, 2024
Merged
Merged
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 17, 2024
Closed
This was referenced Jun 19, 2024
Merged
Merged
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vitstn vitstn vitstn approved these changes

@gridnevvvit gridnevvvit gridnevvvit approved these changes

@ijon ijon ijon left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shnikd @ijon @vitstn @gridnevvvit