Skip to content

speed up records merge #4822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 27, 2024
Merged

speed up records merge #4822

merged 4 commits into from
May 27, 2024

Conversation

@ivanmorozov333
Copy link
Collaborator

@ivanmorozov333 ivanmorozov333 commented May 24, 2024

  • Performance improvement

@github-actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 10:21:45 UTC Pre-commit check for 8266dad has started.
⚪ 2024-05-24 10:24:19 UTC Build linux-x86_64-release-asan is running...
🔴 2024-05-24 10:29:14 UTC Build failed. see the build logs.
🔴 2024-05-24 10:29:16 UTC Tests run skipped.

@github-actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 10:22:21 UTC Pre-commit check for 8266dad has started.
⚪ 2024-05-24 10:24:51 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-05-24 10:29:45 UTC Build failed. see the build logs.

@github-actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 10:22:42 UTC Pre-commit check for 8266dad has started.
⚪ 2024-05-24 10:25:20 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-05-24 10:30:58 UTC Build failed. see the build logs.
🔴 2024-05-24 10:30:59 UTC Tests run skipped.

@github-actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 13:02:15 UTC Pre-commit check for 9da9531 has started.
⚪ 2024-05-24 13:04:48 UTC Build linux-x86_64-release-clang14 is running...
⚫ 2024-05-24 13:39:20 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 13:17:27 UTC Pre-commit check for 9da9531 has started.
⚪ 2024-05-24 13:19:57 UTC Build linux-x86_64-release-asan is running...
🔴 2024-05-24 13:36:42 UTC Build failed. see the build logs.
🔴 2024-05-24 13:36:43 UTC Tests run skipped.

@github-actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 13:20:12 UTC Pre-commit check for 9da9531 has started.
⚪ 2024-05-24 13:22:45 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-05-24 13:27:33 UTC Build failed. see the build logs.
🔴 2024-05-24 13:27:34 UTC Tests run skipped.

@ivanmorozov333 ivanmorozov333 added the rebase-and-check Rebase PR with the current base branch and check label May 24, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label May 24, 2024
@github-actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 15:45:28 UTC Pre-commit check for 1c9fffe has started.
⚪ 2024-05-24 15:47:52 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-24 16:28:26 UTC Build successful.

@github-actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 15:46:38 UTC Pre-commit check for 1c9fffe has started.
⚪ 2024-05-24 15:49:03 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-24 16:18:00 UTC Build successful.
⚪ 2024-05-24 16:18:12 UTC Tests are running...
🔴 2024-05-24 17:52:23 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
37066 32275 0 3 4781 7

@github-actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 16:03:29 UTC Pre-commit check for 1c9fffe has started.
⚪ 2024-05-24 16:05:57 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-24 16:21:54 UTC Build successful.
⚪ 2024-05-24 16:22:06 UTC Tests are running...
🔴 2024-05-24 18:09:50 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9574 9512 0 16 25 21

@github-actions
Copy link

github-actions bot commented May 26, 2024 •
edited
Loading

⚪ 2024-05-26 08:11:38 UTC Pre-commit check for c830a90 has started.
⚪ 2024-05-26 08:14:10 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-26 08:19:30 UTC Build successful.
⚪ 2024-05-26 08:19:46 UTC Tests are running...
🔴 2024-05-26 09:53:27 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
37068 32272 0 4 4781 11

@github-actions
Copy link

github-actions bot commented May 26, 2024 •
edited
Loading

⚪ 2024-05-26 08:11:46 UTC Pre-commit check for c830a90 has started.
⚪ 2024-05-26 08:14:22 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-26 08:23:51 UTC Build successful.

@github-actions
Copy link

github-actions bot commented May 26, 2024 •
edited
Loading

⚪ 2024-05-26 08:11:56 UTC Pre-commit check for c830a90 has started.
⚪ 2024-05-26 08:14:30 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-26 08:20:05 UTC Build successful.
⚪ 2024-05-26 08:20:17 UTC Tests are running...
🔴 2024-05-26 10:17:29 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9578 9503 0 28 33 14

@ivanmorozov333 ivanmorozov333 merged commit d90f291 into ydb-platform:main May 27, 2024
@ivanmorozov333 ivanmorozov333 deleted the improve_records_merging branch May 27, 2024 07:58
@niksaveliev niksaveliev mentioned this pull request May 27, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request May 28, 2024
Merged
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request May 29, 2024
@ivanmorozov333 @zverevgeny
speed up records merge (ydb-platform#4822)
6b32c85
@niksaveliev niksaveliev mentioned this pull request May 29, 2024
Merged
This was referenced May 29, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request May 30, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request May 31, 2024
Merged
This was referenced Jun 6, 2024
Closed
Closed
Merged
Merged
@serbel324 serbel324 mentioned this pull request Jun 7, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 10, 2024
Merged
This was referenced Jun 11, 2024
Merged
Merged
Merged
Merged
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jun 17, 2024
@ivanmorozov333 @zverevgeny
speed up records merge (ydb-platform#4822)
eaf99c7 
Conflicts:
	ydb/core/tx/columnshard/engines/changes/indexation.cpp
	ydb/core/tx/columnshard/engines/reader/plain_reader/iterator/source.h
@niksaveliev niksaveliev mentioned this pull request Jun 17, 2024
Closed
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jun 18, 2024
@ivanmorozov333 @zverevgeny
speed up records merge (ydb-platform#4822)
6065a11 
Conflicts:
	ydb/core/tx/columnshard/engines/changes/indexation.cpp
	ydb/core/tx/columnshard/engines/reader/plain_reader/iterator/source.h
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jun 18, 2024
@ivanmorozov333 @zverevgeny
speed up records merge (ydb-platform#4822)
ef97f2b 
Conflicts:
	ydb/core/tx/columnshard/engines/changes/indexation.cpp
	ydb/core/tx/columnshard/engines/reader/plain_reader/iterator/source.h
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jun 18, 2024
@ivanmorozov333 @zverevgeny
speed up records merge (ydb-platform#4822)
36abdae 
Conflicts:
	ydb/core/tx/columnshard/engines/changes/indexation.cpp
	ydb/core/tx/columnshard/engines/reader/plain_reader/iterator/source.h
This was referenced Jun 19, 2024
Merged
Merged
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zverevgeny zverevgeny zverevgeny approved these changes

Assignees

No one assigned

Labels

performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ivanmorozov333 @zverevgeny