Skip to content

improve CS-resharding #4775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 24, 2024
Merged

improve CS-resharding #4775

merged 3 commits into from
May 24, 2024

Conversation

@ivanmorozov333
Copy link
Collaborator

@ivanmorozov333 ivanmorozov333 commented May 23, 2024

tests
fixes

  • New feature
  • Experimental feature
  • Improvement
  • Bugfix

@github-actions
Copy link

github-actions bot commented May 23, 2024 •
edited
Loading

⚪ 2024-05-23 10:23:34 UTC Pre-commit check for 67118f4 has started.
⚪ 2024-05-23 10:26:32 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-05-23 11:01:55 UTC Build failed. see the build logs.

@github-actions
Copy link

github-actions bot commented May 23, 2024 •
edited
Loading

⚪ 2024-05-23 10:30:38 UTC Pre-commit check for 67118f4 has started.
⚪ 2024-05-23 10:33:19 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-05-23 11:15:46 UTC Build failed. see the build logs.
🔴 2024-05-23 11:15:47 UTC Tests run skipped.

@github-actions
Copy link

github-actions bot commented May 23, 2024 •
edited
Loading

⚪ 2024-05-23 10:39:40 UTC Pre-commit check for 67118f4 has started.
⚪ 2024-05-23 10:42:28 UTC Build linux-x86_64-release-asan is running...
🔴 2024-05-23 11:20:26 UTC Build failed. see the build logs.
🔴 2024-05-23 11:20:27 UTC Tests run skipped.

@github-actions
Copy link

github-actions bot commented May 23, 2024 •
edited
Loading

⚪ 2024-05-23 13:45:17 UTC Pre-commit check for 6def903 has started.
⚪ 2024-05-23 13:48:05 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-23 14:16:35 UTC Build successful.
⚪ 2024-05-23 14:16:48 UTC Tests are running...
🔴 2024-05-23 16:07:44 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10895 10841 0 20 24 10

@github-actions
Copy link

github-actions bot commented May 23, 2024 •
edited
Loading

⚪ 2024-05-23 13:45:22 UTC Pre-commit check for 6def903 has started.
⚪ 2024-05-23 13:48:18 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-23 14:16:59 UTC Build successful.

@github-actions
Copy link

github-actions bot commented May 23, 2024 •
edited
Loading

⚪ 2024-05-23 13:45:30 UTC Pre-commit check for 6def903 has started.
⚪ 2024-05-23 13:48:24 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-23 14:19:31 UTC Build successful.
⚪ 2024-05-23 14:19:46 UTC Tests are running...
🔴 2024-05-23 16:01:58 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38372 33573 0 2 4788 9

@github-actions
Copy link

github-actions bot commented May 23, 2024 •
edited
Loading

⚪ 2024-05-23 17:40:37 UTC Pre-commit check for fbc0da4 has started.
⚪ 2024-05-23 17:43:23 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-23 17:45:16 UTC Build successful.
⚪ 2024-05-23 17:45:26 UTC Tests are running...
🔴 2024-05-23 19:19:56 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38376 33565 0 4 4788 19

@github-actions
Copy link

github-actions bot commented May 23, 2024 •
edited
Loading

⚪ 2024-05-23 17:41:33 UTC Pre-commit check for fbc0da4 has started.
⚪ 2024-05-23 17:44:25 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-23 17:46:16 UTC Build successful.
⚪ 2024-05-23 17:46:26 UTC Tests are running...
🔴 2024-05-23 19:44:25 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10897 10811 0 29 38 19

@github-actions
Copy link

github-actions bot commented May 23, 2024 •
edited
Loading

⚪ 2024-05-23 17:42:30 UTC Pre-commit check for fbc0da4 has started.
⚪ 2024-05-23 17:45:21 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-23 17:47:22 UTC Build successful.

ijon
ijon approved these changes May 24, 2024
View reviewed changes
ydb/public/lib/operation_id/operation_id.cpp
}

Ydb::TOperationId::EKind ParseKind(const TStringBuf value) {
if (value.StartsWith("ss/backgrounds")) {
Copy link
Collaborator

@ijon ijon May 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это уже имя, видимое пользователям. Оно используется в pseudo uri, поэтому я бы поостерёгся использовать /, чтобы не столкнуться потом вдруг с необходимостью применять urldecode.
И само имя я бы поискал получше: process, task, schemeprocess и т.п.

@ivanmorozov333 ivanmorozov333 merged commit f6fa669 into ydb-platform:main May 24, 2024
@ivanmorozov333 ivanmorozov333 deleted the resharding_tests branch May 24, 2024 13:40
This was referenced May 27, 2024
Closed
Closed
Merged
Merged
This was referenced May 29, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request May 30, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request May 31, 2024
Merged
This was referenced Jun 6, 2024
Closed
Closed
Merged
Merged
@serbel324 serbel324 mentioned this pull request Jun 7, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 10, 2024
Merged
This was referenced Jun 11, 2024
Merged
Merged
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 17, 2024
Closed
This was referenced Jun 19, 2024
Merged
Merged
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ijon ijon ijon approved these changes

Assignees

No one assigned

Labels

new-feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ivanmorozov333 @ijon