Disable coordinator if no ingress tasks #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oordinator-if-no-ingress-tasks_new
alexv-smirnov
added
the
ok-to-test
github-actions
bot
removed
the
ok-to-test
…oordinator-if-no-ingress-tasks_new
kardymonds
added
the
ok-to-test
github-actions
bot
removed
the
ok-to-test
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 9c859c9.
🔴 linux-x86_64-release-asan: some tests FAILED for commit 9c859c9.
|
dorooleg
reviewed
Dec 25, 2023
| @@ -103,6 +103,12 @@ void TCheckpointCoordinator::Handle(NYql::NDqs::TEvReadyState::TPtr& ev) { | |||
| AllActorsSet.insert(actorId); | |||
| } | |||
|
|
|||
| CC_LOG_I("ActorsToTrigger count: " << ActorsToTrigger.size() << ", ActorsToNotify count: " << ActorsToNotify.size() << ", ActorsToWaitFor count: " << ActorsToWaitFor.size()); | |||
There was a problem hiding this comment.
- Do we need to use info instead of debug in this case? And the same below.
- If we have different sources in the same graph ("PgSource", "S3Source") will it work fine?
There was a problem hiding this comment.
- Changed to debug
- I think yes, S3Source just not added to ActorsToTrigger (not tested)
dorooleg
approved these changes
Dec 29, 2023
…rdinator-if-no-ingress-tasks_new
|
@kardymonds Кажется, эти изменения сломали кучу тестов. Если так, откатите, пожалуйста. |
kardymonds
added a commit
to kardymonds/ydb
that referenced
this pull request
Jan 17, 2024
This reverts commit 7c308ff.
kardymonds
added a commit
that referenced
this pull request
Jan 17, 2024
Merged
This was referenced Jan 25, 2024
Merged
Merged
This was referenced Feb 5, 2024
This was referenced Feb 6, 2024
This was referenced Feb 6, 2024
Merged
Merged
Merged
Merged
Merged
Closed
This was referenced Feb 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do nothing if there is no one to send barriers,
before this fix log was:
Checkpoint successfully created, going to inject barriers to 0 actor(s)