Skip to content

YQL-18314 use shared alloc in all task runners #4233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 28, 2024
Merged

YQL-18314 use shared alloc in all task runners #4233

merged 6 commits into from
May 28, 2024

Conversation

@zverevgeny
Copy link
Collaborator

@zverevgeny zverevgeny commented May 2, 2024

No description provided.

@zverevgeny zverevgeny requested review from a team as code owners May 2, 2024 12:59
zverevgeny
zverevgeny commented May 2, 2024
View reviewed changes
ydb/library/yql/providers/dq/task_runner/tasks_runner_pipe.cpp
: TraceId(traceId)
, Task(task)
, FilesHolder(std::move(filesHolder))
, Alloc(new NKikimr::NMiniKQL::TScopedAlloc(__LOCATION__, NKikimr::TAlignedPagePoolCounters(), true),
Copy link
Collaborator Author

@zverevgeny zverevgeny May 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the problem being fixed

@github-actions
Copy link

github-actions bot commented May 2, 2024 •
edited
Loading

⚪ 2024-05-02 13:02:48 UTC Pre-commit check for 5135299 has started.
⚪ 2024-05-02 13:02:51 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-05-02 13:12:06 UTC Build failed. see the build logs.

@github-actions
Copy link

github-actions bot commented May 2, 2024 •
edited
Loading

⚪ 2024-05-02 13:02:55 UTC Pre-commit check for 5135299 has started.
⚪ 2024-05-02 13:02:57 UTC Build linux-x86_64-release-asan is running...
🔴 2024-05-02 13:13:15 UTC Build failed. see the build logs.
🔴 2024-05-02 13:14:50 UTC Tests run skipped.

@github-actions
Copy link

github-actions bot commented May 2, 2024 •
edited
Loading

⚪ 2024-05-02 13:03:01 UTC Pre-commit check for 5135299 has started.
⚪ 2024-05-02 13:03:03 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-05-02 13:12:50 UTC Build failed. see the build logs.
🔴 2024-05-02 13:14:28 UTC Tests run skipped.

@zverevgeny zverevgeny requested a review from gridnevvvit May 2, 2024 13:05
resetius
resetius previously approved these changes May 2, 2024
View reviewed changes
@zverevgeny zverevgeny requested a review from a team as a code owner May 2, 2024 14:20
@github-actions
Copy link

github-actions bot commented May 2, 2024 •
edited
Loading

⚪ 2024-05-02 14:22:41 UTC Pre-commit check for b998bbe has started.
⚪ 2024-05-02 14:22:42 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-05-02 14:24:18 UTC Build failed. see the build logs.
🔴 2024-05-02 14:25:46 UTC Tests run skipped.

@github-actions
Copy link

github-actions bot commented May 2, 2024 •
edited
Loading

⚪ 2024-05-02 14:23:14 UTC Pre-commit check for b998bbe has started.
⚪ 2024-05-02 14:23:16 UTC Build linux-x86_64-release-asan is running...
🔴 2024-05-02 14:24:46 UTC Build failed. see the build logs.
🔴 2024-05-02 14:26:11 UTC Tests run skipped.

@github-actions
Copy link

github-actions bot commented May 2, 2024 •
edited
Loading

⚪ 2024-05-02 14:23:36 UTC Pre-commit check for b998bbe has started.
⚪ 2024-05-02 14:23:38 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-05-02 14:25:28 UTC Build failed. see the build logs.

@github-actions
Copy link

github-actions bot commented May 2, 2024 •
edited
Loading

⚪ 2024-05-02 14:40:10 UTC Pre-commit check for 95052a5 has started.
⚪ 2024-05-02 14:40:12 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-02 14:41:44 UTC Build successful.

@github-actions
Copy link

github-actions bot commented May 2, 2024 •
edited
Loading

⚪ 2024-05-02 14:40:14 UTC Pre-commit check for 95052a5 has started.
⚪ 2024-05-02 14:40:16 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-02 14:41:42 UTC Build successful.
⚪ 2024-05-02 14:43:28 UTC Tests are running...
🔴 2024-05-02 15:02:04 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
4064 3799 0 241 19 5

@github-actions
Copy link

github-actions bot commented May 2, 2024 •
edited
Loading

⚪ 2024-05-02 14:40:15 UTC Pre-commit check for 95052a5 has started.
⚪ 2024-05-02 14:40:17 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-02 14:41:50 UTC Build successful.
⚪ 2024-05-02 14:43:38 UTC Tests are running...
🔴 2024-05-02 15:35:51 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
58838 47323 0 257 11253 5

gridnevvvit
gridnevvvit previously approved these changes May 2, 2024
View reviewed changes
rvu1024
rvu1024 reviewed May 2, 2024
View reviewed changes
ydb/core/kqp/runtime/kqp_tasks_runner.h Outdated
TMap<ui64, const NYql::NDq::TDqTaskRunnerStats*> Stats;
NYql::NDq::TLogFunc LogFunc;
NMiniKQL::TScopedAlloc& Alloc;
std::shared_ptr<NKikimr::NMiniKQL::TScopedAlloc> Alloc;
Copy link
Member

@rvu1024 rvu1024 May 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent кажется поплыл

lll-phill-lll
lll-phill-lll previously approved these changes May 2, 2024
View reviewed changes
@zverevgeny zverevgeny dismissed stale reviews from lll-phill-lll and gridnevvvit via b6be2cb May 3, 2024 03:15
@zverevgeny zverevgeny force-pushed the YQL-18314_shared_alloc_in_task_runner branch from 0114bce to b6be2cb Compare May 3, 2024 03:15
@github-actions
Copy link

github-actions bot commented May 3, 2024 •
edited
Loading

⚪ 2024-05-03 03:18:14 UTC Pre-commit check for cbc23c8 has started.
⚪ 2024-05-03 03:18:18 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-03 03:26:37 UTC Build successful.

@github-actions
Copy link

github-actions bot commented May 3, 2024 •
edited
Loading

⚪ 2024-05-03 03:18:36 UTC Pre-commit check for cbc23c8 has started.
⚪ 2024-05-03 03:18:39 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-03 03:27:00 UTC Build successful.
⚪ 2024-05-03 03:28:48 UTC Tests are running...
🔴 2024-05-03 03:47:45 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
4063 3803 0 236 19 5

@github-actions
Copy link

github-actions bot commented May 3, 2024 •
edited
Loading

⚪ 2024-05-03 03:21:31 UTC Pre-commit check for cbc23c8 has started.
⚪ 2024-05-03 03:21:33 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-03 03:30:12 UTC Build successful.
⚪ 2024-05-03 03:32:03 UTC Tests are running...
🔴 2024-05-03 04:24:17 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
58839 47324 0 257 11253 5

@github-actions
Copy link

github-actions bot commented May 3, 2024 •
edited
Loading

⚪ 2024-05-03 06:33:51 UTC Pre-commit check for 39b4b07 has started.
⚪ 2024-05-03 06:33:54 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-03 06:45:40 UTC Build successful.

@github-actions
Copy link

github-actions bot commented May 3, 2024 •
edited
Loading

⚪ 2024-05-03 06:34:18 UTC Pre-commit check for 39b4b07 has started.
⚪ 2024-05-03 06:34:21 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-03 06:43:50 UTC Build successful.
⚪ 2024-05-03 06:45:37 UTC Tests are running...
🔴 2024-05-03 09:03:53 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12005 9037 0 2463 356 149

@github-actions
Copy link

github-actions bot commented May 3, 2024 •
edited
Loading

⚪ 2024-05-03 06:34:52 UTC Pre-commit check for 39b4b07 has started.
⚪ 2024-05-03 06:34:55 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-03 06:45:00 UTC Build successful.
⚪ 2024-05-03 06:46:54 UTC Tests are running...
🔴 2024-05-03 09:12:18 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
70638 52844 0 3691 13952 151

@zverevgeny zverevgeny force-pushed the YQL-18314_shared_alloc_in_task_runner branch from e21e733 to 4d34664 Compare May 27, 2024 16:27
@github-actions
Copy link

github-actions bot commented May 27, 2024 •
edited
Loading

⚪ 2024-05-27 16:30:42 UTC Pre-commit check for f401cdf has started.
⚪ 2024-05-27 16:33:16 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-27 16:42:12 UTC Build successful.
⚪ 2024-05-27 16:42:26 UTC Tests are running...
🔴 2024-05-27 18:36:53 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
71501 58783 0 11 12702 5

@github-actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

⚪ 2024-05-28 03:32:52 UTC Pre-commit check for b02b1c7 has started.
⚪ 2024-05-28 03:35:35 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-28 03:38:58 UTC Build successful.
⚪ 2024-05-28 03:39:12 UTC Tests are running...
🔴 2024-05-28 05:34:33 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
71519 58805 0 5 12704 5

@zverevgeny zverevgeny merged commit 4e3063e into ydb-platform:main May 28, 2024
@niksaveliev niksaveliev mentioned this pull request May 29, 2024
Merged
This was referenced May 29, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request May 30, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request May 31, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request May 31, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Jun 3, 2024
Merged
This was referenced Jun 6, 2024
Closed
Closed
Merged
Merged
@serbel324 serbel324 mentioned this pull request Jun 7, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Jun 10, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 10, 2024
Merged
This was referenced Jun 11, 2024
Merged
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Jun 13, 2024
Merged
This was referenced Jun 14, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 17, 2024
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request Jun 19, 2024
Merged
This was referenced Jun 19, 2024
Merged
Merged
This was referenced Jun 23, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uzhastik uzhastik uzhastik approved these changes

@rvu1024 rvu1024 rvu1024 approved these changes

@gridnevvvit gridnevvvit gridnevvvit left review comments

@lll-phill-lll lll-phill-lll lll-phill-lll left review comments

+1 more reviewer

@resetius resetius resetius left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zverevgeny @resetius @gridnevvvit @lll-phill-lll @uzhastik @rvu1024