Skip to content

[backup] Add draft backup controller tablet #4103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 2, 2024
Merged

[backup] Add draft backup controller tablet #4103

merged 8 commits into from
May 2, 2024

Conversation

@Enjection
Copy link
Member

@Enjection Enjection commented Apr 25, 2024

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@Enjection Enjection changed the title [configs] Add draft config controller tablet [backuo] Add draft backup controller tablet Apr 25, 2024
@github-actions
Copy link

github-actions bot commented Apr 25, 2024 •
edited
Loading

⚪ 2024-04-25 11:07:23 UTC Pre-commit check for feb5f11 has started.
⚪ 2024-04-25 11:07:25 UTC Build linux-x86_64-release-clang14 is running...
⚫ 2024-04-25 11:10:05 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Apr 25, 2024 •
edited
Loading

⚪ 2024-04-25 11:07:26 UTC Pre-commit check for feb5f11 has started.
⚪ 2024-04-25 11:07:29 UTC Build linux-x86_64-relwithdebinfo is running...
⚫ 2024-04-25 11:10:05 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Apr 25, 2024 •
edited
Loading

⚪ 2024-04-25 11:07:55 UTC Pre-commit check for feb5f11 has started.
⚪ 2024-04-25 11:07:58 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-04-25 11:10:06 UTC Check cancelled

@Enjection Enjection changed the title [backuo] Add draft backup controller tablet [backup] Add draft backup controller tablet Apr 25, 2024
@github-actions
Copy link

github-actions bot commented Apr 25, 2024 •
edited
Loading

⚪ 2024-04-25 11:11:18 UTC Pre-commit check for c80b17c has started.
⚪ 2024-04-25 11:11:20 UTC Build linux-x86_64-release-asan is running...
🟢 2024-04-25 11:53:35 UTC Build successful.
⚪ 2024-04-25 11:55:30 UTC Tests are running...
🔴 2024-04-25 13:45:57 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13033 12842 0 57 110 24

@github-actions
Copy link

github-actions bot commented Apr 25, 2024 •
edited
Loading

⚪ 2024-04-25 11:11:34 UTC Pre-commit check for c80b17c has started.
⚪ 2024-04-25 11:11:36 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-04-25 11:49:55 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Apr 25, 2024 •
edited
Loading

⚪ 2024-04-25 11:14:26 UTC Pre-commit check for c80b17c has started.
⚪ 2024-04-25 11:14:27 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-04-25 11:54:58 UTC Build successful.
⚪ 2024-04-25 11:56:36 UTC Tests are running...
🔴 2024-04-25 13:49:36 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
71670 58512 0 17 13115 26

CyberROFL
CyberROFL requested changes Apr 25, 2024
View reviewed changes
@github-actions
Copy link

github-actions bot commented Apr 26, 2024 •
edited
Loading

⚪ 2024-04-26 09:43:17 UTC Pre-commit check for 431b58d has started.
⚪ 2024-04-26 09:43:20 UTC Build linux-x86_64-release-clang14 is running...
⚫ 2024-04-26 09:43:35 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Apr 26, 2024 •
edited
Loading

⚪ 2024-04-26 09:43:17 UTC Pre-commit check for 431b58d has started.
⚪ 2024-04-26 09:43:20 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-04-26 09:43:35 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Apr 26, 2024 •
edited
Loading

⚪ 2024-04-26 09:44:18 UTC Pre-commit check for a361e84 has started.
⚪ 2024-04-26 09:44:20 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-04-26 10:12:15 UTC Build successful.
⚪ 2024-04-26 10:13:56 UTC Tests are running...
🔴 2024-04-26 10:37:20 UTC Test run completed, no test results found for commit 8f5e716. Please check build logs.
⚫ 2024-04-26 10:37:25 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Apr 26, 2024 •
edited
Loading

⚪ 2024-04-26 09:45:27 UTC Pre-commit check for a361e84 has started.
⚪ 2024-04-26 09:45:29 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-04-26 10:09:34 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Apr 26, 2024 •
edited
Loading

⚪ 2024-04-26 09:46:23 UTC Pre-commit check for a361e84 has started.
⚪ 2024-04-26 09:46:24 UTC Build linux-x86_64-release-asan is running...
🟢 2024-04-26 10:14:46 UTC Build successful.
⚪ 2024-04-26 10:16:32 UTC Tests are running...
🔴 2024-04-26 10:37:19 UTC Test run completed, no test results found for commit 8f5e716. Please check build logs.
⚫ 2024-04-26 10:37:22 UTC Check cancelled

CyberROFL
CyberROFL requested changes Apr 26, 2024
View reviewed changes
CyberROFL
CyberROFL requested changes Apr 26, 2024
View reviewed changes
@github-actions
Copy link

github-actions bot commented Apr 26, 2024 •
edited
Loading

⚪ 2024-04-26 10:38:17 UTC Pre-commit check for c95c8cf has started.
⚪ 2024-04-26 10:38:19 UTC Build linux-x86_64-relwithdebinfo is running...
⚫ 2024-04-26 10:57:51 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Apr 26, 2024 •
edited
Loading

⚪ 2024-04-26 10:40:56 UTC Pre-commit check for c95c8cf has started.
⚪ 2024-04-26 10:40:58 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-04-26 10:57:52 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Apr 26, 2024 •
edited
Loading

⚪ 2024-04-26 10:41:09 UTC Pre-commit check for c95c8cf has started.
⚪ 2024-04-26 10:41:11 UTC Build linux-x86_64-release-clang14 is running...
⚫ 2024-04-26 10:57:51 UTC Check cancelled

@CyberROFL CyberROFL requested a review from snaury April 26, 2024 10:55
@github-actions
Copy link

github-actions bot commented Apr 26, 2024 •
edited
Loading

⚪ 2024-04-26 10:58:24 UTC Pre-commit check for 535dff7 has started.
⚪ 2024-04-26 10:58:26 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-04-26 11:41:00 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Apr 26, 2024 •
edited
Loading

⚪ 2024-04-26 10:59:07 UTC Pre-commit check for 535dff7 has started.
⚪ 2024-04-26 10:59:08 UTC Build linux-x86_64-release-asan is running...
🟢 2024-04-26 11:39:35 UTC Build successful.
⚪ 2024-04-26 11:41:26 UTC Tests are running...
🔴 2024-04-26 13:32:13 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13040 12832 0 55 119 34

@github-actions
Copy link

github-actions bot commented Apr 26, 2024 •
edited
Loading

⚪ 2024-04-26 11:01:49 UTC Pre-commit check for 535dff7 has started.
⚪ 2024-04-26 11:01:50 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-04-26 11:42:24 UTC Build successful.
⚪ 2024-04-26 11:44:26 UTC Tests are running...
🔴 2024-04-26 13:37:44 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
71671 58520 0 7 13113 31

@CyberROFL
Copy link
Member

CyberROFL commented Apr 26, 2024 •
edited
Loading

Подсвечу, что меня смущает/не нравится:

  • Дублирование слова "таблетка" в названии таблетки.
  • Код таблетки в .h файле.

Если это смущает только меня, то в остальном от меня ОК.

snaury
snaury reviewed Apr 26, 2024
View reviewed changes
@github-actions
Copy link

github-actions bot commented May 1, 2024 •
edited
Loading

⚪ 2024-05-01 20:34:31 UTC Pre-commit check for 49e3c5f has started.
⚪ 2024-05-01 20:34:34 UTC Build linux-x86_64-release-clang14 is running...
⚫ 2024-05-01 20:48:26 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented May 1, 2024 •
edited
Loading

⚪ 2024-05-01 20:34:40 UTC Pre-commit check for 49e3c5f has started.
⚪ 2024-05-01 20:34:42 UTC Build linux-x86_64-release-asan is running...
⚫ 2024-05-01 20:48:26 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented May 1, 2024 •
edited
Loading

⚪ 2024-05-01 20:36:52 UTC Pre-commit check for 49e3c5f has started.
⚪ 2024-05-01 20:36:54 UTC Build linux-x86_64-relwithdebinfo is running...
⚫ 2024-05-01 20:48:27 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented May 1, 2024 •
edited
Loading

⚪ 2024-05-01 20:49:36 UTC Pre-commit check for 98a41b3 has started.
⚪ 2024-05-01 20:49:37 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-01 21:28:09 UTC Build successful.

@github-actions
Copy link

github-actions bot commented May 1, 2024 •
edited
Loading

⚪ 2024-05-01 20:49:36 UTC Pre-commit check for 98a41b3 has started.
⚪ 2024-05-01 20:49:37 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-01 21:27:46 UTC Build successful.
⚪ 2024-05-01 21:29:37 UTC Tests are running...
🔴 2024-05-01 23:18:45 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13224 12992 0 56 165 11

@github-actions
Copy link

github-actions bot commented May 1, 2024 •
edited
Loading

⚪ 2024-05-01 20:49:36 UTC Pre-commit check for 98a41b3 has started.
⚪ 2024-05-01 20:49:38 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-01 21:29:41 UTC Build successful.
⚪ 2024-05-01 21:31:30 UTC Tests are running...
🔴 2024-05-01 23:30:21 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
71876 58728 0 10 13128 10

@Enjection Enjection merged commit 3a7aa37 into ydb-platform:main May 2, 2024
@Enjection Enjection deleted the feature/backup/tablet-draft branch May 2, 2024 10:05
This was referenced May 3, 2024
Merged
Merged
Closed
@GrigoriyPA GrigoriyPA mentioned this pull request May 8, 2024
Merged
This was referenced May 13, 2024
Merged
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request May 16, 2024
Closed
This was referenced May 16, 2024
Merged
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request May 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snaury snaury snaury left review comments

@CyberROFL CyberROFL CyberROFL approved these changes

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Enjection @CyberROFL @snaury