Skip to content

json_nodes rewrite CreateStep condition #4792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2024
Merged

json_nodes rewrite CreateStep condition #4792

merged 1 commit into from
May 29, 2024

Conversation

@StekPerepolnen
Copy link
Collaborator

@StekPerepolnen StekPerepolnen commented May 23, 2024 •
edited
Loading

Changelog entry

change root path matching according to ss code
https://github.com/ydb-platform/ydb/blob/main/ydb/core/tx/schemeshard/schemeshard_path_describer.cpp#L994

Changelog category

  • Improvement

Additional information

...

@github-actions
Copy link

github-actions bot commented May 23, 2024 •
edited
Loading

⚪ 2024-05-23 15:50:18 UTC Pre-commit check for f9f8438 has started.
⚫ 2024-05-23 15:51:50 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented May 23, 2024 •
edited
Loading

⚪ 2024-05-23 15:51:11 UTC Pre-commit check for f9f8438 has started.
⚫ 2024-05-23 15:51:50 UTC Check cancelled

@StekPerepolnen StekPerepolnen force-pushed the json_nodes_rewrite_step_0 branch from c562171 to 31c55ac Compare May 23, 2024 15:51
@github-actions
Copy link

github-actions bot commented May 23, 2024 •
edited
Loading

⚪ 2024-05-23 15:57:42 UTC Pre-commit check for 131d0f6 has started.
⚪ 2024-05-23 16:00:25 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-23 16:04:18 UTC Build successful.
⚪ 2024-05-23 16:04:30 UTC Tests are running...
🔴 2024-05-23 16:06:15 UTC Test run completed, no test results found for commit 31c55ac. Please check build logs.
⚫ 2024-05-23 16:06:19 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented May 23, 2024 •
edited
Loading

⚪ 2024-05-23 15:57:52 UTC Pre-commit check for 131d0f6 has started.
⚪ 2024-05-23 16:00:06 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-23 16:02:49 UTC Build successful.

@github-actions
Copy link

github-actions bot commented May 23, 2024 •
edited
Loading

⚪ 2024-05-23 16:03:54 UTC Pre-commit check for 131d0f6 has started.
⚫ 2024-05-23 16:06:14 UTC Check cancelled

@StekPerepolnen StekPerepolnen force-pushed the json_nodes_rewrite_step_0 branch 3 times, most recently from 9e1c7ab to 2be5e1e Compare May 23, 2024 16:07
@github-actions
Copy link

github-actions bot commented May 23, 2024 •
edited
Loading

⚪ 2024-05-23 16:15:10 UTC Pre-commit check for a78e033 has started.
⚪ 2024-05-23 16:17:30 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-23 16:18:28 UTC Build successful.
⚪ 2024-05-23 16:18:37 UTC Tests are running...
🔴 2024-05-23 18:07:38 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9227 9161 0 20 31 15

@github-actions
Copy link

github-actions bot commented May 23, 2024 •
edited
Loading

⚪ 2024-05-23 16:19:28 UTC Pre-commit check for a78e033 has started.
⚪ 2024-05-23 16:21:50 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-23 16:23:28 UTC Build successful.

@github-actions
Copy link

github-actions bot commented May 23, 2024 •
edited
Loading

⚪ 2024-05-23 16:24:29 UTC Pre-commit check for a78e033 has started.
⚪ 2024-05-23 16:26:49 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-23 16:29:56 UTC Build successful.
⚪ 2024-05-23 16:30:08 UTC Tests are running...
🟢 2024-05-23 17:44:31 UTC Tests successful.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13200 11890 0 0 1299 11

@StekPerepolnen StekPerepolnen force-pushed the json_nodes_rewrite_step_0 branch from 2be5e1e to 41be48b Compare May 27, 2024 17:01
@github-actions
Copy link

github-actions bot commented May 27, 2024 •
edited
Loading

⚪ 2024-05-27 17:04:38 UTC Pre-commit check for ff45e17 has started.
⚪ 2024-05-27 17:07:10 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-27 17:10:12 UTC Build successful.

@github-actions
Copy link

github-actions bot commented May 27, 2024 •
edited
Loading

⚪ 2024-05-27 17:04:43 UTC Pre-commit check for ff45e17 has started.
⚪ 2024-05-27 17:07:10 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-27 17:10:22 UTC Build successful.
⚪ 2024-05-27 17:10:37 UTC Tests are running...
🔴 2024-05-27 18:24:38 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13237 11917 0 9 1299 12

@github-actions
Copy link

github-actions bot commented May 27, 2024 •
edited
Loading

⚪ 2024-05-27 17:04:53 UTC Pre-commit check for ff45e17 has started.
⚪ 2024-05-27 17:07:22 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-27 17:11:20 UTC Build successful.
⚪ 2024-05-27 17:11:33 UTC Tests are running...
🔴 2024-05-27 19:01:56 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9231 9160 0 33 27 11

@StekPerepolnen StekPerepolnen requested a review from adameat May 29, 2024 11:22
@StekPerepolnen StekPerepolnen changed the title json nodes rewrite step 0 json_nodes rewrite CreateStep condition May 29, 2024
@StekPerepolnen StekPerepolnen merged commit c57e575 into ydb-platform:main May 29, 2024
@StekPerepolnen StekPerepolnen deleted the json_nodes_rewrite_step_0 branch May 29, 2024 13:03
This was referenced May 29, 2024
Merged
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request May 30, 2024
Open
@GrigoriyPA GrigoriyPA mentioned this pull request May 31, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request May 31, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Jun 3, 2024
Merged
This was referenced Jun 6, 2024
Closed
Closed
Merged
Merged
@serbel324 serbel324 mentioned this pull request Jun 7, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Jun 10, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 10, 2024
Merged
This was referenced Jun 11, 2024
Merged
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Jun 13, 2024
Merged
This was referenced Jun 14, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 17, 2024
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request Jun 19, 2024
Merged
This was referenced Jun 19, 2024
Merged
Merged
This was referenced Jun 23, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adameat adameat adameat approved these changes

Assignees

No one assigned

Labels

improvement new-feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@StekPerepolnen @adameat