Skip to content

YQ-4856 added default stats refresh period for streaming queries #28173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −1
Open

YQ-4856 added default stats refresh period for streaming queries #28173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9db80f
Added default stats refresh for streaming queries
GrigoriyPA Nov 3, 2025
2523f25
Added config fallback
GrigoriyPA Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ydb/core/kqp/gateway/behaviour/streaming_query/queries.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1757,6 +1757,12 @@ class TStartStreamingQueryTableActor final : public TActionActorBase<TStartStrea
ev->Generation = PreviousGeneration + 1;
ev->CheckpointId = State.GetCheckpointId();

if (const auto statsPeriod = AppData()->QueryServiceConfig.GetProgressStatsPeriodMs()) {
ev->ProgressStatsPeriod = TDuration::MilliSeconds(statsPeriod);
} else {
ev->ProgressStatsPeriod = TDuration::Seconds(1);
}

auto& record = ev->Record;
record.SetTraceId(TStringBuilder() << "streaming-query-" << QueryPath << "-" << State.GetCurrentExecutionId());
if (const auto& token = Context.GetUserToken()) {
Expand Down
5 changes: 4 additions & 1 deletion ydb/core/kqp/ut/federated_query/datastreams/datastreams_ut.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ class TStreamingTestFixture : public NUnitTest::TBaseFixture {

auto& queryServiceConfig = *AppConfig->MutableQueryServiceConfig();
queryServiceConfig.SetEnableMatchRecognize(true);
queryServiceConfig.SetProgressStatsPeriodMs(1000);

LogSettings
.AddLogPriority(NKikimrServices::STREAMS_STORAGE_SERVICE, NLog::PRI_DEBUG)
Expand Down Expand Up @@ -1104,6 +1103,8 @@ Y_UNIT_TEST_SUITE(KqpFederatedQueryDatastreams) {
}

Y_UNIT_TEST_F(InsertTopicBasic, TStreamingTestFixture) {
SetupAppConfig().MutableQueryServiceConfig()->SetProgressStatsPeriodMs(1000);

TString sourceName = "sourceName";
TString inputTopicName = "inputTopicName";
TString outputTopicName = "outputTopicName";
Expand Down Expand Up @@ -2181,6 +2182,8 @@ Y_UNIT_TEST_SUITE(KqpStreamingQueriesDdl) {
}

Y_UNIT_TEST_F(StreamingQueryWithStreamLookupJoin, TStreamingTestFixture) {
SetupAppConfig().MutableQueryServiceConfig()->SetProgressStatsPeriodMs(0);

const auto connectorClient = SetupMockConnectorClient();
const auto pqGateway = SetupMockPqGateway();

Expand Down
Loading