Skip to content

Conversation

@GrigoriyPA
Copy link
Collaborator

Changelog entry

Added default stats refresh period for streaming queries

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

2025-11-03 09:46:17 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2d481aa has started.
2025-11-03 09:46:20 UTC Artifacts will be uploaded here
2025-11-03 09:47:44 UTC ya make is running...
🟡 2025-11-03 11:07:31 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31439 30029 0 4 1386 20

2025-11-03 11:07:42 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-11-03 11:13:08 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
45 (only retried tests) 33 0 0 0 12

🟢 2025-11-03 11:13:11 UTC Build successful.
🟢 2025-11-03 11:13:26 UTC ydbd size 2.3 GiB changed* by +16 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 1787dd7 merge: 2d481aa diff diff %
ydbd size 2 429 281 976 Bytes 2 429 281 992 Bytes +16 Bytes +0.000%
ydbd stripped size 516 134 920 Bytes 516 134 920 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

2025-11-03 09:46:34 UTC Pre-commit check linux-x86_64-release-asan for 2d481aa has started.
2025-11-03 09:46:37 UTC Artifacts will be uploaded here
2025-11-03 09:47:58 UTC ya make is running...
🟡 2025-11-03 11:42:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15310 14927 0 144 215 24

🟢 2025-11-03 11:42:42 UTC Build successful.
🟢 2025-11-03 11:43:03 UTC ydbd size 3.8 GiB changed* by -16 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 1787dd7 merge: 2d481aa diff diff %
ydbd size 4 068 669 832 Bytes 4 068 669 816 Bytes -16 Bytes -0.000%
ydbd stripped size 1 510 374 440 Bytes 1 510 374 440 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

🟢 2025-11-03 09:47:47 UTC The validation of the Pull Request description is successful.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses the configuration of progress stats period for streaming queries by removing a global test configuration and adding test-specific configurations, while hardcoding a default value in the production code.

  • Removed global ProgressStatsPeriodMs configuration from test fixture setup
  • Added test-specific ProgressStatsPeriodMs configurations for individual tests
  • Hardcoded ProgressStatsPeriod to 1 second in streaming query actor

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
ydb/core/kqp/ut/federated_query/datastreams/datastreams_ut.cpp Removed global test configuration and added test-specific ProgressStatsPeriodMs settings for two tests
ydb/core/kqp/gateway/behaviour/streaming_query/queries.cpp Hardcoded ProgressStatsPeriod to 1 second in TStartStreamingQueryTableActor

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

2025-11-03 15:58:37 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1459001 has started.
2025-11-03 15:58:54 UTC Artifacts will be uploaded here
2025-11-03 16:00:18 UTC ya make is running...
🟡 2025-11-03 17:18:33 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31439 30032 0 1 1385 21

2025-11-03 17:18:45 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-11-03 17:24:20 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
42 (only retried tests) 27 0 0 0 15

🟢 2025-11-03 17:24:23 UTC Build successful.
🟢 2025-11-03 17:24:39 UTC ydbd size 2.3 GiB changed* by +624 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 802fb8a merge: 1459001 diff diff %
ydbd size 2 429 287 080 Bytes 2 429 287 704 Bytes +624 Bytes +0.000%
ydbd stripped size 516 135 944 Bytes 516 136 136 Bytes +192 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

2025-11-03 15:58:46 UTC Pre-commit check linux-x86_64-release-asan for 1459001 has started.
2025-11-03 15:59:02 UTC Artifacts will be uploaded here
2025-11-03 16:00:24 UTC ya make is running...
🟡 2025-11-03 17:55:10 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15310 14920 0 164 201 25

🟢 2025-11-03 17:55:17 UTC Build successful.
🟢 2025-11-03 17:55:42 UTC ydbd size 3.8 GiB changed* by +496 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 802fb8a merge: 1459001 diff diff %
ydbd size 4 068 675 512 Bytes 4 068 676 008 Bytes +496 Bytes +0.000%
ydbd stripped size 1 510 375 912 Bytes 1 510 376 040 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant