-
Notifications
You must be signed in to change notification settings - Fork 727
YQ-4856 added default stats refresh period for streaming queries #28173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
YQ-4856 added default stats refresh period for streaming queries #28173
Conversation
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
🟢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses the configuration of progress stats period for streaming queries by removing a global test configuration and adding test-specific configurations, while hardcoding a default value in the production code.
- Removed global
ProgressStatsPeriodMsconfiguration from test fixture setup - Added test-specific
ProgressStatsPeriodMsconfigurations for individual tests - Hardcoded
ProgressStatsPeriodto 1 second in streaming query actor
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ydb/core/kqp/ut/federated_query/datastreams/datastreams_ut.cpp | Removed global test configuration and added test-specific ProgressStatsPeriodMs settings for two tests |
| ydb/core/kqp/gateway/behaviour/streaming_query/queries.cpp | Hardcoded ProgressStatsPeriod to 1 second in TStartStreamingQueryTableActor |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
Added default stats refresh period for streaming queries
Changelog category
Description for reviewers