Skip to content

YQL-19940: Support optional default value #18390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2025
Merged

YQL-19940: Support optional default value #18390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ydb/core/kqp/common/kqp_resolve.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,20 @@
#include <ydb/core/tx/datashard/range_ops.h>
#endif

#include <yql/essentials/minikql/mkql_node_builder.h>

namespace NKikimr {
namespace NKqp {

using namespace NMiniKQL;
using namespace NYql;
using namespace NYql::NNodes;

NUdf::TUnboxedValue MakeDefaultValueByType(const NKikimr::NMiniKQL::TType* type) {
NUdf::TUnboxedValue MakeDefaultValueByType(NKikimr::NMiniKQL::TType* type) {
bool isOptional;
Copy link
Collaborator Author

@Artemonchik Artemonchik May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dahbka-lis PTAL
I have fixed the ydb/core/kqp/ut/batch_operations tests with MSan enabled. You might need to add more types here.

type = UnpackOptional(type, isOptional);
Y_ABORT_UNLESS(type->IsData(), "%s", type->GetKindAsStr());

auto dataType = static_cast<const NKikimr::NMiniKQL::TDataType*>(type);
switch (dataType->GetSchemeType()) {
case NUdf::TDataType<bool>::Id:
Expand Down
2 changes: 1 addition & 1 deletion ydb/core/kqp/common/kqp_resolve.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ class TKqpTableKeys {
THashMap<TTableId, TTable> TablesById;
};

NUdf::TUnboxedValue MakeDefaultValueByType(const NKikimr::NMiniKQL::TType* type);
NUdf::TUnboxedValue MakeDefaultValueByType(NKikimr::NMiniKQL::TType* type);

TVector<TCell> MakeKeyCells(const NKikimr::NUdf::TUnboxedValue& value, const TVector<NScheme::TTypeInfo>& keyColumnTypes,
const TVector<ui32>& keyColumnIndices, const NMiniKQL::TTypeEnvironment& typeEnv, bool copyValues);
Expand Down
Loading