Skip to content

YQL-19940: Support optional default value #18390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2025
Merged

YQL-19940: Support optional default value #18390

merged 1 commit into from
May 17, 2025

Conversation

@Artemonchik
Copy link
Collaborator

@Artemonchik Artemonchik commented May 16, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@Artemonchik Artemonchik requested review from dahbka-lis and vitstn May 16, 2025 06:35
@Artemonchik Artemonchik requested a review from a team as a code owner May 16, 2025 06:35
@github-actions
Copy link

github-actions bot commented May 16, 2025

🟢 2025-05-16 06:38:45 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented May 16, 2025 •
edited
Loading

⚪ 2025-05-16 06:40:11 UTC Pre-commit check linux-x86_64-release-asan for e009b13 has started.
⚪ 2025-05-16 06:40:22 UTC Artifacts will be uploaded here
⚪ 2025-05-16 06:43:11 UTC ya make is running...
🟡 2025-05-16 08:10:33 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13417 13270 0 83 37 27

⚪ 2025-05-16 08:11:42 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-16 08:39:55 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1223 (only retried tests) 1121 0 55 21 26

⚪ 2025-05-16 08:40:11 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-16 09:06:15 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1099 (only retried tests) 1008 0 56 12 23

🟢 2025-05-16 09:06:28 UTC Build successful.
🟢 2025-05-16 09:07:00 UTC ydbd size 3.9 GiB changed* by +520 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: f895e52 merge: e009b13 diff diff %
ydbd size 4 140 278 592 Bytes 4 140 279 112 Bytes +520 Bytes +0.000%
ydbd stripped size 1 437 303 288 Bytes 1 437 303 544 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented May 16, 2025 •
edited
Loading

⚪ 2025-05-17 11:21:17 UTC Pre-commit check linux-x86_64-relwithdebinfo for e009b13 has started.
⚪ 2025-05-17 11:21:29 UTC Artifacts will be uploaded here
⚪ 2025-05-17 11:24:23 UTC ya make is running...
🟡 2025-05-17 12:40:19 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28320 25634 0 1 2643 42

⚪ 2025-05-17 12:42:42 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-05-17 13:06:12 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
554 (only retried tests) 520 0 0 1 33

🟢 2025-05-17 13:06:21 UTC Build successful.
🟢 2025-05-17 13:06:39 UTC ydbd size 2.2 GiB changed* by +160 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: f895e52 merge: e009b13 diff diff %
ydbd size 2 353 165 248 Bytes 2 353 165 408 Bytes +160 Bytes +0.000%
ydbd stripped size 494 609 544 Bytes 494 609 608 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Artemonchik
Artemonchik commented May 16, 2025
View reviewed changes
ydb/core/kqp/common/kqp_resolve.cpp

NUdf::TUnboxedValue MakeDefaultValueByType(const NKikimr::NMiniKQL::TType* type) {
NUdf::TUnboxedValue MakeDefaultValueByType(NKikimr::NMiniKQL::TType* type) {
bool isOptional;
Copy link
Collaborator Author

@Artemonchik Artemonchik May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dahbka-lis PTAL
I have fixed the ydb/core/kqp/ut/batch_operations tests with MSan enabled. You might need to add more types here.

@Artemonchik Artemonchik enabled auto-merge (squash) May 16, 2025 06:50
@vitstn
Copy link
Collaborator

vitstn commented May 16, 2025

LGTM

@Artemonchik Artemonchik merged commit 78c0da6 into ydb-platform:main May 17, 2025
26 of 30 checks passed
dahbka-lis pushed a commit to dahbka-lis/ydb that referenced this pull request May 18, 2025
@Artemonchik @dahbka-lis
YQL-19940: Support optional default value (ydb-platform#18390)
1cf8473
nshestakov pushed a commit to nshestakov/ydb that referenced this pull request May 20, 2025
@Artemonchik @nshestakov
YQL-19940: Support optional default value (ydb-platform#18390)
a489e89
xyliganSereja pushed a commit to xyliganSereja/ydb_work that referenced this pull request Jun 3, 2025
@Artemonchik
YQL-19940: Support optional default value (ydb-platform#18390)
9732c71
@StekPerepolnen StekPerepolnen mentioned this pull request Sep 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dahbka-lis dahbka-lis dahbka-lis approved these changes

@vitstn vitstn Awaiting requested review from vitstn

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Artemonchik @vitstn @dahbka-lis