Skip to content

refactoring in unit tests of SHOW CREATE TABLE #16929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 8, 2025
Merged

refactoring in unit tests of SHOW CREATE TABLE #16929

merged 2 commits into from
Apr 8, 2025

Conversation

@jepett0
Copy link
Contributor

@jepett0 jepett0 commented Apr 8, 2025

Changelog entry

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Preliminary refactoring before adding unit tests for SHOW CREATE VIEW.

Issues:

@github-actions
Copy link

github-actions bot commented Apr 8, 2025

🟢 2025-04-08 12:12:10 UTC The validation of the Pull Request description is successful.

@jepett0 jepett0 mentioned this pull request Apr 8, 2025
Merged
@jepett0 jepett0 linked an issue Apr 8, 2025 that may be closed by this pull request
show create view follow up: split view query using parser #16778
Closed
@jepett0 jepett0 requested a review from shnikd April 8, 2025 12:18
jepett0
jepett0 commented Apr 8, 2025
View reviewed changes
ydb/core/sys_view/ut_common.h
bool EnableSVP = false;
bool EnableForceFollowers = false;
bool ShowCreateTable = false;
NKikimrProto::TAuthConfig AuthConfig;
Copy link
Contributor Author

@jepett0 jepett0 Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my VS code was issuing compilation warnings because of this

@github-actions
Copy link

github-actions bot commented Apr 8, 2025 •
edited
Loading

⚪ 2025-04-08 12:23:45 UTC Pre-commit check linux-x86_64-release-asan for 040a2f3 has started.
⚪ 2025-04-08 12:24:00 UTC Artifacts will be uploaded here
⚪ 2025-04-08 12:26:16 UTC ya make is running...
🟢 2025-04-08 12:37:53 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
82 82 0 0 0 0

🟢 2025-04-08 12:38:02 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Apr 8, 2025 •
edited
Loading

⚪ 2025-04-08 12:26:38 UTC Pre-commit check linux-x86_64-relwithdebinfo for 040a2f3 has started.
⚪ 2025-04-08 12:26:53 UTC Artifacts will be uploaded here
⚪ 2025-04-08 12:29:08 UTC ya make is running...
🟢 2025-04-08 12:39:53 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
82 82 0 0 0 0

🟢 2025-04-08 12:40:00 UTC Build successful.

@jepett0 jepett0 merged commit 70ed290 into ydb-platform:main Apr 8, 2025
16 of 17 checks passed
@jepett0 jepett0 mentioned this pull request Jun 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@shnikd shnikd shnikd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

show create view follow up: split view query using parser

2 participants

@jepett0 @shnikd