Skip to content

SHOW CREATE VIEW: use YQL parser to split view query to context recreation and select parts #16931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 14, 2025
Merged

SHOW CREATE VIEW: use YQL parser to split view query to context recreation and select parts #16931

merged 7 commits into from
Apr 14, 2025

Conversation

jepett0
Copy link
Collaborator

@jepett0 jepett0 commented Apr 8, 2025 •
edited
Loading

Changelog entry

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Issues:

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2025 •
edited
Loading

🟢 2025-04-08 17:49:37 UTC The validation of the Pull Request description is successful.

@jepett0 jepett0 linked an issue Apr 8, 2025 that may be closed by this pull request
show create view follow up: split view query using parser #16778
Closed
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@jepett0 jepett0 force-pushed the VIEW.split_view_query.2 branch from f993642 to b8bd398 Compare April 8, 2025 15:28
@jepett0 jepett0 marked this pull request as ready for review April 8, 2025 15:29
@jepett0 jepett0 requested a review from a team as a code owner April 8, 2025 15:29
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
shnikd
shnikd reviewed Apr 9, 2025
View reviewed changes
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@jepett0 jepett0 requested a review from shnikd April 9, 2025 12:28
jepett0 added 2 commits April 9, 2025 12:43
@jepett0
review fix
fe41a60 
- check the size of the string when trimming quotes
@jepett0
format the resultant create view rather then the view query
228385b
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@jepett0 jepett0 requested a review from a team as a code owner April 9, 2025 14:41
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2025 •
edited
Loading

⚪ 2025-04-09 14:43:32 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2eb9fd9 has started.
⚪ 2025-04-09 14:43:48 UTC Artifacts will be uploaded here
⚪ 2025-04-09 14:46:39 UTC ya make is running...
🟢 2025-04-09 16:01:24 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19880 18522 0 0 1244 114

🟢 2025-04-09 16:03:00 UTC Build successful.
🟢 2025-04-09 16:03:17 UTC ydbd size 2.2 GiB changed* by +96.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a55bf5d merge: 2eb9fd9 diff diff %
ydbd size 2 357 524 888 Bytes 2 357 623 216 Bytes +96.0 KiB +0.004%
ydbd stripped size 492 800 608 Bytes 492 811 520 Bytes +10.7 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2025 •
edited
Loading

⚪ 2025-04-09 14:43:45 UTC Pre-commit check linux-x86_64-release-asan for 2eb9fd9 has started.
⚪ 2025-04-09 14:44:00 UTC Artifacts will be uploaded here
⚪ 2025-04-09 14:46:46 UTC ya make is running...
🟡 2025-04-09 16:01:37 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12290 12122 0 90 38 40

⚪ 2025-04-09 16:02:44 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-09 16:16:31 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
225 (only retried tests) 145 0 38 9 33

⚪ 2025-04-09 16:16:41 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-09 16:30:11 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
112 (only retried tests) 43 0 35 2 32

🟢 2025-04-09 16:30:18 UTC Build successful.
🟡 2025-04-09 16:30:49 UTC ydbd size 3.9 GiB changed* by +146.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: a55bf5d merge: 2eb9fd9 diff diff %
ydbd size 4 136 371 848 Bytes 4 136 521 488 Bytes +146.1 KiB +0.004%
ydbd stripped size 1 428 697 288 Bytes 1 428 718 216 Bytes +20.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@jepett0 jepett0 requested a review from CyberROFL April 14, 2025 08:25
CyberROFL
CyberROFL approved these changes Apr 14, 2025
View reviewed changes
ydb/core/sys_view/show_create/create_view_formatter.h
@@ -8,9 +8,19 @@

namespace NKikimr::NSysView {

struct TViewQuerySplit {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Может по аналогии с TFormatResult назвать TSplitResult?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

может, позже, когда буду затаскивать SHOW CREATE VIEW в YDB CLI для describe view. Пока мне это имя кажется достаточно хорошим

@jepett0 jepett0 merged commit 0d081d5 into ydb-platform:main Apr 14, 2025
14 checks passed
@jepett0 jepett0 mentioned this pull request Jun 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyberROFL CyberROFL CyberROFL approved these changes

@shnikd shnikd shnikd approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

show create view follow up: split view query using parser
3 participants
@jepett0 @CyberROFL @shnikd