Skip to content

Conversation

@Alek5andr-Kotov
Copy link
Collaborator

@Alek5andr-Kotov Alek5andr-Kotov commented Mar 25, 2025

Changelog entry

The PQ tablet can receive the message TEvPersQueue::TEvProposeTransaction twice from the SS. For example, when there are delays in the operation of the IC. As a result, the Drop Tablet operation may hang in the PQ tablet.

#16218

Changelog category

  • Bugfix

Description for reviewers

The PQ tablet allows the DropTablet operation only if it has an empty list of transactions, or there is a configuration transaction without a PlanStep.

@Alek5andr-Kotov Alek5andr-Kotov requested a review from a team as a code owner March 25, 2025 14:40
@Alek5andr-Kotov Alek5andr-Kotov changed the title WIP: Late messages TEvProposeTransaction Late messages TEvProposeTransaction Mar 25, 2025
@github-actions github-actions bot added bugfix and removed bugfix labels Mar 25, 2025
@github-actions
Copy link

github-actions bot commented Mar 25, 2025

🟢 2025-03-25 14:54:41 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Mar 25, 2025

2025-03-25 14:42:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7de4213 has started.
2025-03-25 14:42:18 UTC Artifacts will be uploaded here
2025-03-25 14:45:08 UTC ya make is running...
2025-03-25 14:50:29 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Mar 25, 2025

2025-03-25 14:42:04 UTC Pre-commit check linux-x86_64-release-asan for 7de4213 has started.
2025-03-25 14:42:19 UTC Artifacts will be uploaded here
2025-03-25 14:45:09 UTC ya make is running...
2025-03-25 14:50:25 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Mar 25, 2025

2025-03-25 14:52:52 UTC Pre-commit check linux-x86_64-relwithdebinfo for f0daf62 has started.
2025-03-25 14:52:57 UTC Artifacts will be uploaded here
2025-03-25 14:55:45 UTC ya make is running...
🟡 2025-03-25 15:55:13 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19697 18336 0 5 1243 113

2025-03-25 15:56:57 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-25 16:09:26 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
162 (only retried tests) 57 0 0 0 105

🟢 2025-03-25 16:09:33 UTC Build successful.
🟢 2025-03-25 16:09:53 UTC ydbd size 2.2 GiB changed* by +9.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 9808a23 merge: f0daf62 diff diff %
ydbd size 2 321 300 104 Bytes 2 321 310 128 Bytes +9.8 KiB +0.000%
ydbd stripped size 485 307 456 Bytes 485 312 032 Bytes +4.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Alek5andr-Kotov Alek5andr-Kotov enabled auto-merge (squash) March 25, 2025 14:53
@github-actions github-actions bot added bugfix and removed bugfix labels Mar 25, 2025
@github-actions
Copy link

github-actions bot commented Mar 25, 2025

2025-03-25 14:54:53 UTC Pre-commit check linux-x86_64-release-asan for f0daf62 has started.
2025-03-25 14:55:07 UTC Artifacts will be uploaded here
2025-03-25 14:57:54 UTC ya make is running...
🟡 2025-03-25 16:09:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12165 12055 0 61 14 35

2025-03-25 16:10:25 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-25 16:25:03 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
159 (only retried tests) 120 0 4 3 32

2025-03-25 16:25:15 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-25 16:45:32 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
65 (only retried tests) 29 0 4 4 28

🟢 2025-03-25 16:45:40 UTC Build successful.
🟢 2025-03-25 16:46:09 UTC ydbd size 3.8 GiB changed* by +1.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4bc773e merge: f0daf62 diff diff %
ydbd size 4 083 600 216 Bytes 4 083 601 360 Bytes +1.1 KiB +0.000%
ydbd stripped size 1 410 988 872 Bytes 1 410 989 576 Bytes +704 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Alek5andr-Kotov Alek5andr-Kotov merged commit f506a72 into ydb-platform:main Mar 26, 2025
14 checks passed
Alek5andr-Kotov added a commit to Alek5andr-Kotov/ydb that referenced this pull request Mar 26, 2025
Alek5andr-Kotov added a commit to Alek5andr-Kotov/ydb that referenced this pull request Mar 26, 2025
Alek5andr-Kotov added a commit to Alek5andr-Kotov/ydb that referenced this pull request Mar 26, 2025
Alek5andr-Kotov added a commit to Alek5andr-Kotov/ydb that referenced this pull request Mar 26, 2025
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 28, 2025
@liruoko liruoko added the changelog/f25-3 PR участвует в списке изменений label Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix changelog/f25-3 PR участвует в списке изменений

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants