Skip to content

Commit 4bc773e

Browse files
authored
Add feature flags to switch between configs v1 and v2 (#16206)
1 parent 38c356b commit 4bc773e

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

ydb/core/grpc_services/rpc_config.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -226,15 +226,17 @@ class TReplaceStorageConfigRequest : public TBSConfigRequestGrpc<TReplaceStorage
226226

227227
auto shim = ConvertConfigReplaceRequest(*request);
228228

229+
const auto& ff = AppData()->FeatureFlags;
230+
229231
return std::make_unique<TEvBlobStorage::TEvControllerReplaceConfigRequest>(
230232
shim.MainConfig,
231233
shim.StorageConfig,
232234
shim.SwitchDedicatedStorageSection,
233235
shim.DedicatedConfigMode,
234236
request->allow_unknown_fields() || request->bypass_checks(),
235237
request->bypass_checks(),
236-
false /* TODO: implement */,
237-
false /* TODO: implement */);
238+
/*enableConfigV2=*/ ff.GetSwitchToConfigV2(),
239+
/*disableConfigV2=*/ ff.GetSwitchToConfigV1());
238240
}
239241

240242
private:

ydb/core/protos/feature_flags.proto

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -202,4 +202,6 @@ message TFeatureFlags {
202202
optional bool EnableTabletRestartOnUnhandledExceptions = 176 [default = true];
203203
optional bool EnableKafkaTransactions = 177 [default = false];
204204
optional bool EnableLoginCache = 178 [default = false];
205+
optional bool SwitchToConfigV2 = 179 [default = false];
206+
optional bool SwitchToConfigV1 = 180 [default = false];
205207
}

0 commit comments

Comments
 (0)