Skip to content

Revert "24-4: Add CleanupEC2MetadataClient()" #15832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

CyberROFL
Copy link
Member

Reverts #15382

@CyberROFL CyberROFL requested a review from a team as a code owner March 17, 2025 13:10
Copy link

github-actions bot commented Mar 17, 2025

2025-03-17 13:12:01 UTC Pre-commit check for c9a8d3a has started.
2025-03-17 13:15:26 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-03-17 14:21:31 UTC Build successful.
2025-03-17 14:21:46 UTC Tests are running...
🔴 2025-03-17 16:22:43 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40374 35082 0 26 5220 46

🟢 2025-03-17 16:23:36 UTC ydbd size 8.3 GiB changed* by -85.6 KiB, which is <= 0 Bytes vs stable-24-4: OK

ydbd size dash stable-24-4: 85b3d16 merge: c9a8d3a diff diff %
ydbd size 8 898 609 496 Bytes 8 898 521 800 Bytes -85.6 KiB -0.001%
ydbd stripped size 485 027 272 Bytes 485 021 320 Bytes -5.8 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 17, 2025

2025-03-17 13:14:40 UTC Pre-commit check for c9a8d3a has started.
2025-03-17 13:17:45 UTC Build linux-x86_64-release-asan is running...
🟢 2025-03-17 14:10:27 UTC Build successful.
2025-03-17 14:10:46 UTC Tests are running...
🔴 2025-03-17 16:26:28 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11690 11580 0 40 28 42

🟢 2025-03-17 16:27:26 UTC ydbd size 5.6 GiB changed* by -37.5 KiB, which is <= 0 Bytes vs stable-24-4: OK

ydbd size dash stable-24-4: 85b3d16 merge: c9a8d3a diff diff %
ydbd size 6 027 674 280 Bytes 6 027 635 920 Bytes -37.5 KiB -0.001%
ydbd stripped size 1 508 473 088 Bytes 1 508 460 960 Bytes -11.8 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@CyberROFL CyberROFL merged commit f4134c8 into stable-24-4 Mar 18, 2025
7 of 11 checks passed
@CyberROFL CyberROFL deleted the revert-15382-cleanup-ec2-metadata-client-24-4 branch March 18, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants