Skip to content

24-4: Add CleanupEC2MetadataClient() #15382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented Mar 5, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@CyberROFL CyberROFL self-assigned this Mar 5, 2025
Copy link

github-actions bot commented Mar 5, 2025

2025-03-05 19:19:26 UTC Pre-commit check for 4dbbb1c has started.
2025-03-05 19:22:23 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-03-05 20:30:53 UTC Build successful.
2025-03-05 20:31:10 UTC Tests are running...
🔴 2025-03-05 22:14:21 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40350 35070 0 26 5217 37

🟢 2025-03-05 22:15:16 UTC ydbd size 8.3 GiB changed* by +81.7 KiB, which is < 100.0 KiB vs stable-24-4: OK

ydbd size dash stable-24-4: 9b336b7 merge: 4dbbb1c diff diff %
ydbd size 8 897 570 712 Bytes 8 897 654 336 Bytes +81.7 KiB +0.001%
ydbd stripped size 484 988 712 Bytes 484 990 632 Bytes +1.9 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 5, 2025

2025-03-05 19:19:27 UTC Pre-commit check for 4dbbb1c has started.
2025-03-05 19:22:27 UTC Build linux-x86_64-release-asan is running...
🟢 2025-03-05 20:09:29 UTC Build successful.
2025-03-05 20:09:46 UTC Tests are running...
🔴 2025-03-05 22:20:38 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11681 11582 0 35 23 41

🟢 2025-03-05 22:21:39 UTC ydbd size 5.6 GiB changed* by +41.2 KiB, which is < 100.0 KiB vs stable-24-4: OK

ydbd size dash stable-24-4: 9b336b7 merge: 4dbbb1c diff diff %
ydbd size 6 026 994 616 Bytes 6 027 036 848 Bytes +41.2 KiB +0.001%
ydbd stripped size 1 508 305 824 Bytes 1 508 321 888 Bytes +15.7 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@CyberROFL CyberROFL marked this pull request as ready for review March 5, 2025 19:24
@CyberROFL CyberROFL requested a review from a team as a code owner March 5, 2025 19:24
@CyberROFL CyberROFL enabled auto-merge (squash) March 6, 2025 09:44
@CyberROFL CyberROFL merged commit f7a423c into ydb-platform:stable-24-4 Mar 6, 2025
6 of 10 checks passed
@CyberROFL CyberROFL deleted the cleanup-ec2-metadata-client-24-4 branch March 6, 2025 15:08
CyberROFL added a commit that referenced this pull request Mar 17, 2025
zinal pushed a commit to zinal/ydb that referenced this pull request May 16, 2025
zinal pushed a commit to zinal/ydb that referenced this pull request Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants