Skip to content

24-1 Fix B-Tree histograms comparator result overflow #15820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

kunga
Copy link
Member

@kunga kunga commented Mar 17, 2025

Changelog entry

Fixes invalid data shards histograms when enable_local_dbbtree_index is enabled (#15235)

Changelog category

  • Bugfix

Description for reviewers

Due to wrong cast int compare result to i8, we got a wrong events order

Also adds additional key logs, fixes typo with GetDataSize, adds error log in a case with bad histogram

#15720

@kunga kunga changed the base branch from main to stable-24-4 March 17, 2025 11:04
@kunga kunga changed the title 24-4-fixing-btree-histogram 25-1 Fix B-Tree histograms comparator result overflow Mar 17, 2025
Copy link

🟢 2025-03-17 11:04:46 UTC The validation of the Pull Request description is successful.

@kunga kunga added the rebase-and-check Rebase PR with the current base branch and check label Mar 17, 2025
@kunga kunga changed the title 25-1 Fix B-Tree histograms comparator result overflow 24-1 Fix B-Tree histograms comparator result overflow Mar 17, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Mar 17, 2025
Copy link

github-actions bot commented Mar 17, 2025

2025-03-17 11:11:32 UTC Pre-commit check for d85c3b4 has started.
2025-03-17 11:14:51 UTC Build linux-x86_64-release-asan is running...
🟢 2025-03-17 12:01:12 UTC Build successful.
2025-03-17 12:01:31 UTC Tests are running...
🔴 2025-03-17 14:23:55 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11695 11576 0 48 30 41

🟢 2025-03-17 14:24:41 UTC ydbd size 5.6 GiB changed* by +39.7 KiB, which is < 100.0 KiB vs stable-24-4: OK

ydbd size dash stable-24-4: 85b3d16 merge: d85c3b4 diff diff %
ydbd size 6 027 674 280 Bytes 6 027 714 936 Bytes +39.7 KiB +0.001%
ydbd stripped size 1 508 473 088 Bytes 1 508 481 664 Bytes +8.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kunga kunga self-assigned this Mar 17, 2025
Copy link

github-actions bot commented Mar 17, 2025

2025-03-17 11:16:06 UTC Pre-commit check for d85c3b4 has started.
2025-03-17 11:19:05 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-03-17 12:19:56 UTC Build successful.
2025-03-17 12:20:11 UTC Tests are running...
🔴 2025-03-17 14:16:11 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40373 35086 0 24 5219 44

🟢 2025-03-17 14:17:10 UTC ydbd size 8.3 GiB changed* by +47.0 KiB, which is < 100.0 KiB vs stable-24-4: OK

ydbd size dash stable-24-4: 85b3d16 merge: d85c3b4 diff diff %
ydbd size 8 898 609 496 Bytes 8 898 657 600 Bytes +47.0 KiB +0.001%
ydbd stripped size 485 027 272 Bytes 485 030 024 Bytes +2.7 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kunga kunga marked this pull request as ready for review March 17, 2025 14:47
@kunga kunga requested a review from a team as a code owner March 17, 2025 14:47
@kunga kunga merged commit a9a7cc8 into ydb-platform:stable-24-4 Mar 17, 2025
9 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants