Skip to content

Fix B-Tree histograms comparator result overflow #15720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 17, 2025
Merged

Fix B-Tree histograms comparator result overflow #15720

merged 12 commits into from
Mar 17, 2025

Conversation

@kungasc
Copy link
Contributor

@kungasc kungasc commented Mar 13, 2025 •
edited
Loading

Changelog entry

Fixes invalid data shards histograms when enable_local_dbbtree_index is enabled (#15235)

Changelog category

  • Bugfix

Description for reviewers

Due to wrong cast int compare result to i8, we got a wrong events order

Also adds additional key logs, fixes typo with GetDataSize, adds error log in a case with bad histogram

@github-actions
Copy link

github-actions bot commented Mar 13, 2025 •
edited
Loading

🟢 2025-03-17 10:34:46 UTC The validation of the Pull Request description is successful.

@kungasc kungasc force-pushed the fixing-btree-histogram branch from e04d0d6 to 075fbde Compare March 14, 2025 09:15
@github-actions
Copy link

github-actions bot commented Mar 14, 2025 •
edited
Loading

⚪ 2025-03-14 09:17:18 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9a1e87e has started.
⚪ 2025-03-14 09:17:33 UTC Artifacts will be uploaded here
⚪ 2025-03-14 09:20:42 UTC ya make is running...
🟡 2025-03-14 10:49:17 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28134 24897 0 199 2921 117

⚪ 2025-03-14 10:52:39 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-14 11:04:22 UTC ydbd size 2.1 GiB changed* by +5.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3917ee3 merge: 9a1e87e diff diff %
ydbd size 2 297 903 016 Bytes 2 297 909 040 Bytes +5.9 KiB +0.000%
ydbd stripped size 481 043 328 Bytes 481 044 736 Bytes +1.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2025-03-14 11:04:24 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Mar 14, 2025 •
edited
Loading

⚪ 2025-03-14 09:17:22 UTC Pre-commit check linux-x86_64-release-asan for 9a1e87e has started.
⚪ 2025-03-14 09:17:36 UTC Artifacts will be uploaded here
⚪ 2025-03-14 09:20:42 UTC ya make is running...
🟡 2025-03-14 11:01:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13741 13529 0 165 8 39

⚪ 2025-03-14 11:02:19 UTC ya make is running... (failed tests rerun, try 2)

@kungasc kungasc self-assigned this Mar 14, 2025
@github-actions
Copy link

github-actions bot commented Mar 14, 2025 •
edited
Loading

⚪ 2025-03-14 11:25:02 UTC Pre-commit check linux-x86_64-release-asan for c5e48ee has started.
⚪ 2025-03-14 11:25:07 UTC Artifacts will be uploaded here
⚪ 2025-03-14 11:28:09 UTC ya make is running...
🟡 2025-03-14 12:54:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13744 13538 0 150 19 37

⚪ 2025-03-14 12:55:30 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-14 13:18:05 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
317 (only retried tests) 203 0 68 11 35

⚪ 2025-03-14 13:18:25 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-14 13:38:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
198 (only retried tests) 89 0 63 10 36

🟢 2025-03-14 13:38:29 UTC Build successful.
🟢 2025-03-14 13:39:05 UTC ydbd size 3.8 GiB changed* by +18.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f5cf28c merge: c5e48ee diff diff %
ydbd size 4 046 114 368 Bytes 4 046 133 736 Bytes +18.9 KiB +0.000%
ydbd stripped size 1 399 934 504 Bytes 1 399 942 824 Bytes +8.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 14, 2025 •
edited
Loading

⚪ 2025-03-14 11:26:36 UTC Pre-commit check linux-x86_64-relwithdebinfo for c5e48ee has started.
⚪ 2025-03-14 11:26:51 UTC Artifacts will be uploaded here
⚪ 2025-03-14 11:30:00 UTC ya make is running...
🟡 2025-03-14 12:56:27 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28137 24957 0 165 2897 118

⚪ 2025-03-14 12:58:51 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-14 13:21:32 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
816 (only retried tests) 390 0 103 215 108

⚪ 2025-03-14 13:21:47 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-03-14 13:38:58 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
511 (only retried tests) 272 0 63 70 106

🟢 2025-03-14 13:39:10 UTC Build successful.
🟢 2025-03-14 13:39:43 UTC ydbd size 2.1 GiB changed* by +11.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f5cf28c merge: c5e48ee diff diff %
ydbd size 2 297 930 648 Bytes 2 297 942 640 Bytes +11.7 KiB +0.001%
ydbd stripped size 481 049 440 Bytes 481 051 616 Bytes +2.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions github-actions bot added bugfix and removed bugfix labels Mar 14, 2025
@github-actions github-actions bot added bugfix and removed bugfix labels Mar 14, 2025
@github-actions
Copy link

github-actions bot commented Mar 14, 2025 •
edited
Loading

⚪ 2025-03-14 14:39:14 UTC Pre-commit check linux-x86_64-release-asan for 14e4242 has started.
⚪ 2025-03-14 14:39:19 UTC Artifacts will be uploaded here
⚪ 2025-03-14 14:42:24 UTC ya make is running...
⚫ 2025-03-14 15:14:44 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Mar 14, 2025 •
edited
Loading

⚪ 2025-03-14 14:39:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for 14e4242 has started.
⚪ 2025-03-14 14:39:51 UTC Artifacts will be uploaded here
⚪ 2025-03-14 14:43:19 UTC ya make is running...
⚫ 2025-03-14 15:14:44 UTC Check cancelled

@github-actions github-actions bot added bugfix and removed bugfix labels Mar 14, 2025
@github-actions
Copy link

github-actions bot commented Mar 14, 2025 •
edited
Loading

⚪ 2025-03-14 15:22:54 UTC Pre-commit check linux-x86_64-release-asan for 3f2835a has started.
⚪ 2025-03-14 15:23:10 UTC Artifacts will be uploaded here
⚫ 2025-03-14 15:25:45 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Mar 14, 2025 •
edited
Loading

⚪ 2025-03-14 15:23:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3f2835a has started.
⚪ 2025-03-14 15:23:17 UTC Artifacts will be uploaded here
⚫ 2025-03-14 15:25:45 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Mar 14, 2025 •
edited
Loading

⚪ 2025-03-14 15:30:33 UTC Pre-commit check linux-x86_64-release-asan for fc88fdd has started.
⚪ 2025-03-14 15:30:50 UTC Artifacts will be uploaded here
⚪ 2025-03-14 15:33:48 UTC ya make is running...
🟡 2025-03-14 17:06:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13811 13714 0 43 16 38

⚪ 2025-03-14 17:08:13 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-14 17:20:33 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
151 (only retried tests) 102 0 8 6 35

⚪ 2025-03-14 17:20:41 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-14 17:37:50 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
86 (only retried tests) 41 0 8 3 34

🟢 2025-03-14 17:37:57 UTC Build successful.
🟢 2025-03-14 17:38:27 UTC ydbd size 3.8 GiB changed* by +20.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e837989 merge: fc88fdd diff diff %
ydbd size 4 046 541 048 Bytes 4 046 562 408 Bytes +20.9 KiB +0.001%
ydbd stripped size 1 400 046 696 Bytes 1 400 052 776 Bytes +5.9 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 14, 2025 •
edited
Loading

⚪ 2025-03-14 15:30:37 UTC Pre-commit check linux-x86_64-relwithdebinfo for fc88fdd has started.
⚪ 2025-03-14 15:30:52 UTC Artifacts will be uploaded here
⚪ 2025-03-14 15:34:02 UTC ya make is running...
🟡 2025-03-14 16:58:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28205 25589 0 19 2478 119

⚪ 2025-03-14 17:00:40 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-14 17:19:03 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
208 (only retried tests) 81 0 14 3 110

⚪ 2025-03-14 17:19:12 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-03-14 17:36:43 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
181 (only retried tests) 56 0 13 2 110

🟢 2025-03-14 17:36:50 UTC Build successful.
🟢 2025-03-14 17:37:12 UTC ydbd size 2.1 GiB changed* by +19.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: e837989 merge: fc88fdd diff diff %
ydbd size 2 298 146 072 Bytes 2 298 165 912 Bytes +19.4 KiB +0.001%
ydbd stripped size 481 080 256 Bytes 481 087 232 Bytes +6.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kungasc kungasc changed the title Fixing B-Tree histograms Fixing B-Tree histograms comparator result overflow issue Mar 14, 2025
@github-actions github-actions bot added bugfix and removed bugfix labels Mar 14, 2025
@github-actions
Copy link

github-actions bot commented Mar 14, 2025 •
edited
Loading

⚪ 2025-03-14 18:59:19 UTC Pre-commit check linux-x86_64-relwithdebinfo for db66800 has started.
⚪ 2025-03-14 19:00:01 UTC Artifacts will be uploaded here
⚪ 2025-03-14 19:03:36 UTC ya make is running...
🟡 2025-03-14 20:24:57 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28205 25600 0 7 2487 111

⚪ 2025-03-14 20:27:19 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-14 20:44:52 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
184 (only retried tests) 69 0 5 2 108

⚪ 2025-03-14 20:45:00 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-03-14 20:56:25 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
159 (only retried tests) 46 0 5 1 107

🟢 2025-03-14 20:56:32 UTC Build successful.
🟢 2025-03-14 20:56:50 UTC ydbd size 2.1 GiB changed* by +19.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 708cc79 merge: db66800 diff diff %
ydbd size 2 298 146 968 Bytes 2 298 166 808 Bytes +19.4 KiB +0.001%
ydbd stripped size 481 080 256 Bytes 481 087 232 Bytes +6.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 14, 2025 •
edited
Loading

⚪ 2025-03-14 19:00:25 UTC Pre-commit check linux-x86_64-release-asan for db66800 has started.
⚪ 2025-03-14 19:00:39 UTC Artifacts will be uploaded here
⚪ 2025-03-14 19:03:39 UTC ya make is running...
🟡 2025-03-14 20:31:51 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13811 13728 0 33 11 39

⚪ 2025-03-14 20:33:01 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-14 20:44:54 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
129 (only retried tests) 88 0 0 7 34

🟢 2025-03-14 20:45:00 UTC Build successful.
🟢 2025-03-14 20:45:27 UTC ydbd size 3.8 GiB changed* by +20.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 708cc79 merge: db66800 diff diff %
ydbd size 4 046 529 376 Bytes 4 046 550 728 Bytes +20.9 KiB +0.001%
ydbd stripped size 1 400 038 504 Bytes 1 400 044 584 Bytes +5.9 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 16, 2025 •
edited
Loading

⚪ 2025-03-16 12:08:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for 46fa8de has started.
⚪ 2025-03-16 12:08:43 UTC Artifacts will be uploaded here
⚪ 2025-03-16 12:11:41 UTC ya make is running...
🟡 2025-03-16 13:39:22 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28218 25604 0 6 2494 114

⚪ 2025-03-16 13:41:45 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-16 13:53:42 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
186 (only retried tests) 77 0 0 2 107

🟢 2025-03-16 13:53:49 UTC Build successful.
🟢 2025-03-16 13:54:07 UTC ydbd size 2.1 GiB changed* by +16.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 21deadd merge: 46fa8de diff diff %
ydbd size 2 298 366 176 Bytes 2 298 383 472 Bytes +16.9 KiB +0.001%
ydbd stripped size 481 106 688 Bytes 481 109 888 Bytes +3.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Mar 16, 2025 •
edited
Loading

⚪ 2025-03-16 12:08:33 UTC Pre-commit check linux-x86_64-release-asan for 46fa8de has started.
⚪ 2025-03-16 12:08:48 UTC Artifacts will be uploaded here
⚪ 2025-03-16 12:11:46 UTC ya make is running...
🟡 2025-03-16 13:50:10 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13812 13701 0 48 25 38

⚪ 2025-03-16 13:51:19 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-16 14:09:01 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
163 (only retried tests) 118 0 0 9 36

🟢 2025-03-16 14:09:08 UTC Build successful.
🟢 2025-03-16 14:09:37 UTC ydbd size 3.8 GiB changed* by +23.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 21deadd merge: 46fa8de diff diff %
ydbd size 4 046 899 704 Bytes 4 046 923 232 Bytes +23.0 KiB +0.001%
ydbd stripped size 1 400 126 856 Bytes 1 400 133 448 Bytes +6.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kungasc kungasc marked this pull request as ready for review March 17, 2025 08:41
@kungasc kungasc requested a review from snaury March 17, 2025 08:43
@kungasc kungasc changed the title Fix B-Tree histograms comparator result overflow issue Fix B-Tree histograms comparator result overflow Mar 17, 2025
@github-actions github-actions bot added bugfix and removed bugfix labels Mar 17, 2025
@kungasc kungasc merged commit b071759 into ydb-platform:main Mar 17, 2025
14 checks passed
kungasc added a commit to kungasc/ydb that referenced this pull request Mar 17, 2025
@kungasc
Fix B-Tree histograms comparator result overflow (ydb-platform#15720)
f7d3b74
This was referenced Mar 17, 2025
Merged
Closed
kungasc added a commit to kungasc/ydb that referenced this pull request Mar 17, 2025
@kungasc
Fix B-Tree histograms comparator result overflow (ydb-platform#15720)
2671650
@kungasc kungasc mentioned this pull request Mar 17, 2025
Merged
kungasc added a commit to kungasc/ydb that referenced this pull request Mar 17, 2025
@kungasc
Fix B-Tree histograms comparator result overflow (ydb-platform#15720)
ac1b81e
@kungasc kungasc mentioned this pull request Mar 17, 2025
Merged
adameat pushed a commit to adameat/ydb that referenced this pull request Mar 20, 2025
@kungasc @adameat
Fix B-Tree histograms comparator result overflow (ydb-platform#15720)
e87399a
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@kungasc @blinkov
Fix B-Tree histograms comparator result overflow (#15720)
43a4319
Emgariko pushed a commit to Emgariko/ydb that referenced this pull request Mar 24, 2025
@kungasc @Emgariko
Fix B-Tree histograms comparator result overflow (ydb-platform#15720)
5b7dabb
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 28, 2025
@kungasc
Fix B-Tree histograms comparator result overflow (ydb-platform#15720)
90b2967
@liruoko liruoko added the changelog/f25-3 PR участвует в списке изменений label Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snaury snaury snaury approved these changes

Assignees

@kungasc kungasc

Labels

bugfix changelog/f25-3 PR участвует в списке изменений

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kungasc @snaury @liruoko