Skip to content

24-4: Don't ack readsets too early on volatile tx abort #14516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

snaury
Copy link
Member

@snaury snaury commented Feb 13, 2025

Changelog entry

Don't ack readsets too early on volatile tx abort. Fixes #14474.

Changelog category

  • Bugfix

Additional information

It was discovered that readsets could be acknowledged too early during a failed volatile tx abort and could lead to new tablet generation to wait for readsets which would not arrive until participants restart at least one more time.

@snaury snaury self-assigned this Feb 13, 2025
@snaury snaury marked this pull request as ready for review February 13, 2025 07:18
@snaury snaury requested a review from a team as a code owner February 13, 2025 07:18
Copy link

github-actions bot commented Feb 13, 2025

2025-02-13 07:18:29 UTC Pre-commit check for 4575239 has started.
2025-02-13 07:21:13 UTC Build linux-x86_64-release-asan is running...
🟢 2025-02-13 07:45:15 UTC Build successful.
2025-02-13 07:45:33 UTC Tests are running...
🔴 2025-02-13 09:58:24 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10411 10306 0 34 29 42

🟢 2025-02-13 09:59:25 UTC ydbd size 5.6 GiB changed* by +2.3 KiB, which is < 100.0 KiB vs stable-24-4: OK

ydbd size dash stable-24-4: 80dbaee merge: 4575239 diff diff %
ydbd size 6 002 879 800 Bytes 6 002 882 152 Bytes +2.3 KiB +0.000%
ydbd stripped size 1 504 263 840 Bytes 1 504 264 544 Bytes +704 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 13, 2025

2025-02-13 07:20:09 UTC Pre-commit check for 4575239 has started.
2025-02-13 07:22:48 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-02-13 08:03:27 UTC Build successful.
2025-02-13 08:03:45 UTC Tests are running...
🔴 2025-02-13 09:31:16 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14738 13377 0 21 1301 39

🟢 2025-02-13 09:32:01 UTC ydbd size 8.3 GiB changed* by +3.1 KiB, which is < 100.0 KiB vs stable-24-4: OK

ydbd size dash stable-24-4: 80dbaee merge: 4575239 diff diff %
ydbd size 8 874 328 216 Bytes 8 874 331 384 Bytes +3.1 KiB +0.000%
ydbd stripped size 483 822 056 Bytes 483 822 248 Bytes +192 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury snaury merged commit 457659d into ydb-platform:stable-24-4 Feb 13, 2025
4 of 9 checks passed
@snaury snaury deleted the bugfix-14474-early-readset-ack-24-4 branch February 13, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants