Skip to content

Don't ack readsets too early on volatile tx abort #14495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

snaury
Copy link
Member

@snaury snaury commented Feb 12, 2025

Changelog entry

Don't ack readsets too early on volatile tx abort

Changelog category

  • Bugfix

Additional information

It was discovered that readsets could be acknowledged too early during a failed volatile tx abort and could lead to new tablet generation to wait for readsets which would not arrive until participants restart at least one more time.

Fixes #14474.

@snaury snaury self-assigned this Feb 12, 2025
Copy link

github-actions bot commented Feb 12, 2025

2025-02-12 14:08:42 UTC Pre-commit check linux-x86_64-relwithdebinfo for e6fa9fa has started.
2025-02-12 14:09:03 UTC Artifacts will be uploaded here
2025-02-12 14:12:33 UTC ya make is running...
🟡 2025-02-12 15:01:24 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18747 17399 0 4 1213 131

2025-02-12 15:03:23 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-12 15:30:08 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
207 (only retried tests) 79 0 0 1 127

🟢 2025-02-12 15:30:16 UTC Build successful.
🟢 2025-02-12 15:30:35 UTC ydbd size 2.1 GiB changed* by +432 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 335d81a merge: e6fa9fa diff diff %
ydbd size 2 229 155 304 Bytes 2 229 155 736 Bytes +432 Bytes +0.000%
ydbd stripped size 473 275 352 Bytes 473 275 480 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 12, 2025

2025-02-12 14:09:05 UTC Pre-commit check linux-x86_64-release-asan for e6fa9fa has started.
2025-02-12 14:09:35 UTC Artifacts will be uploaded here
2025-02-12 14:13:19 UTC ya make is running...
🟡 2025-02-12 15:31:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11468 11396 0 19 16 37

2025-02-12 15:32:43 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-12 15:50:59 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
108 (only retried tests) 68 0 1 4 35

2025-02-12 15:51:10 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-02-12 16:02:51 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
70 (only retried tests) 33 0 1 3 33

🟢 2025-02-12 16:03:07 UTC Build successful.
🟢 2025-02-12 16:03:37 UTC ydbd size 3.6 GiB changed* by +1.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 335d81a merge: e6fa9fa diff diff %
ydbd size 3 876 563 976 Bytes 3 876 565 192 Bytes +1.2 KiB +0.000%
ydbd stripped size 1 357 419 696 Bytes 1 357 420 144 Bytes +448 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury snaury marked this pull request as ready for review February 12, 2025 14:14
@snaury snaury enabled auto-merge (squash) February 12, 2025 16:34
@snaury snaury requested a review from azevaykin February 12, 2025 19:28
@snaury snaury merged commit f45abe2 into ydb-platform:main Feb 13, 2025
13 checks passed
@snaury snaury deleted the bugfix-14474-early-readset-ack branch February 13, 2025 07:05
lberserq pushed a commit to lberserq/ydb that referenced this pull request Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataShard: possible ack to readset on volatile tx abort while new generation sends an expectation and waits forever
2 participants