Skip to content

Sync EvaluteExpr execution (#11801) #14456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

Hor911
Copy link
Collaborator

@Hor911 Hor911 commented Feb 11, 2025

During query compilation special subroutine called "Expression Evaluation" may be triggered (most common case is Constant Folding in query optimization phase).

It was implemented with async API and future waiting. In some rare cases (erros or failures) future was not completed and compilation hangs forever

This path removes future from call stack and replaces it with direct sync call. It requires change of internal API, it is one of the reason why this pattern was not choosed at the time of the development.

The fix was checked with load test (enabled in this PR) and by @dcherednik in manual runs.

@Hor911 Hor911 requested a review from a team as a code owner February 11, 2025 15:30
Copy link

github-actions bot commented Feb 11, 2025

2025-02-11 15:32:20 UTC Pre-commit check for de791a7 has started.
2025-02-11 15:35:08 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-02-11 16:18:08 UTC Build successful.
2025-02-11 16:18:30 UTC Tests are running...
🔴 2025-02-11 18:15:38 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39073 33791 0 24 5219 39

🟢 2025-02-11 18:17:22 UTC ydbd size 8.3 GiB changed* by -260.2 KiB, which is <= 0 Bytes vs stable-24-4: OK

ydbd size dash stable-24-4: 80dbaee merge: de791a7 diff diff %
ydbd size 8 874 328 216 Bytes 8 874 061 800 Bytes -260.2 KiB -0.003%
ydbd stripped size 483 822 056 Bytes 483 816 296 Bytes -5.6 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 11, 2025

2025-02-11 15:34:28 UTC Pre-commit check for de791a7 has started.
2025-02-11 15:37:41 UTC Build linux-x86_64-release-asan is running...
🟢 2025-02-11 16:02:10 UTC Build successful.
2025-02-11 16:02:24 UTC Tests are running...
🔴 2025-02-11 18:02:40 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10501 10407 0 29 24 41

🟢 2025-02-11 18:03:29 UTC ydbd size 5.6 GiB changed* by -70.6 KiB, which is <= 0 Bytes vs stable-24-4: OK

ydbd size dash stable-24-4: 80dbaee merge: de791a7 diff diff %
ydbd size 6 002 879 800 Bytes 6 002 807 496 Bytes -70.6 KiB -0.001%
ydbd stripped size 1 504 263 840 Bytes 1 504 242 624 Bytes -20.7 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@gridnevvvit gridnevvvit self-requested a review February 11, 2025 18:27
@gridnevvvit gridnevvvit merged commit c710d8a into ydb-platform:stable-24-4 Feb 14, 2025
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants