Skip to content

Fix BS_QUEUE death (merge from main #14081) #14095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2025

Conversation

alexvru
Copy link
Collaborator

@alexvru alexvru commented Jan 31, 2025

Changelog entry

Fix BS_QUEUE death

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

When BS_QUEUE got terminated before this fix, it did not finish any inflight requests. This would lead to VDisk window leak.

@alexvru alexvru requested a review from a team as a code owner January 31, 2025 20:45
Copy link

github-actions bot commented Jan 31, 2025

2025-01-31 20:46:20 UTC Pre-commit check for 5818c92 has started.
2025-01-31 20:48:55 UTC Build linux-x86_64-release-asan is running...
🟢 2025-01-31 21:12:25 UTC Build successful.
2025-01-31 21:12:41 UTC Tests are running...
🔴 2025-01-31 23:19:27 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10614 10497 0 40 32 45

🟢 2025-01-31 23:20:22 UTC ydbd size 5.6 GiB changed* by +4.1 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: c1b8015 merge: 5818c92 diff diff %
ydbd size 6 002 340 216 Bytes 6 002 344 456 Bytes +4.1 KiB +0.000%
ydbd stripped size 1 504 183 200 Bytes 1 504 184 032 Bytes +832 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 31, 2025

2025-01-31 20:46:52 UTC Pre-commit check for 5818c92 has started.
2025-01-31 20:49:38 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-01-31 21:29:22 UTC Build successful.
2025-01-31 21:29:40 UTC Tests are running...
🔴 2025-01-31 22:58:21 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14937 13582 0 15 1302 38

🟢 2025-01-31 22:59:08 UTC ydbd size 8.3 GiB changed* by +3.5 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: c1b8015 merge: 5818c92 diff diff %
ydbd size 8 873 984 248 Bytes 8 873 987 792 Bytes +3.5 KiB +0.000%
ydbd stripped size 484 284 840 Bytes 484 285 096 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru enabled auto-merge (squash) February 1, 2025 16:49
@alexvru alexvru merged commit 375ea47 into ydb-platform:stable-24-3 Feb 1, 2025
6 of 10 checks passed
@alexvru alexvru deleted the merge/24-3/14081 branch February 2, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants