Skip to content

Fix BS_QUEUE death #14081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Conversation

alexvru
Copy link
Collaborator

@alexvru alexvru commented Jan 31, 2025

Changelog entry

Fix BS_QUEUE death

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

When BS_QUEUE got terminated before this fix, it did not finish any inflight requests. This would lead to VDisk window leak.

Copy link

github-actions bot commented Jan 31, 2025

2025-01-31 13:22:00 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4975301 has started.
2025-01-31 13:22:14 UTC Artifacts will be uploaded here
2025-01-31 13:25:17 UTC ya make is running...
🟡 2025-01-31 14:30:05 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19003 17687 0 2 1188 126

2025-01-31 14:32:43 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-31 14:45:15 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
190 (only retried tests) 69 0 0 0 121

🟢 2025-01-31 14:45:22 UTC Build successful.
🟢 2025-01-31 14:45:49 UTC ydbd size 2.1 GiB changed* by +608 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 5f5960b merge: 4975301 diff diff %
ydbd size 2 227 744 920 Bytes 2 227 745 528 Bytes +608 Bytes +0.000%
ydbd stripped size 471 436 112 Bytes 471 436 176 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 31, 2025

2025-01-31 13:23:02 UTC Pre-commit check linux-x86_64-release-asan for 4975301 has started.
2025-01-31 13:23:16 UTC Artifacts will be uploaded here
2025-01-31 13:26:06 UTC ya make is running...
🟡 2025-01-31 14:28:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11616 11543 0 30 11 32

2025-01-31 14:30:22 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-31 14:45:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
103 (only retried tests) 71 0 1 5 26

2025-01-31 14:45:18 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-01-31 14:58:28 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
54 (only retried tests) 25 0 0 2 27

🟢 2025-01-31 14:58:39 UTC Build successful.
🟢 2025-01-31 14:59:06 UTC ydbd size 3.6 GiB changed* by +1.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 5f5960b merge: 4975301 diff diff %
ydbd size 3 870 957 544 Bytes 3 870 958 744 Bytes +1.2 KiB +0.000%
ydbd stripped size 1 353 825 264 Bytes 1 353 825 584 Bytes +320 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

kruall
kruall previously approved these changes Jan 31, 2025
@alexvru alexvru enabled auto-merge (squash) January 31, 2025 14:57
@alexvru alexvru disabled auto-merge January 31, 2025 14:57
Copy link

github-actions bot commented Jan 31, 2025

2025-01-31 15:03:52 UTC Pre-commit check linux-x86_64-release-asan for 55ecea6 has started.
2025-01-31 15:04:45 UTC Artifacts will be uploaded here
2025-01-31 15:07:48 UTC ya make is running...
🟡 2025-01-31 16:38:11 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11620 11553 0 17 15 35

2025-01-31 16:40:11 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-31 16:52:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
100 (only retried tests) 65 0 2 4 29

2025-01-31 16:52:22 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-31 17:03:53 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60 (only retried tests) 27 0 1 3 29

🟢 2025-01-31 17:04:05 UTC Build successful.
🟢 2025-01-31 17:04:36 UTC ydbd size 3.6 GiB changed* by +22.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0c9e55a merge: 55ecea6 diff diff %
ydbd size 3 870 957 800 Bytes 3 870 981 072 Bytes +22.7 KiB +0.001%
ydbd stripped size 1 353 825 360 Bytes 1 353 832 240 Bytes +6.7 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 31, 2025

2025-01-31 15:04:42 UTC Pre-commit check linux-x86_64-relwithdebinfo for 55ecea6 has started.
2025-01-31 15:05:13 UTC Artifacts will be uploaded here
2025-01-31 15:08:14 UTC ya make is running...
🟡 2025-01-31 19:52:07 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19003 17681 0 1 1190 131

2025-01-31 19:54:26 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-31 20:04:46 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
196 (only retried tests) 75 0 0 0 121

🟢 2025-01-31 20:04:54 UTC Build successful.
🟢 2025-01-31 20:05:13 UTC ydbd size 2.1 GiB changed* by +12.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4d23192 merge: 55ecea6 diff diff %
ydbd size 2 227 744 952 Bytes 2 227 757 216 Bytes +12.0 KiB +0.001%
ydbd stripped size 471 436 112 Bytes 471 438 128 Bytes +2.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru merged commit f63fb8f into ydb-platform:main Jan 31, 2025
12 checks passed
@alexvru alexvru deleted the vdisk/fix-bsqueue-death branch January 31, 2025 20:42
alexvru added a commit to alexvru/ydb that referenced this pull request Jan 31, 2025
alexvru added a commit to alexvru/ydb that referenced this pull request Feb 2, 2025
azevaykin pushed a commit to azevaykin/ydb that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants