Skip to content

Revert "Redefine flags for win32 (#13362)" because it didn't fix windows build #14072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

pnv1
Copy link
Collaborator

@pnv1 pnv1 commented Jan 31, 2025

This reverts commit 7e240c68ad5a0e513d2126df4c8fe531e2577ba3.

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@pnv1 pnv1 requested a review from a team as a code owner January 31, 2025 11:01
Copy link

github-actions bot commented Jan 31, 2025

2025-01-31 11:03:36 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2810a8a has started.
2025-01-31 11:03:48 UTC Artifacts will be uploaded here
2025-01-31 11:11:48 UTC ya make is running...
🟡 2025-01-31 13:23:57 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
29406 26866 0 1 2415 124

2025-01-31 13:27:05 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-31 13:37:49 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
184 (only retried tests) 64 0 0 0 120

🟢 2025-01-31 13:37:57 UTC Build successful.
🟢 2025-01-31 13:38:15 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 79d9940 merge: 2810a8a diff diff %
ydbd size 2 227 718 064 Bytes 2 227 718 064 Bytes 0 Bytes 0.000%
ydbd stripped size 471 433 872 Bytes 471 433 872 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 31, 2025

2025-01-31 11:04:14 UTC Pre-commit check linux-x86_64-release-asan for 2810a8a has started.
2025-01-31 11:04:27 UTC Artifacts will be uploaded here
2025-01-31 11:12:34 UTC ya make is running...
🟡 2025-01-31 13:34:38 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14861 14790 0 25 14 32

2025-01-31 13:36:30 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-31 13:48:58 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
107 (only retried tests) 69 0 1 9 28

2025-01-31 13:49:07 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-31 14:00:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60 (only retried tests) 23 0 1 9 27

🟢 2025-01-31 14:01:08 UTC Build successful.
🟢 2025-01-31 14:01:38 UTC ydbd size 3.6 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 79d9940 merge: 2810a8a diff diff %
ydbd size 3 870 910 432 Bytes 3 870 910 336 Bytes -96 Bytes -0.000%
ydbd stripped size 1 353 816 496 Bytes 1 353 816 432 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@pnv1 pnv1 enabled auto-merge (squash) January 31, 2025 11:49
@pnv1 pnv1 merged commit 0c9e55a into ydb-platform:main Jan 31, 2025
13 checks passed
@pnv1 pnv1 deleted the reapply-windows-fix branch January 31, 2025 17:27
azevaykin pushed a commit to azevaykin/ydb that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants