Skip to content

YQ-4103 fixed overflow in kqp write actor CalculateNextAttemptDelay #14415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

GrigoriyPA
Copy link
Collaborator

@GrigoriyPA GrigoriyPA commented Feb 11, 2025

Changelog entry

  • Fixed overflow in CalculateNextAttemptDelay
  • Fixed missing config setting

Changelog category

  • Bugfix

Additional information

@GrigoriyPA GrigoriyPA requested a review from a team as a code owner February 11, 2025 07:46
@GrigoriyPA GrigoriyPA requested a review from nikvas0 February 11, 2025 07:47
Copy link

github-actions bot commented Feb 11, 2025

2025-02-11 07:50:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for ae25761 has started.
2025-02-11 07:50:38 UTC Artifacts will be uploaded here
2025-02-11 07:53:37 UTC ya make is running...
🟡 2025-02-11 08:43:47 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18723 17382 0 1 1206 134

2025-02-11 08:45:22 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-11 08:56:36 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
198 (only retried tests) 73 0 0 0 125

🟢 2025-02-11 08:56:46 UTC Build successful.
🟢 2025-02-11 08:57:09 UTC ydbd size 2.1 GiB changed* by +80 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: c166bec merge: ae25761 diff diff %
ydbd size 2 228 682 408 Bytes 2 228 682 488 Bytes +80 Bytes +0.000%
ydbd stripped size 473 235 288 Bytes 473 235 416 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 11, 2025

2025-02-11 07:50:30 UTC Pre-commit check linux-x86_64-release-asan for ae25761 has started.
2025-02-11 07:50:42 UTC Artifacts will be uploaded here
2025-02-11 07:53:31 UTC ya make is running...
🟡 2025-02-11 08:50:38 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11445 11371 0 21 18 35

2025-02-11 08:51:38 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-11 09:05:38 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
113 (only retried tests) 75 0 0 2 36

🟢 2025-02-11 09:05:52 UTC Build successful.
🟢 2025-02-11 09:06:25 UTC ydbd size 3.6 GiB changed* by -1.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: c166bec merge: ae25761 diff diff %
ydbd size 3 875 743 976 Bytes 3 875 742 680 Bytes -1.3 KiB -0.000%
ydbd stripped size 1 357 256 752 Bytes 1 357 255 728 Bytes -1.0 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA merged commit 30f1c6c into ydb-platform:main Feb 11, 2025
14 checks passed
@GrigoriyPA GrigoriyPA deleted the YQ-4103-fix-fault-in-kqp-write-actor branch February 11, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants