Return virtual timestamp for scan query #14001

dcherednik · 2025-01-29T18:06:23Z

No description provided.

github-actions · 2025-01-29T18:10:16Z

⚪ 2025-01-29 18:10:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for eb3e7f1 has started.
⚪ 2025-01-29 18:14:08 UTC Artifacts will be uploaded here
⚪ 2025-01-29 18:17:36 UTC ya make is running...
🟡 2025-01-29 20:50:33 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
28136	25582	0	1	2423	130

⚪ 2025-01-29 20:52:54 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-29 21:02:41 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
202 (only retried tests)	79	0	0	0	123

🟢 2025-01-29 21:02:48 UTC Build successful.
🟢 2025-01-29 21:03:08 UTC ydbd size 2.1 GiB changed* by +11.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `c480e60`	merge: `eb3e7f1`	diff	diff %
ydbd size	2 226 153 720 Bytes	2 226 165 272 Bytes	+11.3 KiB	+0.001%
ydbd stripped size	470 595 056 Bytes	470 599 600 Bytes	+4.4 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-01-29T18:11:09Z

⚪ 2025-01-29 18:11:09 UTC Pre-commit check linux-x86_64-release-asan for eb3e7f1 has started.
⚪ 2025-01-29 18:15:37 UTC Artifacts will be uploaded here
⚪ 2025-01-29 18:18:58 UTC ya make is running...
🟡 2025-01-29 19:49:59 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
13712	13646	0	18	8	40

⚪ 2025-01-29 19:51:32 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-29 20:03:21 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
98 (only retried tests)	64	0	0	4	30

🟢 2025-01-29 20:03:29 UTC Build successful.
🟢 2025-01-29 20:03:54 UTC ydbd size 3.6 GiB changed* by +16.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `c480e60`	merge: `eb3e7f1`	diff	diff %
ydbd size	3 868 578 024 Bytes	3 868 594 488 Bytes	+16.1 KiB	+0.000%
ydbd stripped size	1 352 686 864 Bytes	1 352 692 816 Bytes	+5.8 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

gridnevvvit

будет ли саппорт? почему только scan query?

dcherednik · 2025-01-30T11:38:02Z

будет ли саппорт? почему только scan query?

Да, будет.
Пока только scan query потому что на него есть прям сейчас запрос от пользователей и по тому что тут все что нужно есть под ногами, и потому что такое уже сделано для ReadTable вызова.

Для generic query надо дизайнить что делать с immidiate транзакциями, идеи есть, но надо еще подумать.

gridnevvvit · 2025-01-30T15:14:21Z

ну я бы предложил бы не реализовывать новые фичи в ScanQuery, которых не будет в QueryService. поэтому если это нужно дизайнить, давайте дизайнить. Потому что UI и другие интерфейсы будут использовать QueryService и не хочется двигаться в разных направлениях.

github-actions · 2025-04-16T15:58:58Z

⚪ 2025-04-16 15:58:57 UTC Pre-commit check linux-x86_64-release-asan for 263288a has started.
⚪ 2025-04-16 15:59:27 UTC Artifacts will be uploaded here
⚪ 2025-04-16 16:03:41 UTC ya make is running...
🟡 2025-04-16 18:00:32 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14923	14713	0	137	35	38

⚪ 2025-04-16 18:01:49 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-16 18:15:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
283 (only retried tests)	188	0	42	19	34

⚪ 2025-04-16 18:15:31 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-16 18:27:49 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
130 (only retried tests)	58	0	35	2	35

🟢 2025-04-16 18:27:56 UTC Build successful.
🟢 2025-04-16 18:28:26 UTC ydbd size 3.9 GiB changed* by +16.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `68489d0`	merge: `263288a`	diff	diff %
ydbd size	4 145 176 520 Bytes	4 145 192 888 Bytes	+16.0 KiB	+0.000%
ydbd stripped size	1 431 281 176 Bytes	1 431 287 128 Bytes	+5.8 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-04-16T16:01:40Z

⚪ 2025-04-16 16:01:39 UTC Pre-commit check linux-x86_64-relwithdebinfo for 263288a has started.
⚪ 2025-04-16 16:01:55 UTC Artifacts will be uploaded here
⚪ 2025-04-16 16:05:16 UTC ya make is running...
🟡 2025-04-16 18:03:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
29594	26898	0	6	2571	119

⚪ 2025-04-16 18:05:40 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-16 18:16:27 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
191 (only retried tests)	86	0	1	0	104

⚪ 2025-04-16 18:16:35 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-04-16 18:28:11 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
146 (only retried tests)	43	0	0	0	103

🟢 2025-04-16 18:28:18 UTC Build successful.
🟢 2025-04-16 18:28:43 UTC ydbd size 2.2 GiB changed* by +7.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `68489d0`	merge: `263288a`	diff	diff %
ydbd size	2 362 260 344 Bytes	2 362 267 880 Bytes	+7.4 KiB	+0.000%
ydbd stripped size	493 677 984 Bytes	493 678 432 Bytes	+448 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-04-28T16:20:06Z

⚪ 2025-04-28 16:20:06 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5e763e9 has started.
⚪ 2025-04-28 16:20:28 UTC Artifacts will be uploaded here
⚪ 2025-04-28 16:24:11 UTC ya make is running...
🟡 2025-04-28 18:19:14 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
30179	27498	0	4	2640	37

⚪ 2025-04-28 18:21:42 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-28 19:01:46 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
140 (only retried tests)	99	0	1	6	34

⚪ 2025-04-28 19:01:54 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-04-28 19:14:02 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
118 (only retried tests)	71	0	0	16	31

🟢 2025-04-28 19:14:09 UTC Build successful.
🟢 2025-04-28 19:14:33 UTC ydbd size 2.2 GiB changed* by +15.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `aff4b61`	merge: `5e763e9`	diff	diff %
ydbd size	2 342 860 208 Bytes	2 342 875 960 Bytes	+15.4 KiB	+0.001%
ydbd stripped size	492 650 624 Bytes	492 655 456 Bytes	+4.7 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-04-28T16:21:29Z

⚪ 2025-04-28 16:21:28 UTC Pre-commit check linux-x86_64-release-asan for 5e763e9 has started.
⚪ 2025-04-28 16:21:44 UTC Artifacts will be uploaded here
⚪ 2025-04-28 16:25:05 UTC ya make is running...
🟡 2025-04-28 18:33:38 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15385	15238	0	74	49	24

⚪ 2025-04-28 18:34:58 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-28 19:06:13 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
918 (only retried tests)	814	0	48	32	24

⚪ 2025-04-28 19:06:26 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-28 19:30:11 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
764 (only retried tests)	670	0	45	25	24

🟢 2025-04-28 19:30:21 UTC Build successful.
🟢 2025-04-28 19:30:54 UTC ydbd size 3.8 GiB changed* by +58.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `bf4d5a0`	merge: `5e763e9`	diff	diff %
ydbd size	4 121 494 160 Bytes	4 121 554 176 Bytes	+58.6 KiB	+0.001%
ydbd stripped size	1 428 737 560 Bytes	1 428 753 944 Bytes	+16.0 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

alexv-smirnov · 2025-04-29T11:13:26Z

The PR has been updated.

TableService.ScanQuery returns timestamp in the 'snapshot' field, the name is the same like earlier implemented for the 'ReadTable' method.
To maintain possibility for user migration from TableService to QueryService, the same functionality is supported on the QueryService.Execute method, returning the snapshot timestamp in the 'snapshot_timestamp' field, when applicable. The name has been chosen to differentiate from the commit timestamp which is to be added separately.

dcherednik · 2025-04-29T12:24:01Z

We return timestamp in the each part of stream response.

For query service timestamp returned only for queries which acquires MVCC snapshot (all ro request).

Approved in the personal message

Conflicts: ydb/core/kqp/executer_actor/kqp_executer_impl.h ydb/public/api/protos/ydb_table.proto ydb/public/sdk/cpp/include/ydb-cpp-sdk/client/table/table.h ydb/public/sdk/cpp/src/client/table/impl/readers.cpp

(cherry picked from commit 093c931)

dcherednik requested a review from a team as a code owner January 29, 2025 18:06

Gazizonoki previously approved these changes Jan 29, 2025

View reviewed changes

gridnevvvit self-requested a review January 30, 2025 08:41

gridnevvvit previously requested changes Jan 30, 2025

View reviewed changes

dcherednik dismissed Gazizonoki’s stale review via 919813c February 19, 2025 12:39

dcherednik requested a review from a team as a code owner February 19, 2025 12:39

dcherednik force-pushed the vt_result branch from 919813c to c289a2c Compare April 16, 2025 15:57

Return virtual timestamp for scan query

84023c4

dcherednik force-pushed the vt_result branch from c289a2c to 84023c4 Compare April 28, 2025 16:17

gridnevvvit self-requested a review April 30, 2025 15:13

spuchin approved these changes Apr 30, 2025

View reviewed changes

dcherednik enabled auto-merge (squash) April 30, 2025 19:11

alexv-smirnov disabled auto-merge April 30, 2025 19:17

Gazizonoki approved these changes Apr 30, 2025

View reviewed changes

alexv-smirnov merged commit 093c931 into ydb-platform:main Apr 30, 2025
15 checks passed

UgnineSirdis pushed a commit that referenced this pull request Jun 8, 2025

Return virtual timestamp for scan query (#14001)

7ffd9a3

(cherry picked from commit 093c931)

StekPerepolnen mentioned this pull request Sep 15, 2025

audit fault stream nb 25 1 #24990

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Return virtual timestamp for scan query #14001

Return virtual timestamp for scan query #14001

Uh oh!

dcherednik commented Jan 29, 2025

Uh oh!

github-actions bot commented Jan 29, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jan 29, 2025 •

edited

Loading

Uh oh!

gridnevvvit left a comment

Uh oh!

dcherednik commented Jan 30, 2025

Uh oh!

gridnevvvit commented Jan 30, 2025

Uh oh!

github-actions bot commented Apr 16, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Apr 16, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Apr 28, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Apr 28, 2025 •

edited

Loading

Uh oh!

alexv-smirnov commented Apr 29, 2025

Uh oh!

dcherednik commented Apr 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Return virtual timestamp for scan query #14001

Return virtual timestamp for scan query #14001

Uh oh!

Conversation

dcherednik commented Jan 29, 2025

Uh oh!

github-actions bot commented Jan 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gridnevvvit left a comment

Choose a reason for hiding this comment

Uh oh!

dcherednik commented Jan 30, 2025

Uh oh!

gridnevvvit commented Jan 30, 2025

Uh oh!

github-actions bot commented Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexv-smirnov commented Apr 29, 2025

Uh oh!

dcherednik commented Apr 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

github-actions bot commented Jan 29, 2025 •

edited

Loading

github-actions bot commented Jan 29, 2025 •

edited

Loading

github-actions bot commented Apr 16, 2025 •

edited

Loading

github-actions bot commented Apr 16, 2025 •

edited

Loading

github-actions bot commented Apr 28, 2025 •

edited

Loading

github-actions bot commented Apr 28, 2025 •

edited

Loading