#9056 Auto-insert closing bracket in YDB CLI (#17774)

Signed-off-by: vityaman <vityaman.dev@yandex.ru>

Author: vityaman

ydb/apps/ydb/CHANGELOG.md

@@ -1,3 +1,4 @@
+* Brackets are now inserted in pairs in YDB CLI interactive mode
 * Added `--scale` option to `ydb workload tpch init` and `ydb workload tpcds init` commands. Sets the percentage of the benchmark's data size and workload to use, relative to full scale.
 * Added "--no-discovery" option. It allows to skip discovery and use user provided endpoint to connect to YDB cluster.
 * Added `--retries` to `ydb workload <clickbenh|tpch|tpcds> run` command.

ydb/public/lib/ydb_cli/commands/interactive/line_reader.cpp

@@ -7,6 +7,7 @@
 #include <yql/essentials/sql/v1/complete/string_util.h>
 
 #include <util/generic/string.h>
+#include <util/generic/hash.h>
 #include <util/system/file.h>
 
 #include <contrib/restricted/patched/replxx/include/replxx.hxx>
@@ -64,6 +65,8 @@ TLineReader::TLineReader(std::string prompt, std::string historyFilePath)
 {
     Rx.install_window_change_handler();
 
+    Rx.set_complete_on_empty(true);
+    Rx.set_word_break_characters(NSQLComplete::WordBreakCharacters);
     Rx.set_completion_callback([this](const std::string& prefix, int& contextLen) {
         return YQLCompleter->Apply(prefix, contextLen);
     });
@@ -74,27 +77,47 @@ TLineReader::TLineReader(std::string prompt, std::string historyFilePath)
         }
         return hints;
     });
+
     Rx.set_highlighter_callback([this](const auto& text, auto& colors) {
         YQLHighlighter->Apply(text, colors);
     });
-    Rx.enable_bracketed_paste();
-    Rx.set_unique_history(true);
-    Rx.set_complete_on_empty(true);
-    Rx.set_word_break_characters(NSQLComplete::WordBreakCharacters);
-    Rx.bind_key(replxx::Replxx::KEY::control('N'), [&](char32_t code) { return Rx.invoke(replxx::Replxx::ACTION::HISTORY_NEXT, code); });
-    Rx.bind_key(replxx::Replxx::KEY::control('P'), [&](char32_t code) { return Rx.invoke(replxx::Replxx::ACTION::HISTORY_PREVIOUS, code); });
-    Rx.bind_key(replxx::Replxx::KEY::control('D'), [](char32_t) { return replxx::Replxx::ACTION_RESULT::BAIL; });
-    auto commit_action = [&](char32_t code) {
+
+    Rx.bind_key(replxx::Replxx::KEY::control('N'), [&](char32_t code) { 
+        return Rx.invoke(replxx::Replxx::ACTION::HISTORY_NEXT, code); 
+    });
+    Rx.bind_key(replxx::Replxx::KEY::control('P'), [&](char32_t code) { 
+        return Rx.invoke(replxx::Replxx::ACTION::HISTORY_PREVIOUS, code); 
+    });
+    Rx.bind_key(replxx::Replxx::KEY::control('D'), [](char32_t) { 
+        return replxx::Replxx::ACTION_RESULT::BAIL; 
+    });
+    Rx.bind_key(replxx::Replxx::KEY::control('J'), [&](char32_t code) {
         return Rx.invoke(replxx::Replxx::ACTION::COMMIT_LINE, code);
-    };
-    Rx.bind_key(replxx::Replxx::KEY::control('J'), commit_action);
+    });
+
+    for (const auto [lhs, rhs] : THashMap<char, char>{
+        {'(', ')'},
+        {'[', ']'},
+        {'{', '}'},
+        {'`', '`'},
+        {'\'', '\''},
+        {'"', '"'},
+    }) {
+        Rx.bind_key(lhs, [&, lhs, rhs](char32_t) {
+            Rx.invoke(replxx::Replxx::ACTION::INSERT_CHARACTER, lhs);
+            Rx.invoke(replxx::Replxx::ACTION::INSERT_CHARACTER, rhs);
+            return Rx.invoke(replxx::Replxx::ACTION::MOVE_CURSOR_LEFT, 0);
+        });
+    }
 
     auto fileLockGuard = LockFile(HistoryFileHandle);
     if (!fileLockGuard) {
         Rx.print("Lock of history file failed: %s\n", strerror(errno));
         return;
     }
 
+    Rx.enable_bracketed_paste();
+    Rx.set_unique_history(true);
     if (!Rx.history_load(HistoryFilePath)) {
         Rx.print("Loading history failed: %s\n", strerror(errno));
     }