Skip to content

ClickHouse Client optional type fix #13815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

azevaykin
Copy link
Collaborator

Changelog entry

When loading metadata from the YDB side, optional type was no longer added to the data type.

Changelog category

  • Bugfix

Additional information

...

Copy link

github-actions bot commented Jan 24, 2025

2025-01-24 14:12:27 UTC Pre-commit check linux-x86_64-relwithdebinfo for b260b75 has started.
2025-01-24 14:12:37 UTC Artifacts will be uploaded here
2025-01-24 14:15:28 UTC ya make is running...
🟡 2025-01-24 15:03:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18743 17417 0 18 1184 124

2025-01-24 15:05:22 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-24 15:17:29 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
216 (only retried tests) 95 0 2 0 119

2025-01-24 15:17:39 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-01-24 15:29:48 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
178 (only retried tests) 61 0 0 0 117

🟢 2025-01-24 15:29:55 UTC Build successful.
🟢 2025-01-24 15:30:18 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 3d22318 merge: b260b75 diff diff %
ydbd size 2 221 636 256 Bytes 2 221 636 256 Bytes 0 Bytes 0.000%
ydbd stripped size 469 851 472 Bytes 469 851 472 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 24, 2025

2025-01-24 14:12:29 UTC Pre-commit check linux-x86_64-release-asan for b260b75 has started.
2025-01-24 14:12:41 UTC Artifacts will be uploaded here
2025-01-24 14:15:40 UTC ya make is running...
🟡 2025-01-24 15:18:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11284 11199 0 35 22 28

2025-01-24 15:19:54 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-24 15:36:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
132 (only retried tests) 84 0 18 3 27

2025-01-24 15:36:46 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-24 15:48:59 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
87 (only retried tests) 43 0 15 1 28

🟢 2025-01-24 15:49:07 UTC Build successful.
🟢 2025-01-24 15:49:36 UTC ydbd size 3.6 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 3d22318 merge: b260b75 diff diff %
ydbd size 3 860 438 408 Bytes 3 860 438 312 Bytes -96 Bytes -0.000%
ydbd stripped size 1 350 178 768 Bytes 1 350 178 704 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@azevaykin azevaykin merged commit 608b202 into ydb-platform:main Jan 24, 2025
13 checks passed
azevaykin added a commit to azevaykin/ydb that referenced this pull request Feb 3, 2025
@azevaykin azevaykin deleted the ClickhouseClientFix branch February 3, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants