Skip to content

24-3: ClickHouse Client optional type fix (#13815) #13821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

azevaykin
Copy link
Collaborator

Changelog entry

When loading metadata from the YDB side, optional type was no longer added to the data type.

Changelog category

  • Bugfix

Additional information

...

@azevaykin azevaykin requested a review from a team as a code owner January 24, 2025 16:04
Copy link

github-actions bot commented Jan 24, 2025

2025-01-24 16:08:18 UTC Pre-commit check for b1047c7 has started.
2025-01-24 16:10:53 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-01-24 16:51:05 UTC Build successful.
2025-01-24 16:51:23 UTC Tests are running...
🔴 2025-01-24 18:34:46 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14716 13360 0 16 1301 39

🟢 2025-01-24 18:35:31 UTC ydbd size 8.3 GiB changed* by -32 Bytes, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: cdeec5d merge: b1047c7 diff diff %
ydbd size 8 874 106 640 Bytes 8 874 106 608 Bytes -32 Bytes -0.000%
ydbd stripped size 484 288 904 Bytes 484 288 904 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 24, 2025

2025-01-24 16:08:21 UTC Pre-commit check for b1047c7 has started.
2025-01-24 16:10:58 UTC Build linux-x86_64-release-asan is running...
🟢 2025-01-24 16:33:24 UTC Build successful.
2025-01-24 16:33:40 UTC Tests are running...
🔴 2025-01-24 18:46:06 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10388 10288 0 30 29 41

🟢 2025-01-24 18:46:51 UTC ydbd size 5.6 GiB changed* by -160 Bytes, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: cdeec5d merge: b1047c7 diff diff %
ydbd size 6 002 371 032 Bytes 6 002 370 872 Bytes -160 Bytes -0.000%
ydbd stripped size 1 504 183 264 Bytes 1 504 183 136 Bytes -128 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@azevaykin azevaykin merged commit 33ff454 into ydb-platform:stable-24-3 Jan 24, 2025
6 of 10 checks passed
@azevaykin azevaykin deleted the stable-24-3 branch January 24, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants