Skip to content

[filestore] Allow 4G+ throttle values #13454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Conversation

proller
Copy link
Contributor

@proller proller commented Jan 16, 2025

Change type of Max[Read/Write]Bandwidth config variables to 64bit for allowing 4GB+ values

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

ydb-platform/nbs#1709
ydb-platform/nbs#1849

@proller proller changed the title Patch 1 [filestore] Allow 4G+ throttle values Jan 16, 2025
Copy link

github-actions bot commented Jan 16, 2025

2025-01-16 17:30:20 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4790e03 has started.
2025-01-16 17:30:24 UTC Artifacts will be uploaded here
2025-01-16 17:33:41 UTC ya make is running...
🟡 2025-01-16 19:00:26 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27545 25041 0 3 2380 121

2025-01-16 19:02:48 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-16 19:14:48 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
180 (only retried tests) 63 0 0 0 117

🟢 2025-01-16 19:14:55 UTC Build successful.
🟢 2025-01-16 19:15:13 UTC ydbd size 2.1 GiB changed* by +192 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 32f057a merge: 4790e03 diff diff %
ydbd size 2 252 364 992 Bytes 2 252 365 184 Bytes +192 Bytes +0.000%
ydbd stripped size 473 385 872 Bytes 473 385 872 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 16, 2025

2025-01-16 17:30:49 UTC Pre-commit check linux-x86_64-release-asan for 4790e03 has started.
2025-01-16 17:30:53 UTC Artifacts will be uploaded here
2025-01-16 17:34:11 UTC ya make is running...
🟡 2025-01-16 19:09:17 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13217 13162 0 25 4 26

2025-01-16 19:10:32 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-16 19:30:40 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
92 (only retried tests) 66 0 0 2 24

🟢 2025-01-16 19:30:49 UTC Build successful.
🟢 2025-01-16 19:31:15 UTC ydbd size 3.6 GiB changed* by +240 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 32f057a merge: 4790e03 diff diff %
ydbd size 3 902 686 176 Bytes 3 902 686 416 Bytes +240 Bytes +0.000%
ydbd stripped size 1 362 502 000 Bytes 1 362 501 936 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link
Collaborator

@SammyVimes SammyVimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SammyVimes SammyVimes merged commit 46d6120 into ydb-platform:main Jan 22, 2025
15 checks passed
proller added a commit to proller/ydb that referenced this pull request Jan 22, 2025
proller added a commit to proller/ydb that referenced this pull request Jan 22, 2025
azevaykin pushed a commit to azevaykin/ydb that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants