Suggest create table text on scheme error during `import file csv` #13247

pnv1 · 2025-01-09T17:25:27Z

Changelog entry

Added CREATE TABLE text suggestion on scheme error during ydb import file csv

Changelog category

New feature

github-actions · 2025-01-09T17:27:10Z

⚪ 2025-01-09 17:27:09 UTC Pre-commit check linux-x86_64-release-asan for b7c0e4e has started.
⚪ 2025-01-09 17:27:44 UTC Artifacts will be uploaded here
⚪ 2025-01-09 17:30:57 UTC ya make is running...
🟡 2025-01-09 18:26:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
11690	11634	0	23	3	30

⚪ 2025-01-09 18:27:19 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-09 18:39:17 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
94 (only retried tests)	60	0	7	2	25

⚪ 2025-01-09 18:39:25 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-09 18:51:02 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
62 (only retried tests)	34	0	4	0	24

🟢 2025-01-09 18:51:10 UTC Build successful.
🟢 2025-01-09 18:51:37 UTC ydbd size 3.6 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `12b269e`	merge: `b7c0e4e`	diff	diff %
ydbd size	3 874 456 216 Bytes	3 874 456 120 Bytes	-96 Bytes	-0.000%
ydbd stripped size	1 350 840 112 Bytes	1 350 840 048 Bytes	-64 Bytes	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-01-09T17:29:26Z

⚪ 2025-01-09 17:29:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for b7c0e4e has started.
⚪ 2025-01-09 17:29:38 UTC Artifacts will be uploaded here
⚪ 2025-01-09 17:32:43 UTC ya make is running...
🟡 2025-01-09 18:28:05 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
25444	22869	0	10	2442	123

⚪ 2025-01-09 18:30:34 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-09 18:42:11 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
250 (only retried tests)	131	0	0	0	119

🟢 2025-01-09 18:42:18 UTC Build successful.
🟢 2025-01-09 18:42:41 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `12b269e`	merge: `b7c0e4e`	diff	diff %
ydbd size	2 244 709 424 Bytes	2 244 709 424 Bytes	0 Bytes	0.000%
ydbd stripped size	472 409 936 Bytes	472 409 936 Bytes	0 Bytes	0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

ydb/public/lib/ydb_cli/import/import.cpp

ydb/public/lib/ydb_cli/common/csv_parser.h

ydb/public/lib/ydb_cli/common/csv_parser.cpp

ydb/public/lib/ydb_cli/import/import.cpp

github-actions · 2025-01-15T14:21:35Z

⚪ 2025-01-15 14:21:34 UTC Pre-commit check linux-x86_64-release-asan for 954efd9 has started.
⚪ 2025-01-15 14:21:38 UTC Artifacts will be uploaded here
⚪ 2025-01-15 14:24:30 UTC ya make is running...
🟡 2025-01-15 15:48:49 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
11716	11665	0	18	8	25

⚪ 2025-01-15 15:49:55 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-15 16:01:57 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
82 (only retried tests)	55	0	0	2	25

🟢 2025-01-15 16:02:05 UTC Build successful.
🟢 2025-01-15 16:02:29 UTC ydbd size 3.6 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `6bcf4a6`	merge: `954efd9`	diff	diff %
ydbd size	3 903 127 776 Bytes	3 903 127 680 Bytes	-96 Bytes	-0.000%
ydbd stripped size	1 362 986 384 Bytes	1 362 986 320 Bytes	-64 Bytes	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-01-15T14:24:32Z

⚪ 2025-01-15 14:24:32 UTC Pre-commit check linux-x86_64-relwithdebinfo for 954efd9 has started.
⚪ 2025-01-15 14:24:44 UTC Artifacts will be uploaded here
⚪ 2025-01-15 14:27:51 UTC ya make is running...
🟡 2025-01-15 15:29:22 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
25461	22958	0	4	2380	119

⚪ 2025-01-15 15:31:47 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-15 15:47:18 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
178 (only retried tests)	61	0	0	0	117

🟢 2025-01-15 15:47:30 UTC Build successful.
🟢 2025-01-15 15:47:51 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `6bcf4a6`	merge: `954efd9`	diff	diff %
ydbd size	2 251 972 592 Bytes	2 251 972 592 Bytes	0 Bytes	0.000%
ydbd stripped size	473 567 248 Bytes	473 567 248 Bytes	0 Bytes	0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

…ption

Co-authored-by: Bulat <bylatgr@gmail.com>

…alues

github-actions · 2025-01-16T09:52:41Z

⚪ 2025-01-16 09:52:40 UTC Pre-commit check linux-x86_64-release-asan for eeb94d1 has started.
⚪ 2025-01-16 09:52:52 UTC Artifacts will be uploaded here
⚪ 2025-01-16 09:55:42 UTC ya make is running...
🟡 2025-01-16 11:05:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
11729	11682	0	18	1	28

⚪ 2025-01-16 11:06:16 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-16 11:19:44 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
79 (only retried tests)	53	0	0	0	26

🟢 2025-01-16 11:19:52 UTC Build successful.
🟢 2025-01-16 11:20:19 UTC ydbd size 3.6 GiB changed* by +29.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `0fd4bda`	merge: `eeb94d1`	diff	diff %
ydbd size	3 902 763 440 Bytes	3 902 793 096 Bytes	+29.0 KiB	+0.001%
ydbd stripped size	1 362 492 272 Bytes	1 362 501 456 Bytes	+9.0 KiB	+0.001%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-01-16T09:52:44Z

⚪ 2025-01-16 09:52:43 UTC Pre-commit check linux-x86_64-relwithdebinfo for eeb94d1 has started.
⚪ 2025-01-16 09:52:56 UTC Artifacts will be uploaded here
⚪ 2025-01-16 09:55:55 UTC ya make is running...
🟡 2025-01-16 10:47:27 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
25506	22994	0	11	2380	121

⚪ 2025-01-16 10:49:35 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-16 11:01:02 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
189 (only retried tests)	69	0	1	0	119

⚪ 2025-01-16 11:01:11 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-01-16 11:12:52 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
174 (only retried tests)	55	0	0	0	119

🟢 2025-01-16 11:12:59 UTC Build successful.
🟢 2025-01-16 11:13:21 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `27eb560`	merge: `eeb94d1`	diff	diff %
ydbd size	2 252 462 632 Bytes	2 252 462 632 Bytes	0 Bytes	0.000%
ydbd stripped size	473 397 200 Bytes	473 397 200 Bytes	0 Bytes	0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-01-16T12:13:31Z

⚪ 2025-01-16 12:13:30 UTC Pre-commit check linux-x86_64-relwithdebinfo for 769c7c9 has started.
⚪ 2025-01-16 12:13:42 UTC Artifacts will be uploaded here
⚪ 2025-01-16 12:16:42 UTC ya make is running...
🟡 2025-01-16 13:10:12 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
25506	23001	0	4	2380	121

⚪ 2025-01-16 13:12:30 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-16 13:24:19 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
184 (only retried tests)	65	0	0	0	119

🟢 2025-01-16 13:24:27 UTC Build successful.
🟢 2025-01-16 13:24:48 UTC ydbd size 2.1 GiB changed* by +4.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `1b5955d`	merge: `769c7c9`	diff	diff %
ydbd size	2 252 477 168 Bytes	2 252 482 184 Bytes	+4.9 KiB	+0.000%
ydbd stripped size	473 399 760 Bytes	473 400 912 Bytes	+1.1 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-01-16T12:13:36Z

⚪ 2025-01-16 12:13:35 UTC Pre-commit check linux-x86_64-release-asan for 769c7c9 has started.
⚪ 2025-01-16 12:13:46 UTC Artifacts will be uploaded here
⚪ 2025-01-16 12:16:36 UTC ya make is running...
🟡 2025-01-16 13:15:06 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
11433	11387	0	17	3	26

⚪ 2025-01-16 13:16:04 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-16 13:36:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
75 (only retried tests)	48	0	2	2	23

⚪ 2025-01-16 13:36:26 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-16 13:47:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
51 (only retried tests)	27	0	1	0	23

🟢 2025-01-16 13:47:55 UTC Build successful.
🟢 2025-01-16 13:48:21 UTC ydbd size 3.6 GiB changed* by +9.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `1b5955d`	merge: `769c7c9`	diff	diff %
ydbd size	3 902 828 488 Bytes	3 902 837 736 Bytes	+9.0 KiB	+0.000%
ydbd stripped size	1 362 513 232 Bytes	1 362 516 944 Bytes	+3.6 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

…db-platform#13247) Co-authored-by: Bulat <bylatgr@gmail.com>

pnv1 added area/cli CLI related issues improvement labels Jan 9, 2025

pnv1 self-assigned this Jan 9, 2025

pnv1 requested a review from a team as a code owner January 9, 2025 17:25

github-actions bot added new-feature and removed improvement labels Jan 9, 2025

pnv1 requested a review from Gazizonoki January 9, 2025 17:27

Gazizonoki reviewed Jan 14, 2025

View reviewed changes

ydb/public/lib/ydb_cli/common/csv_parser.cpp Outdated Show resolved Hide resolved

ydb/public/lib/ydb_cli/import/import.cpp Show resolved Hide resolved

pnv1 force-pushed the suggest-create-table-from-csv-file branch from c531c7c to d2ddefe Compare January 15, 2025 14:20

pnv1 and others added 16 commits January 16, 2025 12:47

Generate and execute CREATE TABLE request by --suggest-create-table o…

5bcdd93

…ption

Uncomment hiding progress status

3bfaabe

Only suggest create table query text when table does not exist

7676a54

Remove unused variables

ca31b96

Remove debug info and return types that are supported in row tables

2109917

Fix after rebase

4d619cc

Remove one redundant line break

8948b7b

Improve message text and spacing

388da0b

Fix commas in comment

7311709

Simplify create table text generation due to single file processing

4db62b7

Return bool column support

ff0b59f

Update comment

8355a1a

Remove unused option RowsToAnalyze

b962384

Remove unused include

f631b32

Update CHAMGELOG

e993ee8

Update ydb/public/lib/ydb_cli/common/csv_parser.cpp

0b1b5cf

Co-authored-by: Bulat <bylatgr@gmail.com>

pnv1 and others added 3 commits January 16, 2025 12:48

Update ydb/public/lib/ydb_cli/common/csv_parser.cpp

7f6c455

Co-authored-by: Bulat <bylatgr@gmail.com>

Update ydb/public/lib/ydb_cli/common/csv_parser.cpp

a2f14cc

Co-authored-by: Bulat <bylatgr@gmail.com>

Add tests on TPossibleTypes, remove unused types, fix negative Uint v…

340a13f

…alues

pnv1 force-pushed the suggest-create-table-from-csv-file branch from c05f2b9 to 340a13f Compare January 16, 2025 09:48

Replace static const with constexpr

695bc02

pnv1 enabled auto-merge (squash) January 17, 2025 09:20

Gazizonoki approved these changes Jan 17, 2025

View reviewed changes

pnv1 merged commit 83627e0 into ydb-platform:main Jan 17, 2025
12 checks passed

the-ancient-1 pushed a commit to the-ancient-1/ydb that referenced this pull request Jan 21, 2025

Suggest create table text on scheme error during import file csv (y…

847c536

…db-platform#13247) Co-authored-by: Bulat <bylatgr@gmail.com>

azevaykin pushed a commit to azevaykin/ydb that referenced this pull request Feb 3, 2025

Suggest create table text on scheme error during import file csv (y…

f0b4933

…db-platform#13247) Co-authored-by: Bulat <bylatgr@gmail.com>

pnv1 deleted the suggest-create-table-from-csv-file branch April 17, 2025 09:46

Suggest create table text on scheme error during import file csv #13247

Suggest create table text on scheme error during import file csv #13247

Uh oh!

Conversation

pnv1 commented Jan 9, 2025

Changelog entry

Changelog category

Uh oh!

github-actions bot commented Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Suggest create table text on scheme error during `import file csv` #13247

Suggest create table text on scheme error during `import file csv` #13247

github-actions bot commented Jan 9, 2025 •

edited

Loading

github-actions bot commented Jan 9, 2025 •

edited

Loading

github-actions bot commented Jan 15, 2025 •

edited

Loading

github-actions bot commented Jan 15, 2025 •

edited

Loading

github-actions bot commented Jan 16, 2025 •

edited

Loading

github-actions bot commented Jan 16, 2025 •

edited

Loading

github-actions bot commented Jan 16, 2025 •

edited

Loading

github-actions bot commented Jan 16, 2025 •

edited

Loading