[ydbd_slice] add confirmation before ydbd build (#13241)

Author: shmel1k

ydb/tools/ydbd_slice/__init__.py

@@ -614,7 +614,12 @@ def _run(args):
     mode.set_defaults(handler=_run)
 
 
-def dispatch_run(func, args, walle_provider):
+def dispatch_run(func, args, walle_provider, need_confirmation=False):
+    if need_confirmation and not __confirm(args):
+        print("Aborting slice installation/formatting")
+        # TODO(shmel1k@): add confirmation message.
+        return
+
     logger.debug("run func '%s' with cmd args is '%s'", func.__name__, args)
 
     cluster_details = safe_load_cluster_details(args.cluster, walle_provider)
@@ -654,9 +659,33 @@ def dispatch_run(func, args, walle_provider):
         # shutil.rmtree(temp_dir)
 
 
+def __confirm(args) -> bool:
+    if hasattr(args, "confirm") and args.confirm:
+        return True
+
+    confirm = input(
+        "You are trying to setup or format slice. Note, that during setup or format all previous data will be erased.\n"
+        + "Press [y] to continue or [n] to abort installation/formatting: "
+    )
+    for i in range(0, 3):
+        lw = confirm.strip().lower()
+        if lw == "n":
+            return False
+        if lw == "y":
+            return True
+        confirm = input("Enter [y] or [n]")
+    lw = confirm.strip().lower()
+    if lw == "n":
+        return False
+    if lw == "y":
+        return True
+
+    return False
+
+
 def add_install_mode(modes, walle_provider):
     def _run(args):
-        dispatch_run(handlers.Slice.slice_install, args, walle_provider)
+        dispatch_run(handlers.Slice.slice_install, args, walle_provider, True)
 
     mode = modes.add_parser(
         "install",
@@ -701,7 +730,6 @@ def _run(args):
 
 def add_update_raw_configs(modes, walle_provider):
     def _run(args):
-
         dispatch_run(lambda self: handlers.Slice.slice_update_raw_configs(self, args.raw_cfg), args, walle_provider)
 
     mode = modes.add_parser(
@@ -750,7 +778,7 @@ def _run(args):
 
 def add_clear_mode(modes, walle_provider):
     def _run(args):
-        dispatch_run(handlers.Slice.slice_clear, args, walle_provider)
+        dispatch_run(handlers.Slice.slice_clear, args, walle_provider, True)
 
     mode = modes.add_parser(
         "clear",
@@ -771,7 +799,7 @@ def _run(args):
 
 def add_format_mode(modes, walle_provider):
     def _run(args):
-        dispatch_run(handlers.Slice.slice_format, args, walle_provider)
+        dispatch_run(handlers.Slice.slice_format, args, walle_provider, True)
 
     mode = modes.add_parser(
         "format",

ydb/tools/ydbd_slice/handlers.py

@@ -65,18 +65,11 @@ def _format_drives(self):
         self.nodes._check_async_execution(tasks)
 
     def slice_format(self):
-        if not self.__confirm():
-            print("Aborting slice formatting")
-            return
         self.slice_stop()
         self._format_drives()
         self.slice_start()
 
     def slice_clear(self):
-        if not self.__confirm():
-            print("Aborting slice formatting")
-            return
-
         self.slice_stop()
 
         if 'dynamic_slots' in self.components:
@@ -120,34 +113,7 @@ def _dynamic_configure(self):
             )
         )
 
-    def __confirm(self) -> bool:
-        if self.components['confirm']:
-            return True
-
-        confirm = input(
-            "You are trying to setup or format slice. Note, that during setup or format all previous data will be erased.\n"
-            + "Press [y] to continue or [n] to abort installation/formatting: "
-        )
-        for i in range(0, 3):
-            lw = confirm.strip().lower()
-            if lw == "n":
-                return False
-            if lw == "y":
-                return True
-            confirm = input("Enter [y] or [n]")
-        lw = confirm.strip().lower()
-        if lw == "n":
-            return False
-        if lw == "y":
-            return True
-
-        return False
-
     def slice_install(self):
-        if not self.__confirm():
-            print("Aborting installation")
-            return
-
         self._ensure_berkanavt_exists()
         self.slice_stop()