Skip to content

Node TNodeLocation processing to NodeWarden in order to reduce CPU consumption #12776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

alexvru
Copy link
Collaborator

@alexvru alexvru commented Dec 19, 2024

Changelog entry

Node TNodeLocation processing to NodeWarden in order to reduce CPU consumption

Changelog category

  • Performance improvement

Additional information

NodeLocation calculation has been moved from multiple (hundreds or thousands) DS proxies into single NodeWarden.

Copy link

github-actions bot commented Dec 19, 2024

2024-12-19 11:41:25 UTC Pre-commit check linux-x86_64-release-asan for 6e37da6 has started.
2024-12-19 11:42:00 UTC Artifacts will be uploaded here
2024-12-19 11:45:35 UTC ya make is running...
🟡 2024-12-19 13:21:39 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13731 13625 0 50 5 51

🟢 2024-12-19 13:23:39 UTC Build successful.
🟢 2024-12-19 13:24:06 UTC ydbd size 3.6 GiB changed* by -33.3 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 2660174 merge: 6e37da6 diff diff %
ydbd size 3 900 196 312 Bytes 3 865 267 016 Bytes -33.3 MiB -0.896%
ydbd stripped size 1 366 192 176 Bytes 1 350 331 088 Bytes -15.1 MiB -1.161%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 19, 2024

2024-12-19 11:44:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6e37da6 has started.
2024-12-19 11:44:24 UTC Artifacts will be uploaded here
2024-12-19 11:47:28 UTC ya make is running...
🟡 2024-12-19 12:53:56 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20956 19350 0 8 1479 119

2024-12-19 12:56:07 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-19 13:15:41 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
236 (only retried tests) 126 0 0 0 110

🟢 2024-12-19 13:15:49 UTC Build successful.
🟢 2024-12-19 13:16:08 UTC ydbd size 2.1 GiB changed* by -19.2 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 2660174 merge: 6e37da6 diff diff %
ydbd size 2 254 677 792 Bytes 2 234 580 224 Bytes -19.2 MiB -0.891%
ydbd stripped size 483 584 560 Bytes 477 796 816 Bytes -5.5 MiB -1.197%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru enabled auto-merge (squash) December 19, 2024 14:37
@alexvru alexvru merged commit 8596497 into ydb-platform:main Dec 19, 2024
11 checks passed
@alexvru alexvru deleted the dsproxy/move-location-processing-to-nodewarden branch December 19, 2024 17:00
alexvru added a commit to alexvru/ydb that referenced this pull request Dec 19, 2024
kruall pushed a commit to kruall/ydb that referenced this pull request Apr 10, 2025
kruall pushed a commit to kruall/ydb that referenced this pull request Apr 10, 2025
kruall pushed a commit to kruall/ydb that referenced this pull request Apr 10, 2025
kruall pushed a commit to kruall/ydb that referenced this pull request Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants