Skip to content

Conversation

@GrigoriyPA
Copy link
Collaborator

@GrigoriyPA GrigoriyPA commented Dec 25, 2024

Changelog entry

Fixed empty error from CMS create tenant request (issue #12973)

Changelog category

  • Bugfix

Additional information

New error response:

status: BAD_REQUEST
issues {
  message: "Database path cannot be empty or root"
  severity: 1
}

@GrigoriyPA GrigoriyPA requested a review from pixcc December 25, 2024 10:27
@GrigoriyPA GrigoriyPA added the area/core YDB Core issues label Dec 25, 2024
@github-actions
Copy link

github-actions bot commented Dec 25, 2024

2024-12-25 10:29:57 UTC Pre-commit check linux-x86_64-release-asan for b0f54b4 has started.
2024-12-25 10:30:10 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Dec 25, 2024

2024-12-25 10:32:16 UTC Pre-commit check linux-x86_64-release-asan for 1f29617 has started.
2024-12-25 10:32:28 UTC Artifacts will be uploaded here
2024-12-25 10:35:31 UTC ya make is running...
2024-12-25 10:36:47 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Dec 25, 2024

2024-12-25 10:34:32 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1f29617 has started.
2024-12-25 10:34:45 UTC Artifacts will be uploaded here
2024-12-25 10:36:45 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Dec 25, 2024

2024-12-25 10:38:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for c146111 has started.
2024-12-25 10:38:15 UTC Artifacts will be uploaded here
2024-12-25 10:41:09 UTC ya make is running...
🟡 2024-12-25 11:40:38 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30607 27646 0 3 2837 121

2024-12-25 11:43:12 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-25 11:55:17 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
182 (only retried tests) 63 0 1 1 117

2024-12-25 11:55:32 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-25 12:07:25 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
170 (only retried tests) 52 0 1 0 117

🟢 2024-12-25 12:07:35 UTC Build successful.
🟢 2024-12-25 12:07:55 UTC ydbd size 2.1 GiB changed* by -16 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: d0920bc merge: c146111 diff diff %
ydbd size 2 226 054 440 Bytes 2 226 054 424 Bytes -16 Bytes -0.000%
ydbd stripped size 467 407 152 Bytes 467 407 152 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Dec 25, 2024

2024-12-25 10:38:12 UTC Pre-commit check linux-x86_64-release-asan for c146111 has started.
2024-12-25 10:38:18 UTC Artifacts will be uploaded here
2024-12-25 10:41:08 UTC ya make is running...
🟡 2024-12-25 11:43:46 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13700 13623 0 16 5 56

🟢 2024-12-25 11:44:59 UTC Build successful.
🟢 2024-12-25 11:45:24 UTC ydbd size 3.6 GiB changed* by -160 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: d0920bc merge: c146111 diff diff %
ydbd size 3 864 670 008 Bytes 3 864 669 848 Bytes -160 Bytes -0.000%
ydbd stripped size 1 347 522 592 Bytes 1 347 522 528 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA added the rebase-and-check Rebase PR with the current base branch and check label Dec 25, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Dec 25, 2024
@github-actions
Copy link

github-actions bot commented Dec 25, 2024

2024-12-25 12:31:31 UTC Pre-commit check linux-x86_64-relwithdebinfo for ca5c087 has started.
2024-12-25 12:32:02 UTC Artifacts will be uploaded here
2024-12-25 12:34:54 UTC ya make is running...
🟡 2024-12-25 14:06:24 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30631 27498 0 6 3064 63

2024-12-25 14:09:18 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-25 14:22:29 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
356 (only retried tests) 226 0 0 7 123

🟢 2024-12-25 14:22:38 UTC Build successful.
🟢 2024-12-25 14:23:03 UTC ydbd size 2.1 GiB changed* by +9.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 65567d3 merge: ca5c087 diff diff %
ydbd size 2 225 951 840 Bytes 2 225 961 296 Bytes +9.2 KiB +0.000%
ydbd stripped size 467 346 384 Bytes 467 348 688 Bytes +2.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Dec 25, 2024

2024-12-25 12:31:31 UTC Pre-commit check linux-x86_64-release-asan for ca5c087 has started.
2024-12-25 12:33:52 UTC Artifacts will be uploaded here
2024-12-25 12:36:57 UTC ya make is running...
🟡 2024-12-25 14:18:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13726 13639 0 26 4 57

2024-12-25 14:20:06 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-25 14:32:50 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
144 (only retried tests) 91 0 2 1 50

2024-12-25 14:32:58 UTC ya make is running... (failed tests rerun, try 3)
🟡 2024-12-25 14:45:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
100 (only retried tests) 50 0 1 0 49

🟢 2024-12-25 14:45:14 UTC Build successful.
🟢 2024-12-25 14:45:45 UTC ydbd size 3.6 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 57f6f63 merge: ca5c087 diff diff %
ydbd size 3 864 420 008 Bytes 3 864 419 912 Bytes -96 Bytes -0.000%
ydbd stripped size 1 347 306 480 Bytes 1 347 306 480 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA merged commit 4472125 into ydb-platform:main Dec 25, 2024
17 of 18 checks passed
@GrigoriyPA GrigoriyPA deleted the Issue-12973-empty-error-from-CMS-create-tenant-request branch December 25, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core YDB Core issues bugfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants