Skip to content

Conversation

@adameat
Copy link
Member

@adameat adameat commented Dec 17, 2024

Changelog entry

...

Changelog category

  • Improvement
  • Not for changelog (changelog entry is not required)

Additional information

improve code a little, get rid of templates and contexts

@github-actions
Copy link

github-actions bot commented Dec 17, 2024

2024-12-17 15:07:44 UTC Pre-commit check linux-x86_64-relwithdebinfo for 915432a has started.
2024-12-17 15:07:57 UTC Artifacts will be uploaded here
2024-12-17 15:11:20 UTC ya make is running...
🔴 2024-12-17 15:24:18 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Dec 17, 2024

2024-12-17 15:08:49 UTC Pre-commit check linux-x86_64-release-asan for 915432a has started.
2024-12-17 15:09:00 UTC Artifacts will be uploaded here
2024-12-17 15:12:08 UTC ya make is running...
🔴 2024-12-17 15:22:51 UTC Build failed, see the logs. Also see fail summary

@adameat adameat force-pushed the get-rid-of-template-and-context branch from 42936f8 to 7bf3e81 Compare December 18, 2024 04:41
@github-actions
Copy link

github-actions bot commented Dec 18, 2024

2024-12-18 04:45:07 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4975b26 has started.
2024-12-18 04:45:18 UTC Artifacts will be uploaded here
2024-12-18 04:48:29 UTC ya make is running...
🔴 2024-12-18 04:54:46 UTC Build failed, see the logs. Also see fail summary

@github-actions
Copy link

github-actions bot commented Dec 18, 2024

2024-12-18 04:45:56 UTC Pre-commit check linux-x86_64-release-asan for 4975b26 has started.
2024-12-18 04:46:08 UTC Artifacts will be uploaded here
2024-12-18 04:49:17 UTC ya make is running...
2024-12-18 04:58:15 UTC Check cancelled

@adameat adameat force-pushed the get-rid-of-template-and-context branch from 7bf3e81 to 55e1242 Compare December 18, 2024 04:57
@github-actions
Copy link

github-actions bot commented Dec 18, 2024

2024-12-18 04:59:53 UTC Pre-commit check linux-x86_64-release-asan for 749fca1 has started.
2024-12-18 05:00:05 UTC Artifacts will be uploaded here
2024-12-18 05:03:08 UTC ya make is running...
🟡 2024-12-18 06:21:22 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13945 13841 0 52 8 44

🟢 2024-12-18 06:22:30 UTC Build successful.
🟢 2024-12-18 06:22:53 UTC ydbd size 3.6 GiB changed* by -189.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: dffc12a merge: 749fca1 diff diff %
ydbd size 3 894 689 168 Bytes 3 894 495 080 Bytes -189.5 KiB -0.005%
ydbd stripped size 1 363 873 328 Bytes 1 363 830 288 Bytes -42.0 KiB -0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Dec 18, 2024

2024-12-18 05:02:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for 749fca1 has started.
2024-12-18 05:03:06 UTC Artifacts will be uploaded here
2024-12-18 05:06:23 UTC ya make is running...
🟡 2024-12-18 06:21:15 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30866 27920 0 2 2830 114

2024-12-18 06:23:48 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-18 06:35:36 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
161 (only retried tests) 50 0 0 1 110

🟢 2024-12-18 06:35:43 UTC Build successful.
🟢 2024-12-18 06:36:01 UTC ydbd size 2.1 GiB changed* by -86.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: dffc12a merge: 749fca1 diff diff %
ydbd size 2 253 799 152 Bytes 2 253 710 720 Bytes -86.4 KiB -0.004%
ydbd stripped size 483 054 512 Bytes 483 043 440 Bytes -10.8 KiB -0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@adameat adameat enabled auto-merge (squash) December 18, 2024 06:49
@adameat adameat requested a review from alexvru December 18, 2024 06:51
@adameat adameat merged commit 385690d into ydb-platform:main Dec 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants