Skip to content

Support tracing for long grpc stream session requests #12493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2024
Merged

Support tracing for long grpc stream session requests #12493

merged 1 commit into from
Dec 13, 2024

Conversation

UgnineSirdis
Copy link
Collaborator

Changelog entry

Stream requests are long running session requests such as topic sessions. That's why they require special handling.

  1. Long grpc streaming requests must not generate tracing sample with default settings or requests sample for database. Instead of this they must generate tracing sample of single requests inside session.
  2. Explicitly specified tracing sampling settings must generate trace sample in the same way as for usual requests
  3. Explicitly specified tracing header must be handled and produce the whole session trace as for other requests

Changelog category

  • Improvement

Additional information

...

@UgnineSirdis UgnineSirdis requested a review from a team as a code owner December 11, 2024 09:23
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2024 •
edited
Loading

⚪ 2024-12-11 09:28:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for f56de22 has started.
⚪ 2024-12-11 09:28:22 UTC Artifacts will be uploaded here
⚪ 2024-12-11 09:31:25 UTC ya make is running...
🟡 2024-12-11 10:39:44 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32641 29719 0 3 2810 109

⚪ 2024-12-11 10:42:28 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-11 10:54:33 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
652 (only retried tests) 543 0 2 0 107

⚪ 2024-12-11 10:54:43 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-11 11:06:49 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
649 (only retried tests) 540 0 2 0 107

🟢 2024-12-11 11:06:59 UTC Build successful.
🟢 2024-12-11 11:07:19 UTC ydbd size 2.1 GiB changed* by -6.3 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: e838a62 merge: f56de22 diff diff %
ydbd size 2 255 721 664 Bytes 2 249 130 624 Bytes -6.3 MiB -0.292%
ydbd stripped size 483 873 296 Bytes 482 148 496 Bytes -1.6 MiB -0.356%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2024 •
edited
Loading

⚪ 2024-12-11 09:28:25 UTC Pre-commit check linux-x86_64-release-asan for f56de22 has started.
⚪ 2024-12-11 09:28:36 UTC Artifacts will be uploaded here
⚪ 2024-12-11 09:31:38 UTC ya make is running...
🟡 2024-12-11 10:52:00 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15221 15147 0 24 4 46

🟢 2024-12-11 10:53:15 UTC Build successful.
🟢 2024-12-11 10:53:38 UTC ydbd size 3.6 GiB changed* by -11.6 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: e838a62 merge: f56de22 diff diff %
ydbd size 3 897 699 800 Bytes 3 885 558 160 Bytes -11.6 MiB -0.312%
ydbd stripped size 1 366 522 384 Bytes 1 360 716 272 Bytes -5.5 MiB -0.425%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

dcherednik
dcherednik previously approved these changes Dec 11, 2024
View reviewed changes
@UgnineSirdis UgnineSirdis force-pushed the stream-requests-tracing branch from 7c1a82a to de0230d Compare December 11, 2024 19:29
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2024 •
edited
Loading

⚪ 2024-12-11 19:31:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7013484 has started.
⚪ 2024-12-11 19:32:50 UTC Artifacts will be uploaded here
⚪ 2024-12-11 19:35:56 UTC ya make is running...
🟢 2024-12-11 20:44:24 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32643 29721 0 0 2810 112

🟢 2024-12-11 20:47:13 UTC Build successful.
🟢 2024-12-11 20:47:29 UTC ydbd size 2.1 GiB changed* by -6.3 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 974cc86 merge: 7013484 diff diff %
ydbd size 2 256 248 872 Bytes 2 249 658 096 Bytes -6.3 MiB -0.292%
ydbd stripped size 483 942 864 Bytes 482 218 128 Bytes -1.6 MiB -0.356%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2024 •
edited
Loading

⚪ 2024-12-11 19:32:04 UTC Pre-commit check linux-x86_64-release-asan for 7013484 has started.
⚪ 2024-12-11 19:32:17 UTC Artifacts will be uploaded here
⚪ 2024-12-11 19:35:28 UTC ya make is running...
🟡 2024-12-11 20:56:22 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15222 15145 0 27 6 44

🟢 2024-12-11 20:57:37 UTC Build successful.
🟢 2024-12-11 20:58:00 UTC ydbd size 3.6 GiB changed* by -11.6 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 974cc86 merge: 7013484 diff diff %
ydbd size 3 898 601 272 Bytes 3 886 459 840 Bytes -11.6 MiB -0.311%
ydbd stripped size 1 366 742 576 Bytes 1 360 936 528 Bytes -5.5 MiB -0.425%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@UgnineSirdis UgnineSirdis force-pushed the stream-requests-tracing branch from de0230d to cf974b6 Compare December 13, 2024 13:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2024 •
edited
Loading

⚪ 2024-12-13 13:46:47 UTC Pre-commit check linux-x86_64-release-asan for 91d19cf has started.
⚪ 2024-12-13 13:46:58 UTC Artifacts will be uploaded here
⚪ 2024-12-13 13:50:18 UTC ya make is running...
🟡 2024-12-13 15:13:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15243 15175 0 19 4 45

🟢 2024-12-13 15:14:28 UTC Build successful.
🟢 2024-12-13 15:14:52 UTC ydbd size 3.6 GiB changed* by -11.8 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 65fee37 merge: 91d19cf diff diff %
ydbd size 3 902 389 072 Bytes 3 890 055 664 Bytes -11.8 MiB -0.316%
ydbd stripped size 1 367 950 576 Bytes 1 362 033 744 Bytes -5.6 MiB -0.433%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2024 •
edited
Loading

⚪ 2024-12-13 13:46:59 UTC Pre-commit check linux-x86_64-relwithdebinfo for 91d19cf has started.
⚪ 2024-12-13 13:47:09 UTC Artifacts will be uploaded here
⚪ 2024-12-13 13:50:12 UTC ya make is running...
🟡 2024-12-13 14:57:51 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32666 29723 0 2 2823 118

⚪ 2024-12-13 15:00:28 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-13 15:12:03 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
709 (only retried tests) 600 0 0 0 109

🟢 2024-12-13 15:12:12 UTC Build successful.
🟢 2024-12-13 15:12:29 UTC ydbd size 2.1 GiB changed* by -6.3 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 65fee37 merge: 91d19cf diff diff %
ydbd size 2 258 126 448 Bytes 2 251 490 544 Bytes -6.3 MiB -0.294%
ydbd stripped size 484 291 792 Bytes 482 534 544 Bytes -1.7 MiB -0.363%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@UgnineSirdis UgnineSirdis merged commit cd6e4b4 into ydb-platform:main Dec 13, 2024
10 checks passed
This was referenced Dec 18, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Dec 25, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Dec 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nshestakov nshestakov nshestakov approved these changes

@serbel324 serbel324 serbel324 approved these changes

@dcherednik dcherednik dcherednik left review comments

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@UgnineSirdis @dcherednik @nshestakov @serbel324