Skip to content

YQL-17371: Fix bytea output in pgrun #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 24, 2024

Conversation

marsaly79
Copy link
Contributor

No description provided.

@marsaly79 marsaly79 requested a review from a team as a code owner January 24, 2024 00:17
Copy link

github-actions bot commented Jan 24, 2024

2024-01-24 15:12:26 UTC Pre-commit check for 60e31ef has started.
2024-01-24 15:12:28 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-24 15:15:01 UTC Build successful.
2024-01-24 15:15:10 UTC Tests are running...
🔴 2024-01-24 16:57:29 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60095 50833 0 6 9237 19

Copy link

github-actions bot commented Jan 24, 2024

2024-01-24 15:18:06 UTC Pre-commit check for 60e31ef has started.
2024-01-24 15:18:08 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-24 15:21:04 UTC Build successful.
2024-01-24 15:21:18 UTC Tests are running...
🔴 2024-01-24 17:05:51 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15935 15825 0 28 59 23

@@ -804,6 +812,64 @@ std::string FormatCell(const TString& data, const TColumn& column, size_t index,
return fmt::format("{0}{1:<{2}}", delim, data, column.Width);
}

// from postgres/src/include/utils/builtins.h
extern "C" ui64 hex_encode(const char *src, size_t len, char *dst);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explicit header?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or, better, add such function to pg_wrapper/interface/utils

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explicit header?

original PG's header pulls in tons of PG staff we don't need in pgrun

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or, better, add such function to pg_wrapper/interface/utils

You mean moving the declaration of hex_encode() into pg_wrapper/interface/utils.h ?

Copy link
Collaborator

@vitstn vitstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix comments

@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
@vitstn vitstn mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants