-
Notifications
You must be signed in to change notification settings - Fork 638
YQL-17371: Fix bytea output in pgrun #1248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YQL-17371: Fix bytea output in pgrun #1248
Conversation
⚪
|
⚪
|
@@ -804,6 +812,64 @@ std::string FormatCell(const TString& data, const TColumn& column, size_t index, | |||
return fmt::format("{0}{1:<{2}}", delim, data, column.Width); | |||
} | |||
|
|||
// from postgres/src/include/utils/builtins.h | |||
extern "C" ui64 hex_encode(const char *src, size_t len, char *dst); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
explicit header?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or, better, add such function to pg_wrapper/interface/utils
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
explicit header?
original PG's header pulls in tons of PG staff we don't need in pgrun
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or, better, add such function to pg_wrapper/interface/utils
You mean moving the declaration of hex_encode() into pg_wrapper/interface/utils.h ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix comments
No description provided.