Skip to content

Prepare & execute topics in BufferWriteActor #12464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Dec 16, 2024

Conversation

dahbka-lis
Copy link
Member

Changelog entry

Add support for topic operations in BufferWriteActor with enabled OLTP sink.

...

Changelog category

  • Improvement

Additional information

...

@dahbka-lis dahbka-lis requested a review from a team as a code owner December 10, 2024 13:12
Copy link

github-actions bot commented Dec 10, 2024

2024-12-10 13:23:28 UTC Pre-commit check linux-x86_64-release-asan for 2403c5b has started.
2024-12-10 13:23:40 UTC Artifacts will be uploaded here
2024-12-10 13:26:35 UTC ya make is running...
🟡 2024-12-10 14:34:11 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13379 13302 0 28 5 44

🟢 2024-12-10 14:35:24 UTC Build successful.
🟡 2024-12-10 14:35:48 UTC ydbd size 3.6 GiB changed* by +156.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 137077a merge: 2403c5b diff diff %
ydbd size 3 895 711 416 Bytes 3 895 871 240 Bytes +156.1 KiB +0.004%
ydbd stripped size 1 366 028 528 Bytes 1 366 071 408 Bytes +41.9 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 10, 2024

2024-12-10 13:24:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2403c5b has started.
2024-12-10 13:24:34 UTC Artifacts will be uploaded here
2024-12-10 13:27:36 UTC ya make is running...
🟡 2024-12-10 14:30:04 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
21103 19571 0 16 1403 113

2024-12-10 14:32:34 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-10 14:44:01 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
727 (only retried tests) 619 0 0 0 108

🟢 2024-12-10 14:44:11 UTC Build successful.
🟢 2024-12-10 14:44:29 UTC ydbd size 2.1 GiB changed* by +82.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 137077a merge: 2403c5b diff diff %
ydbd size 2 254 497 152 Bytes 2 254 581 968 Bytes +82.8 KiB +0.004%
ydbd stripped size 483 694 480 Bytes 483 707 984 Bytes +13.2 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 13, 2024

2024-12-13 08:51:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for 40e9677 has started.
2024-12-13 08:51:21 UTC Artifacts will be uploaded here
2024-12-13 08:54:18 UTC ya make is running...
🟡 2024-12-13 09:48:49 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
21123 19600 0 4 1409 110

2024-12-13 09:50:32 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-13 10:01:59 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
681 (only retried tests) 574 0 0 0 107

🟢 2024-12-13 10:02:08 UTC Build successful.
🟢 2024-12-13 10:02:26 UTC ydbd size 2.1 GiB changed* by +80.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7782482 merge: 40e9677 diff diff %
ydbd size 2 256 566 000 Bytes 2 256 648 344 Bytes +80.4 KiB +0.004%
ydbd stripped size 484 005 744 Bytes 484 018 352 Bytes +12.3 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 13, 2024

2024-12-13 08:51:28 UTC Pre-commit check linux-x86_64-release-asan for 40e9677 has started.
2024-12-13 08:51:39 UTC Artifacts will be uploaded here
2024-12-13 08:54:35 UTC ya make is running...
🟡 2024-12-13 10:02:12 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13406 13335 0 20 4 47

🟢 2024-12-13 10:03:18 UTC Build successful.
🟡 2024-12-13 10:03:42 UTC ydbd size 3.6 GiB changed* by +152.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 7782482 merge: 40e9677 diff diff %
ydbd size 3 899 123 120 Bytes 3 899 279 712 Bytes +152.9 KiB +0.004%
ydbd stripped size 1 366 840 144 Bytes 1 366 883 536 Bytes +42.4 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

nikvas0
nikvas0 previously approved these changes Dec 13, 2024
Copy link

github-actions bot commented Dec 13, 2024

2024-12-13 14:24:54 UTC Pre-commit check linux-x86_64-release-asan for 2d587ca has started.
2024-12-13 14:25:05 UTC Artifacts will be uploaded here
2024-12-13 14:28:01 UTC ya make is running...
2024-12-13 14:29:35 UTC Check cancelled

Copy link

github-actions bot commented Dec 13, 2024

2024-12-13 14:25:00 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2d587ca has started.
2024-12-13 14:25:11 UTC Artifacts will be uploaded here
2024-12-13 14:28:07 UTC ya make is running...
2024-12-13 14:29:33 UTC Check cancelled

Copy link

github-actions bot commented Dec 13, 2024

2024-12-13 14:31:03 UTC Pre-commit check linux-x86_64-release-asan for affd499 has started.
2024-12-13 14:31:09 UTC Artifacts will be uploaded here
2024-12-13 14:34:03 UTC ya make is running...
🟡 2024-12-13 15:42:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13414 13332 0 22 15 45

🟢 2024-12-13 15:43:28 UTC Build successful.
🟡 2024-12-13 15:43:56 UTC ydbd size 3.6 GiB changed* by +213.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 7f6d8cc merge: affd499 diff diff %
ydbd size 3 902 402 512 Bytes 3 902 621 016 Bytes +213.4 KiB +0.006%
ydbd stripped size 1 367 953 072 Bytes 1 368 015 984 Bytes +61.4 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 13, 2024

2024-12-13 14:31:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for affd499 has started.
2024-12-13 14:32:02 UTC Artifacts will be uploaded here
2024-12-13 14:35:08 UTC ya make is running...
🟡 2024-12-13 15:33:55 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
21183 19655 0 3 1410 115

2024-12-13 15:35:45 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-13 15:47:44 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
797 (only retried tests) 688 0 0 1 108

🟢 2024-12-13 15:47:55 UTC Build successful.
🟡 2024-12-13 15:48:14 UTC ydbd size 2.1 GiB changed* by +107.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 7f6d8cc merge: affd499 diff diff %
ydbd size 2 258 133 992 Bytes 2 258 244 216 Bytes +107.6 KiB +0.005%
ydbd stripped size 484 292 560 Bytes 484 312 528 Bytes +19.5 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nikvas0 nikvas0 merged commit 8efacf9 into ydb-platform:main Dec 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants