Skip to content

less query id labels #12427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 17, 2024
Merged

less query id labels #12427

merged 10 commits into from
Dec 17, 2024

Conversation

uzhastik
Copy link
Collaborator

@uzhastik uzhastik commented Dec 9, 2024

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

Copy link

github-actions bot commented Dec 9, 2024

2024-12-09 16:40:11 UTC Pre-commit check linux-x86_64-release-asan for c1e6d45 has started.
2024-12-09 16:40:49 UTC Artifacts will be uploaded here
2024-12-09 16:44:54 UTC ya make is running...
🟡 2024-12-09 17:51:06 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13001 12918 0 30 8 45

🟢 2024-12-09 17:52:18 UTC Build successful.
🟢 2024-12-09 17:52:53 UTC ydbd size 4.9 GiB changed* by -18.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: c146758 merge: c1e6d45 diff diff %
ydbd size 5 305 433 960 Bytes 5 305 414 920 Bytes -18.6 KiB -0.000%
ydbd stripped size 1 365 506 928 Bytes 1 365 506 096 Bytes -832 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 9, 2024

2024-12-09 16:41:45 UTC Pre-commit check linux-x86_64-relwithdebinfo for c1e6d45 has started.
2024-12-09 16:41:57 UTC Artifacts will be uploaded here
2024-12-09 16:45:03 UTC ya make is running...
🟡 2024-12-09 17:46:23 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30171 27337 0 4 2720 110

2024-12-09 17:49:00 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-09 18:00:42 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
686 (only retried tests) 576 0 2 1 107

2024-12-09 18:00:53 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-09 18:12:41 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
629 (only retried tests) 522 0 2 0 105

🟢 2024-12-09 18:12:50 UTC Build successful.
🟢 2024-12-09 18:13:12 UTC ydbd size 2.5 GiB changed* by -9.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: c146758 merge: c1e6d45 diff diff %
ydbd size 2 699 240 416 Bytes 2 699 230 656 Bytes -9.5 KiB -0.000%
ydbd stripped size 483 482 768 Bytes 483 482 448 Bytes -320 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 9, 2024

2024-12-09 20:22:00 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7cec66e has started.
2024-12-09 20:22:12 UTC Artifacts will be uploaded here
2024-12-09 20:25:23 UTC ya make is running...
🟡 2024-12-09 21:28:06 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30174 27340 0 2 2720 112

2024-12-09 21:30:34 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-09 21:42:13 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
636 (only retried tests) 529 0 0 1 106

🟢 2024-12-09 21:42:22 UTC Build successful.
🟢 2024-12-09 21:42:41 UTC ydbd size 2.5 GiB changed* by -9.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: e566060 merge: 7cec66e diff diff %
ydbd size 2 690 598 032 Bytes 2 690 588 288 Bytes -9.5 KiB -0.000%
ydbd stripped size 483 500 624 Bytes 483 500 304 Bytes -320 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 9, 2024

2024-12-09 20:22:16 UTC Pre-commit check linux-x86_64-release-asan for 7cec66e has started.
2024-12-09 20:22:27 UTC Artifacts will be uploaded here
2024-12-09 20:25:35 UTC ya make is running...
🟡 2024-12-09 21:38:15 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13003 12927 0 25 7 44

🟢 2024-12-09 21:39:20 UTC Build successful.
🟢 2024-12-09 21:39:50 UTC ydbd size 4.9 GiB changed* by -18.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: e566060 merge: 7cec66e diff diff %
ydbd size 5 291 162 304 Bytes 5 291 143 248 Bytes -18.6 KiB -0.000%
ydbd stripped size 1 365 545 552 Bytes 1 365 544 720 Bytes -832 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@uzhastik uzhastik marked this pull request as ready for review December 9, 2024 21:40
@uzhastik uzhastik requested a review from a team as a code owner December 9, 2024 21:40
Copy link

github-actions bot commented Dec 10, 2024

2024-12-10 21:21:43 UTC Pre-commit check linux-x86_64-release-asan for 532f96c has started.
2024-12-10 21:21:55 UTC Artifacts will be uploaded here
2024-12-10 21:24:49 UTC ya make is running...
🟡 2024-12-10 22:24:31 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13031 12958 0 18 12 43

🟢 2024-12-10 22:25:34 UTC Build successful.
🟢 2024-12-10 22:25:57 UTC ydbd size 3.6 GiB changed* by -8.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 9e60c00 merge: 532f96c diff diff %
ydbd size 3 897 501 584 Bytes 3 897 492 832 Bytes -8.5 KiB -0.000%
ydbd stripped size 1 366 440 144 Bytes 1 366 439 568 Bytes -576 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 10, 2024

2024-12-10 21:21:57 UTC Pre-commit check linux-x86_64-relwithdebinfo for 532f96c has started.
2024-12-10 21:22:08 UTC Artifacts will be uploaded here
2024-12-10 21:25:15 UTC ya make is running...
🟡 2024-12-10 22:25:22 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30226 27309 0 66 2729 122

2024-12-10 22:27:51 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-10 22:43:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
777 (only retried tests) 589 0 67 1 120

2024-12-10 22:43:23 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-10 22:57:59 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
761 (only retried tests) 575 0 66 1 119

🟢 2024-12-10 22:58:10 UTC Build successful.
🟢 2024-12-10 22:58:30 UTC ydbd size 2.1 GiB changed* by -5.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 9e60c00 merge: 532f96c diff diff %
ydbd size 2 255 607 112 Bytes 2 255 601 592 Bytes -5.4 KiB -0.000%
ydbd stripped size 483 846 032 Bytes 483 845 840 Bytes -192 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 12, 2024

2024-12-12 15:46:51 UTC Pre-commit check linux-x86_64-release-asan for 0d1631c has started.
2024-12-12 15:47:02 UTC Artifacts will be uploaded here
2024-12-12 15:49:56 UTC ya make is running...
🟡 2024-12-12 16:53:27 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13045 12965 0 27 9 44

🟢 2024-12-12 16:54:32 UTC Build successful.
🟢 2024-12-12 16:54:56 UTC ydbd size 3.6 GiB changed* by +4.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 46a0f52 merge: 0d1631c diff diff %
ydbd size 3 899 037 200 Bytes 3 899 041 360 Bytes +4.1 KiB +0.000%
ydbd stripped size 1 366 820 944 Bytes 1 366 823 056 Bytes +2.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 12, 2024

2024-12-12 15:47:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0d1631c has started.
2024-12-12 15:48:10 UTC Artifacts will be uploaded here
2024-12-12 15:51:07 UTC ya make is running...
🟡 2024-12-12 16:49:03 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30034 27089 0 10 2822 113

2024-12-12 16:51:33 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-12 17:03:39 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
746 (only retried tests) 638 0 1 0 107

2024-12-12 17:03:49 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-12 17:15:31 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
718 (only retried tests) 610 0 1 0 107

🟢 2024-12-12 17:15:40 UTC Build successful.
🟢 2024-12-12 17:16:01 UTC ydbd size 2.1 GiB changed* by +1008 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 46a0f52 merge: 0d1631c diff diff %
ydbd size 2 256 526 456 Bytes 2 256 527 464 Bytes +1008 Bytes +0.000%
ydbd stripped size 483 997 040 Bytes 483 997 744 Bytes +704 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 12, 2024

2024-12-12 18:04:32 UTC Pre-commit check linux-x86_64-relwithdebinfo for a25138b has started.
2024-12-12 18:04:44 UTC Artifacts will be uploaded here
2024-12-12 18:07:48 UTC ya make is running...
2024-12-12 18:22:23 UTC Check cancelled

Copy link

github-actions bot commented Dec 12, 2024

2024-12-12 18:04:42 UTC Pre-commit check linux-x86_64-release-asan for a25138b has started.
2024-12-12 18:04:56 UTC Artifacts will be uploaded here
2024-12-12 18:07:58 UTC ya make is running...
2024-12-12 18:22:37 UTC Check cancelled

Copy link

github-actions bot commented Dec 12, 2024

2024-12-12 18:24:21 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5fb17b0 has started.
2024-12-12 18:24:32 UTC Artifacts will be uploaded here
2024-12-12 18:27:25 UTC ya make is running...
🟡 2024-12-12 19:22:21 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30034 27087 0 12 2822 113

2024-12-12 19:24:48 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-12 19:36:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
747 (only retried tests) 638 0 1 0 108

2024-12-12 19:36:31 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-12 19:47:54 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
719 (only retried tests) 610 0 1 0 108

🟢 2024-12-12 19:48:03 UTC Build successful.
🟢 2024-12-12 19:48:23 UTC ydbd size 2.1 GiB changed* by +944 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 9c831b2 merge: 5fb17b0 diff diff %
ydbd size 2 256 585 080 Bytes 2 256 586 024 Bytes +944 Bytes +0.000%
ydbd stripped size 484 008 560 Bytes 484 009 200 Bytes +640 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 12, 2024

2024-12-12 18:25:06 UTC Pre-commit check linux-x86_64-release-asan for 5fb17b0 has started.
2024-12-12 18:25:17 UTC Artifacts will be uploaded here
2024-12-12 18:28:16 UTC ya make is running...
🟡 2024-12-12 19:28:51 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13045 12977 0 20 6 42

🟢 2024-12-12 19:29:54 UTC Build successful.
🟢 2024-12-12 19:30:20 UTC ydbd size 3.6 GiB changed* by +4.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 9c831b2 merge: 5fb17b0 diff diff %
ydbd size 3 899 143 392 Bytes 3 899 147 600 Bytes +4.1 KiB +0.000%
ydbd stripped size 1 366 849 872 Bytes 1 366 852 048 Bytes +2.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 13, 2024

2024-12-13 13:07:08 UTC Pre-commit check linux-x86_64-relwithdebinfo for e25f0e0 has started.
2024-12-13 13:07:47 UTC Artifacts will be uploaded here
2024-12-13 13:11:15 UTC ya make is running...
🟡 2024-12-13 14:04:10 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30258 27314 0 6 2823 115

2024-12-13 14:06:36 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-13 14:18:05 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
701 (only retried tests) 590 0 2 0 109

2024-12-13 14:18:16 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-13 14:30:46 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
682 (only retried tests) 573 0 1 0 108

🟢 2024-12-13 14:30:55 UTC Build successful.
🟢 2024-12-13 14:31:10 UTC ydbd size 2.1 GiB changed* by +2.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ee3d7ef merge: e25f0e0 diff diff %
ydbd size 2 258 128 192 Bytes 2 258 130 304 Bytes +2.1 KiB +0.000%
ydbd stripped size 484 292 176 Bytes 484 293 072 Bytes +896 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 13, 2024

2024-12-13 11:05:39 UTC Pre-commit check linux-x86_64-release-asan for e25f0e0 has started.
2024-12-13 11:05:51 UTC Artifacts will be uploaded here
2024-12-13 11:08:46 UTC ya make is running...
🟡 2024-12-13 12:24:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13049 12989 0 14 4 42

🟢 2024-12-13 12:25:54 UTC Build successful.
🟢 2024-12-13 12:26:16 UTC ydbd size 3.6 GiB changed* by +6.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ee3d7ef merge: e25f0e0 diff diff %
ydbd size 3 902 392 816 Bytes 3 902 399 744 Bytes +6.8 KiB +0.000%
ydbd stripped size 1 367 951 536 Bytes 1 367 954 160 Bytes +2.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

queryNameLabel = task.query_name();
queryIdLabel = queryId;
} else {
queryIdLabel = "manual";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Для аналитики думаю тоже будет полезно query_name задавать, хоть как-то графики сможем строить

queryRootCounters = queryRootCounters->GetSubgroup("query_id", queryIdLabel);
}

if (queryNameLabel) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А как оно бдует работать с пустыми метками. query_name="*", как будут отображаться запросы без имени, как '-' или еще что-то?

queryIdLabel = isStreaming ? "streaming" : "analytics";
} else {
if (isStreaming) {
// todo: sanitize query name
Copy link
Collaborator

@dorooleg dorooleg Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Нужно функцию Димы вызвать для sanitize

Copy link

github-actions bot commented Dec 17, 2024

2024-12-17 12:14:22 UTC Pre-commit check linux-x86_64-release-asan for 8aeea7e has started.
2024-12-17 12:14:33 UTC Artifacts will be uploaded here
2024-12-17 12:17:28 UTC ya make is running...
2024-12-17 12:27:47 UTC Check cancelled

Copy link

github-actions bot commented Dec 17, 2024

2024-12-17 12:15:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8aeea7e has started.
2024-12-17 12:15:38 UTC Artifacts will be uploaded here
2024-12-17 12:18:33 UTC ya make is running...
2024-12-17 12:28:12 UTC Check cancelled

Copy link

github-actions bot commented Dec 17, 2024

2024-12-17 12:30:30 UTC Pre-commit check linux-x86_64-release-asan for ccd4865 has started.
2024-12-17 12:30:34 UTC Artifacts will be uploaded here
2024-12-17 12:33:25 UTC ya make is running...
🟡 2024-12-17 13:46:13 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11915 11844 0 23 5 43

🟢 2024-12-17 13:47:12 UTC Build successful.
🟢 2024-12-17 13:47:38 UTC ydbd size 3.6 GiB changed* by +5.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 02fdbe3 merge: ccd4865 diff diff %
ydbd size 3 896 690 056 Bytes 3 896 695 256 Bytes +5.1 KiB +0.000%
ydbd stripped size 1 363 916 432 Bytes 1 363 918 864 Bytes +2.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 17, 2024

2024-12-17 12:31:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for ccd4865 has started.
2024-12-17 12:32:22 UTC Artifacts will be uploaded here
2024-12-17 12:35:58 UTC ya make is running...
🟡 2024-12-17 13:31:24 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28572 25626 0 2 2830 114

2024-12-17 13:33:50 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-17 13:45:30 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
159 (only retried tests) 50 0 0 0 109

🟢 2024-12-17 13:45:38 UTC Build successful.
🟢 2024-12-17 13:45:57 UTC ydbd size 2.1 GiB changed* by +1.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 02fdbe3 merge: ccd4865 diff diff %
ydbd size 2 255 301 336 Bytes 2 255 302 408 Bytes +1.0 KiB +0.000%
ydbd stripped size 483 132 208 Bytes 483 132 976 Bytes +768 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@uzhastik uzhastik enabled auto-merge (squash) December 17, 2024 14:23
@uzhastik uzhastik merged commit 3ad42c8 into ydb-platform:main Dec 17, 2024
10 checks passed
@uzhastik uzhastik deleted the query_id_label branch December 18, 2024 17:45
uzhastik added a commit to uzhastik/ydb that referenced this pull request Dec 18, 2024
uzhastik added a commit that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants