Skip to content

Use fallthrough and fix holder initialization #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2024
Merged

Use fallthrough and fix holder initialization #1221

merged 1 commit into from
Jan 23, 2024

Conversation

@nshestakov
Copy link
Collaborator

@nshestakov nshestakov commented Jan 23, 2024

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@github-actions
Copy link

github-actions bot commented Jan 23, 2024 •
edited
Loading

⚪ 2024-01-23 09:40:30 UTC Pre-commit check for 8ac0c42 has started.
⚪ 2024-01-23 09:40:33 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-01-23 09:42:55 UTC Build failed. see the build logs.
⚪ 2024-01-23 09:43:07 UTC Tests are running...
🔴 2024-01-23 11:41:16 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59994 47089 0 2622 9603 680

@github-actions
Copy link

github-actions bot commented Jan 23, 2024 •
edited
Loading

⚪ 2024-01-23 09:43:36 UTC Pre-commit check for 8ac0c42 has started.
⚪ 2024-01-23 09:43:39 UTC Build linux-x86_64-release-asan is running...
🔴 2024-01-23 09:46:05 UTC Build failed. see the build logs.
⚪ 2024-01-23 09:46:17 UTC Tests are running...
🔴 2024-01-23 11:49:54 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15872 12391 0 2414 394 673

@nshestakov nshestakov merged commit 8797869 into ydb-platform:main Jan 23, 2024
@nshestakov nshestakov deleted the codestyle branch January 23, 2024 14:03
@pavelvelikhov pavelvelikhov mentioned this pull request Jan 24, 2024
Merged
@FloatingCrowbar FloatingCrowbar mentioned this pull request Jan 24, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Jan 25, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 25, 2024
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Jan 25, 2024
Merged
This was referenced Jan 25, 2024
Merged
Merged
Merged
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Jan 29, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 29, 2024
Merged
@shnikd shnikd mentioned this pull request Jan 29, 2024
Merged
This was referenced Jan 29, 2024
Merged
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Jan 30, 2024
Merged
This was referenced Jan 30, 2024
Merged
Merged
Merged
Merged
@Jornydb Jornydb mentioned this pull request Jan 31, 2024
Merged
@shnikd shnikd mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 5, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 5, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 5, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 6, 2024
Closed
Merged
This was referenced Feb 6, 2024
Merged
Merged
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Feb 8, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
This was referenced Feb 12, 2024
Merged
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Feb 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexnick88 alexnick88 alexnick88 approved these changes

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nshestakov @alexnick88