Skip to content

Conversation

@rekby
Copy link
Member

@rekby rekby commented Nov 25, 2024

merge after #11892

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@github-actions
Copy link

github-actions bot commented Nov 25, 2024

2024-11-25 10:38:33 UTC Pre-commit check linux-x86_64-release-asan for 3bf3d49 has started.
2024-11-25 10:38:45 UTC Artifacts will be uploaded here
2024-11-25 10:41:22 UTC ya make is running...
🟢 2024-11-25 10:43:01 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-11-25 10:43:07 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Nov 25, 2024

2024-11-25 10:40:23 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3bf3d49 has started.
2024-11-25 10:40:35 UTC Artifacts will be uploaded here
2024-11-25 10:43:00 UTC ya make is running...
🟢 2024-11-25 10:43:05 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-11-25 10:43:10 UTC Build successful.

@github-actions
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

@github-actions
Copy link

github-actions bot commented Dec 3, 2024

2024-12-03 10:05:13 UTC Pre-commit check linux-x86_64-relwithdebinfo for c69adeb has started.
2024-12-03 10:05:24 UTC Artifacts will be uploaded here
2024-12-03 10:07:51 UTC ya make is running...
🟢 2024-12-03 10:09:12 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-12-03 10:09:17 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Dec 3, 2024

2024-12-03 10:05:37 UTC Pre-commit check linux-x86_64-release-asan for c69adeb has started.
2024-12-03 10:05:49 UTC Artifacts will be uploaded here
2024-12-03 10:08:15 UTC ya make is running...
🟢 2024-12-03 10:09:31 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-12-03 10:09:37 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Dec 3, 2024

✅ Documentation build

Revision built successfully
Revision preview link

@rekby rekby marked this pull request as ready for review December 3, 2024 10:15
@rekby rekby requested a review from a team as a code owner December 3, 2024 10:15
-p 2135:2135 -p 2136:2136 -p 8765:8765 -p 9092:9092 \
-v $(pwd)/ydb_certs:/ydb_certs -v $(pwd)/ydb_data:/ydb_data \
-e GRPC_TLS_PORT=2135 -e GRPC_PORT=2136 -e MON_PORT=8765 \
-e YDB_KAFKA_API_ENABLED=1 \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it's =1 instead of the port number like in the neighboring settings?
And to avoid doing it twice we could add the postgresql port, too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right - it will be consistent with other params and better understand numbers if enable kafka with dedicated port, I can change it.

What about: YDB_KAFKA_PROXY_PORT=9092 ?

postgres has different flags for enable and set custom port:
YDB_EXPERIMENTAL_PG and PGWIRE_LISTENING_PORT

I think it will be difficult to read a lot of params for customization in quick start.

May be create dedicated page for describe all env variable for container?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blinkov YDB_KAFKA_API_ENABLED=1 replaced by YDB_KAFKA_PROXY_PORT=9092

@github-actions
Copy link

github-actions bot commented Dec 3, 2024

2024-12-03 14:05:15 UTC Pre-commit check linux-x86_64-release-asan for 8e2bfb9 has started.
2024-12-03 14:05:28 UTC Artifacts will be uploaded here
2024-12-03 14:06:39 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Dec 3, 2024

2024-12-03 14:11:30 UTC Pre-commit check linux-x86_64-relwithdebinfo for b94c1ee has started.
2024-12-03 14:12:07 UTC Artifacts will be uploaded here
2024-12-03 14:15:13 UTC ya make is running...
🟢 2024-12-03 14:17:17 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-12-03 14:17:22 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Dec 3, 2024

2024-12-03 14:12:16 UTC Pre-commit check linux-x86_64-release-asan for b94c1ee has started.
2024-12-03 14:12:27 UTC Artifacts will be uploaded here
2024-12-03 14:14:55 UTC ya make is running...
🟢 2024-12-03 14:16:18 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-12-03 14:16:24 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Dec 3, 2024

✅ Documentation build

Revision built successfully
Revision preview link

@rekby rekby enabled auto-merge (squash) December 4, 2024 15:07
@rekby rekby merged commit 774b668 into ydb-platform:main Dec 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants