-
Notifications
You must be signed in to change notification settings - Fork 734
add kafka port to quick start #11935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add kafka port to quick start #11935
Conversation
|
⚪ Test history | Ya make output | Test bloat
🟢 |
|
⚪ Test history | Ya make output | Test bloat
🟢 |
✅ Documentation buildRevision built successfully |
|
⚪ Test history | Ya make output | Test bloat
🟢 |
|
⚪ Test history | Ya make output | Test bloat
🟢 |
✅ Documentation buildRevision built successfully |
ydb/docs/en/core/quickstart.md
Outdated
| -p 2135:2135 -p 2136:2136 -p 8765:8765 -p 9092:9092 \ | ||
| -v $(pwd)/ydb_certs:/ydb_certs -v $(pwd)/ydb_data:/ydb_data \ | ||
| -e GRPC_TLS_PORT=2135 -e GRPC_PORT=2136 -e MON_PORT=8765 \ | ||
| -e YDB_KAFKA_API_ENABLED=1 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why it's =1 instead of the port number like in the neighboring settings?
And to avoid doing it twice we could add the postgresql port, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right - it will be consistent with other params and better understand numbers if enable kafka with dedicated port, I can change it.
What about: YDB_KAFKA_PROXY_PORT=9092 ?
postgres has different flags for enable and set custom port:
YDB_EXPERIMENTAL_PG and PGWIRE_LISTENING_PORT
I think it will be difficult to read a lot of params for customization in quick start.
May be create dedicated page for describe all env variable for container?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blinkov YDB_KAFKA_API_ENABLED=1 replaced by YDB_KAFKA_PROXY_PORT=9092
|
⚪ Test history | Ya make output | Test bloat
🟢 |
|
⚪ Test history | Ya make output | Test bloat
🟢 |
✅ Documentation buildRevision built successfully |
merge after #11892
Changelog entry
...
Changelog category
Additional information
...