Enable kafka api by env variable #11892
Conversation
✅ Documentation buildRevision built successfully |
rekby
force-pushed
the
11005-local-kafka-api
branch
from
47a30db to
c9399b1
Compare
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
✅ Documentation buildRevision built successfully |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| if 'YDB_EXPERIMENTAL_PG' in os.environ: | ||
| optionals['pg_compatible_expirement'] = True | ||
|
|
||
| if os.environ.get('YDB_KAFKA_API_ENABLED', "0") == "1": |
There was a problem hiding this comment.
Чет у вас имхо какие-то проблемы
YDB_HARD_MEMORY_LIMIT_BYTES -- вот тут например для включения надо "просто чтобы была переменная окружения"
YDB_ENABLE_COLUMN_TABLES -- вот тут нужно чтобы "переменная окружения была true"
YDB_KAFKA_API_ENABLED -- вот тут нужно чтобы "переменная окружения была 1"
Я подозреваю, что у всех переменных ноги растут из того же места, если это так, можно ли с этим что-то сделать?
There was a problem hiding this comment.
Но если с точки зрения докер контейнера (это же для него делается?) все консистентно, то в рамках текущего ПР можно и забить
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
|
||
|
|
||
| def _is_true_string(s): | ||
| if s is None: |
There was a problem hiding this comment.
Предлагаю не писать так код: лучше когда s имеет определенный тип, а не не пойми что (NoneType или string)
Предлагаю убрать это условие, оно не нужно
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| return False | ||
|
|
||
| s = s.lower() | ||
| return s in ['1', 'true', 'yes'] |
There was a problem hiding this comment.
Можно еще on добавить как мне кажется
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
@maximyurchuk has triggered the import of a pull request, but it hasn't started. If you are a Yandex employee, you can view the log. |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
🟢 |
2 participants
#11005
Changelog entry
Allow to enable and kafka api port for ydb-local docker image
Changelog category
Additional information
...