Skip to content

move ReportLatencyCounters to common call #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 24, 2024
Merged

move ReportLatencyCounters to common call #1193

merged 2 commits into from
Jan 24, 2024

Conversation

@siarheivesialou
Copy link
Contributor

@siarheivesialou siarheivesialou commented Jan 22, 2024

No description provided.

@siarheivesialou siarheivesialou force-pushed the KIKIMR-20309_fix_leaking_metrics_in_http_proxy_and_return_5xx_for_timeout branch from a159974 to f685b27 Compare January 22, 2024 12:23
@siarheivesialou siarheivesialou changed the title move ReportLatencyCounters to ReplyWithError move ReportLatencyCounters to common call Jan 22, 2024
@siarheivesialou siarheivesialou force-pushed the KIKIMR-20309_fix_leaking_metrics_in_http_proxy_and_return_5xx_for_timeout branch 2 times, most recently from f754c2f to fa26208 Compare January 22, 2024 13:04
alexnick88
alexnick88 previously approved these changes Jan 22, 2024
View reviewed changes
@siarheivesialou siarheivesialou force-pushed the KIKIMR-20309_fix_leaking_metrics_in_http_proxy_and_return_5xx_for_timeout branch from fa26208 to 14d362e Compare January 22, 2024 13:32
@github-actions
Copy link

github-actions bot commented Jan 22, 2024 •
edited
Loading

⚪ 2024-01-23 12:34:27 UTC Pre-commit check for a041166 has started.
⚪ 2024-01-23 12:34:29 UTC Build linux-x86_64-release-asan is running...
🔴 2024-01-23 12:37:01 UTC Build failed. see the build logs.
⚪ 2024-01-23 12:37:09 UTC Tests are running...
🔴 2024-01-23 14:15:43 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15851 15720 0 22 77 32

@github-actions
Copy link

github-actions bot commented Jan 22, 2024 •
edited
Loading

⚪ 2024-01-23 12:28:38 UTC Pre-commit check for a041166 has started.
⚪ 2024-01-23 12:28:39 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-01-23 12:31:06 UTC Build failed. see the build logs.
⚪ 2024-01-23 12:31:15 UTC Tests are running...
🔴 2024-01-23 13:44:11 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59953 50698 0 1 9231 23

@siarheivesialou siarheivesialou force-pushed the KIKIMR-20309_fix_leaking_metrics_in_http_proxy_and_return_5xx_for_timeout branch from 14d362e to 2792402 Compare January 23, 2024 09:26
@siarheivesialou siarheivesialou marked this pull request as ready for review January 23, 2024 14:40
@siarheivesialou siarheivesialou merged commit 902255a into ydb-platform:main Jan 24, 2024
@pavelvelikhov pavelvelikhov mentioned this pull request Jan 24, 2024
Merged
@FloatingCrowbar FloatingCrowbar mentioned this pull request Jan 24, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Jan 25, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 25, 2024
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Jan 25, 2024
Merged
This was referenced Jan 25, 2024
Merged
Merged
Merged
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Jan 29, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 29, 2024
Merged
@shnikd shnikd mentioned this pull request Jan 29, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 29, 2024
Merged
@shnikd shnikd mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 5, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 5, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 5, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 6, 2024
Closed
Merged
This was referenced Feb 6, 2024
Merged
Merged
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Feb 8, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
This was referenced Feb 12, 2024
Merged
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Feb 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexnick88 alexnick88 alexnick88 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@siarheivesialou @alexnick88