Skip to content

Simplify error handling #1181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2024
Merged

Simplify error handling #1181

merged 1 commit into from
Jan 22, 2024

Conversation

@azevaykin
Copy link
Collaborator

@azevaykin azevaykin commented Jan 21, 2024

No description provided.

@github-actions
Copy link

github-actions bot commented Jan 21, 2024 •
edited
Loading

⚪ 2024-01-22 11:34:25 UTC Pre-commit check for 4cfd19d has started.
⚪ 2024-01-22 11:34:28 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-01-22 11:36:34 UTC Build failed. see the build logs.
⚪ 2024-01-22 11:36:47 UTC Tests are running...
🔴 2024-01-22 12:50:10 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59818 50520 0 53 9232 13

@github-actions
Copy link

github-actions bot commented Jan 21, 2024 •
edited
Loading

⚪ 2024-01-22 11:36:50 UTC Pre-commit check for 4cfd19d has started.
⚪ 2024-01-22 11:36:52 UTC Build linux-x86_64-release-asan is running...
🔴 2024-01-22 11:39:03 UTC Build failed. see the build logs.
⚪ 2024-01-22 11:39:17 UTC Tests are running...
🔴 2024-01-22 13:17:49 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15616 15541 0 34 33 8

@azevaykin azevaykin marked this pull request as ready for review January 21, 2024 08:25
@azevaykin azevaykin changed the title Move CalcSizes out of TEngineBay Move CalcSizes out of TEngineBay & rename Validate -> ExtractKeys Jan 22, 2024
azevaykin
azevaykin commented Jan 22, 2024
View reviewed changes
snaury
snaury requested changes Jan 22, 2024
View reviewed changes
snaury
snaury reviewed Jan 22, 2024
View reviewed changes
@azevaykin azevaykin changed the title Move CalcSizes out of TEngineBay & rename Validate -> ExtractKeys Move CalcSizes out of TEngineBay Jan 22, 2024
@azevaykin azevaykin closed this Jan 22, 2024
@azevaykin azevaykin reopened this Jan 22, 2024
@azevaykin azevaykin changed the title Move CalcSizes out of TEngineBay Simplify error handling Jan 22, 2024
@azevaykin azevaykin requested a review from snaury January 22, 2024 11:31
@azevaykin azevaykin merged commit c76a19b into ydb-platform:main Jan 22, 2024
@azevaykin azevaykin deleted the KeyValidator2 branch January 22, 2024 12:55
@pavelvelikhov pavelvelikhov mentioned this pull request Jan 24, 2024
Merged
@FloatingCrowbar FloatingCrowbar mentioned this pull request Jan 24, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Jan 25, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 25, 2024
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Jan 25, 2024
Merged
This was referenced Jan 25, 2024
Merged
Merged
Merged
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Jan 29, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 29, 2024
Merged
@shnikd shnikd mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 5, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 5, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 5, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 6, 2024
Closed
Merged
This was referenced Feb 6, 2024
Merged
Merged
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Feb 8, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
This was referenced Feb 12, 2024
Merged
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Feb 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snaury snaury snaury approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@azevaykin @snaury