Skip to content

Change conditions for enabling block input #11600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nepal merged 2 commits into from
Nov 19, 2024
Merged

Change conditions for enabling block input #11600

nepal merged 2 commits into from
Nov 19, 2024

Conversation

@loochek
Copy link
Contributor

@loochek loochek commented Nov 14, 2024

Changelog entry

Change conditions for enabling block input

Changelog category

  • Not for changelog (changelog entry is not required)

@loochek loochek requested a review from a team as a code owner November 14, 2024 11:53
@github-actions
Copy link

github-actions bot commented Nov 14, 2024

Hi! Thank you for contributing!
The tests on this PR will run after a maintainer adds an ok-to-test label to this PR manually. Thank you for your patience!

@maximyurchuk maximyurchuk added the ok-to-test Special label used to approve a PR for testing on our infrastructure label Nov 14, 2024
@github-actions github-actions bot removed the ok-to-test Special label used to approve a PR for testing on our infrastructure label Nov 14, 2024
@github-actions
Copy link

github-actions bot commented Nov 14, 2024 •
edited
Loading

⚪ 2024-11-14 12:23:32 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3600e89 has started.
⚪ 2024-11-14 12:23:37 UTC Artifacts will be uploaded here
⚪ 2024-11-14 12:26:38 UTC ya make is running...
🟡 2024-11-14 13:30:42 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73779 59502 0 16 14212 49

⚪ 2024-11-14 13:38:13 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-11-14 13:49:57 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
292 (only retried tests) 177 0 1 7 107

⚪ 2024-11-14 13:50:07 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-11-14 14:01:44 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
108 (only retried tests) 0 0 1 0 107

🟢 2024-11-14 14:01:53 UTC Build successful.
🔴 2024-11-14 14:02:17 UTC ydbd size 2.8 GiB changed* by +3.0 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 2ff8722 merge: 3600e89 diff diff %
ydbd size 3 049 878 192 Bytes 3 052 981 936 Bytes +3.0 MiB +0.102%
ydbd stripped size 482 454 016 Bytes 483 021 088 Bytes +553.8 KiB +0.118%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 14, 2024 •
edited
Loading

⚪ 2024-11-14 12:26:36 UTC Pre-commit check linux-x86_64-release-asan for 3600e89 has started.
⚪ 2024-11-14 12:26:46 UTC Artifacts will be uploaded here
⚪ 2024-11-14 12:29:44 UTC ya make is running...
🟡 2024-11-14 13:36:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9146 9062 0 31 6 47

🟢 2024-11-14 13:37:29 UTC Build successful.
🔴 2024-11-14 13:37:58 UTC ydbd size 5.8 GiB changed* by +7.1 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 2ff8722 merge: 3600e89 diff diff %
ydbd size 6 171 877 816 Bytes 6 179 272 784 Bytes +7.1 MiB +0.120%
ydbd stripped size 1 538 268 624 Bytes 1 540 776 304 Bytes +2.4 MiB +0.163%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

nepal
nepal previously approved these changes Nov 14, 2024
View reviewed changes
@nepal nepal added the area/yql YQL query language issues label Nov 19, 2024
@loochek loochek force-pushed the yql-yt-block-input-pragma branch from 349bc2d to 76c5e02 Compare November 19, 2024 12:33
@maximyurchuk maximyurchuk added the ok-to-test Special label used to approve a PR for testing on our infrastructure label Nov 19, 2024
@github-actions github-actions bot removed the ok-to-test Special label used to approve a PR for testing on our infrastructure label Nov 19, 2024
@github-actions
Copy link

github-actions bot commented Nov 19, 2024 •
edited
Loading

⚪ 2024-11-19 12:50:32 UTC Pre-commit check linux-x86_64-release-asan for 94a17dd has started.
⚪ 2024-11-19 12:50:43 UTC Artifacts will be uploaded here
⚪ 2024-11-19 12:53:46 UTC ya make is running...
🟡 2024-11-19 13:59:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9151 9078 0 18 8 47

🟢 2024-11-19 13:59:57 UTC Build successful.
🟢 2024-11-19 14:00:25 UTC ydbd size 4.9 GiB changed* by -256 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 7365427 merge: 94a17dd diff diff %
ydbd size 5 263 270 384 Bytes 5 263 270 128 Bytes -256 Bytes -0.000%
ydbd stripped size 1 351 576 880 Bytes 1 351 576 688 Bytes -192 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 19, 2024 •
edited
Loading

⚪ 2024-11-19 12:51:19 UTC Pre-commit check linux-x86_64-relwithdebinfo for 94a17dd has started.
⚪ 2024-11-19 12:51:31 UTC Artifacts will be uploaded here
⚪ 2024-11-19 12:54:46 UTC ya make is running...
🟡 2024-11-19 13:59:42 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73822 59721 0 1 13986 114

⚪ 2024-11-19 14:06:38 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-19 14:18:47 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
116 (only retried tests) 7 0 0 0 109

🟢 2024-11-19 14:18:55 UTC Build successful.
🟢 2024-11-19 14:19:14 UTC ydbd size 2.5 GiB changed* by -48 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 7365427 merge: 94a17dd diff diff %
ydbd size 2 685 648 784 Bytes 2 685 648 736 Bytes -48 Bytes -0.000%
ydbd stripped size 481 258 352 Bytes 481 258 352 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nepal nepal merged commit ea6af5f into ydb-platform:main Nov 19, 2024
13 checks passed
@GrigoriyPA GrigoriyPA mentioned this pull request Nov 21, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Nov 21, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Nov 25, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Nov 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nepal nepal nepal approved these changes

Assignees

No one assigned

Labels

area/yql YQL query language issues external not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@loochek @nepal @maximyurchuk