Skip to content

YQ-3892 fix data race in json filters #11827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

GrigoriyPA
Copy link
Collaborator

@GrigoriyPA GrigoriyPA commented Nov 21, 2024

Changelog entry

Fixed data race in json filters

Changelog category

  • Bugfix

Additional information

@GrigoriyPA GrigoriyPA requested a review from a team as a code owner November 21, 2024 06:44
@GrigoriyPA GrigoriyPA requested a review from dorooleg November 21, 2024 06:44
Copy link

github-actions bot commented Nov 21, 2024

2024-11-21 06:47:36 UTC Pre-commit check linux-x86_64-relwithdebinfo for e15989c has started.
2024-11-21 06:47:48 UTC Artifacts will be uploaded here
2024-11-21 06:50:47 UTC ya make is running...
🟡 2024-11-21 07:47:04 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40074 34376 0 4 5576 118

2024-11-21 07:50:25 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-11-21 08:01:58 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
139 (only retried tests) 30 0 1 1 107

2024-11-21 08:02:07 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-11-21 08:13:20 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
108 (only retried tests) 1 0 0 0 107

🟢 2024-11-21 08:13:27 UTC Build successful.
🟢 2024-11-21 08:13:50 UTC ydbd size 2.5 GiB changed* by +2.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 41baadd merge: e15989c diff diff %
ydbd size 2 689 511 792 Bytes 2 689 514 568 Bytes +2.7 KiB +0.000%
ydbd stripped size 482 297 296 Bytes 482 297 872 Bytes +576 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 21, 2024

2024-11-21 06:48:13 UTC Pre-commit check linux-x86_64-release-asan for e15989c has started.
2024-11-21 06:48:23 UTC Artifacts will be uploaded here
2024-11-21 06:51:17 UTC ya make is running...
🟡 2024-11-21 07:56:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
8880 8805 0 17 9 49

🟢 2024-11-21 07:57:04 UTC Build successful.
🟢 2024-11-21 07:57:33 UTC ydbd size 4.9 GiB changed* by +6.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 41baadd merge: e15989c diff diff %
ydbd size 5 280 001 744 Bytes 5 280 007 856 Bytes +6.0 KiB +0.000%
ydbd stripped size 1 358 852 400 Bytes 1 358 853 616 Bytes +1.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA merged commit b76c6f8 into ydb-platform:main Nov 21, 2024
12 checks passed
@GrigoriyPA GrigoriyPA deleted the YQ-3892-fix-json-parser-faults branch November 21, 2024 12:16
GrigoriyPA added a commit to GrigoriyPA/ydb that referenced this pull request Nov 21, 2024
dahbka-lis pushed a commit to dahbka-lis/ydb that referenced this pull request Nov 25, 2024
dahbka-lis pushed a commit to dahbka-lis/ydb that referenced this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants