Skip to content

not null constraint fix for column addition #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 23, 2024
Merged

not null constraint fix for column addition #1137

merged 3 commits into from
Jan 23, 2024

Conversation

gridnevvvit
Copy link
Member

Changelog entry

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

respect not null constraint when column is added.

...

@gridnevvvit gridnevvvit force-pushed the default-fixes-for-not-null branch from 62635c6 to 35001da Compare January 18, 2024 16:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 19, 2024 •
edited
Loading

⚪ 2024-01-23 09:38:58 UTC Pre-commit check for 5384b6e has started.
⚪ 2024-01-23 09:39:01 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-01-23 09:42:12 UTC Build failed. see the build logs.
⚪ 2024-01-23 09:42:28 UTC Tests are running...
🔴 2024-01-23 11:07:41 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59955 50682 0 4 9235 34

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 19, 2024 •
edited
Loading

⚪ 2024-01-23 09:39:07 UTC Pre-commit check for 5384b6e has started.
⚪ 2024-01-23 09:39:09 UTC Build linux-x86_64-release-asan is running...
🔴 2024-01-23 09:42:57 UTC Build failed. see the build logs.
⚪ 2024-01-23 09:43:08 UTC Tests are running...
🔴 2024-01-23 11:21:54 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15849 15753 0 16 59 21

@gridnevvvit gridnevvvit force-pushed the default-fixes-for-not-null branch 3 times, most recently from 4cf762d to d3e4ebf Compare January 22, 2024 17:21
@gridnevvvit gridnevvvit force-pushed the default-fixes-for-not-null branch from d3e4ebf to 5384b6e Compare January 23, 2024 09:36
@gridnevvvit gridnevvvit merged commit 0ef82a6 into ydb-platform:main Jan 23, 2024
@gridnevvvit gridnevvvit deleted the default-fixes-for-not-null branch January 23, 2024 11:52
@pavelvelikhov pavelvelikhov mentioned this pull request Jan 24, 2024
Merged
@FloatingCrowbar FloatingCrowbar mentioned this pull request Jan 24, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Jan 25, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 25, 2024
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Jan 25, 2024
Merged
This was referenced Jan 25, 2024
Merged
Merged
Merged
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Jan 29, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 29, 2024
Merged
@shnikd shnikd mentioned this pull request Jan 29, 2024
Merged
This was referenced Jan 29, 2024
Merged
Merged
@shnikd shnikd mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 5, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 5, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 5, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 6, 2024
Closed
Merged
This was referenced Feb 6, 2024
Merged
Merged
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Feb 8, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
This was referenced Feb 12, 2024
Merged
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Feb 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherednik dcherednik dcherednik approved these changes

@qrort qrort qrort approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gridnevvvit @dcherednik @qrort