Skip to content

Conversation

alexvru
Copy link
Collaborator

@alexvru alexvru commented Nov 1, 2024

Changelog entry

Add feature flag to enable drive serial numbers discovery

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

Drive discovery can be controlled with feature flag from now on.

Copy link

github-actions bot commented Nov 1, 2024

2024-11-01 09:21:06 UTC Pre-commit check linux-x86_64-release-asan for 290804b has started.
2024-11-01 09:21:18 UTC Artifacts will be uploaded here
2024-11-01 09:24:41 UTC ya make is running...
🟡 2024-11-01 11:05:09 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10673 10598 0 33 10 32

🟢 2024-11-01 11:06:05 UTC Build successful.
🟢 2024-11-01 11:06:39 UTC ydbd size 5.7 GiB changed* by -2.0 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 497f6e4 merge: 290804b diff diff %
ydbd size 6 151 724 848 Bytes 6 149 610 320 Bytes -2.0 MiB -0.034%
ydbd stripped size 1 534 747 728 Bytes 1 534 978 608 Bytes +225.5 KiB +0.015%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 1, 2024

2024-11-01 09:21:31 UTC Pre-commit check linux-x86_64-relwithdebinfo for 290804b has started.
2024-11-01 09:21:43 UTC Artifacts will be uploaded here
2024-11-01 09:25:23 UTC ya make is running...
🟡 2024-11-01 10:56:28 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41728 36068 0 7 5551 102

2024-11-01 11:00:26 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-11-01 11:12:10 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
104 (only retried tests) 11 0 0 1 92

🟢 2024-11-01 11:12:17 UTC Build successful.
🟢 2024-11-01 11:12:37 UTC ydbd size 2.8 GiB changed* by +3.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3ae23d5 merge: 290804b diff diff %
ydbd size 3 039 125 472 Bytes 3 039 129 376 Bytes +3.8 KiB +0.000%
ydbd stripped size 481 444 184 Bytes 481 444 568 Bytes +384 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru merged commit b574e5a into ydb-platform:main Nov 1, 2024
11 checks passed
@alexvru alexvru deleted the nodewarden/list-node-drives-with-feature-flag branch November 1, 2024 12:32
@alexvru alexvru self-assigned this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants