Skip to content

Add feature flag to enable drive serial numbers discovery (merge from main #11183) #11255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

alexvru
Copy link
Collaborator

@alexvru alexvru commented Nov 5, 2024

Changelog entry

Add feature flag to enable drive serial numbers discovery

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

Drive discovery can be controlled with feature flag from now on.

@alexvru alexvru requested a review from a team as a code owner November 5, 2024 08:37
Copy link

github-actions bot commented Nov 5, 2024

2024-11-05 08:41:24 UTC Pre-commit check for f0edd21 has started.
2024-11-05 08:44:21 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-11-05 09:26:20 UTC Build successful.

Copy link

github-actions bot commented Nov 5, 2024

2024-11-05 08:41:37 UTC Pre-commit check for f0edd21 has started.
2024-11-05 08:44:42 UTC Build linux-x86_64-release-asan is running...
🟢 2024-11-05 09:36:05 UTC Build successful.
2024-11-05 09:36:23 UTC Tests are running...
🔴 2024-11-05 11:50:25 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11729 11633 0 28 23 45

🟢 2024-11-05 11:51:14 UTC ydbd size 5.6 GiB changed* by +3.4 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 66baaeb merge: f0edd21 diff diff %
ydbd size 5 990 435 688 Bytes 5 990 439 208 Bytes +3.4 KiB +0.000%
ydbd stripped size 1 501 492 352 Bytes 1 501 492 608 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Nov 5, 2024

2024-11-05 08:41:56 UTC Pre-commit check for f0edd21 has started.
2024-11-05 08:45:06 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-11-05 09:55:48 UTC Build successful.
2024-11-05 09:56:06 UTC Tests are running...
🔴 2024-11-05 11:50:28 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40288 35007 0 16 5220 45

🟢 2024-11-05 11:51:14 UTC ydbd size 8.2 GiB changed* by +8.1 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 66baaeb merge: f0edd21 diff diff %
ydbd size 8 856 905 680 Bytes 8 856 913 984 Bytes +8.1 KiB +0.000%
ydbd stripped size 483 653 544 Bytes 483 653 928 Bytes +384 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru merged commit 7dd309e into ydb-platform:stable-24-3 Nov 5, 2024
8 of 12 checks passed
@alexvru alexvru deleted the merge/24-3/11183 branch November 5, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants